refactor(api): integrate year-grouped performance tests into existing test cases

Move getChartByYear assertions from separate it.only blocks into the
existing test cases to avoid duplicating activity setup and calculator
initialization, addressing review feedback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd.spec.ts

@@ -261,37 +261,6 @@ describe('PortfolioCalculator', () => {
         { date: '2021-01-01', investment: 44558.42 },
         { date: '2022-01-01', investment: 0 }
       ]);
-    });
-
-    it.only('with BTCUSD buy - performance grouped by year', async () => {
-      jest.useFakeTimers().setSystemTime(parseDate('2022-01-14').getTime());
-
-      const activities: Activity[] = exportResponse.activities.map(
-        (activity) => ({
-          ...activityDummyData,
-          ...activity,
-          date: parseDate(activity.date),
-          feeInAssetProfileCurrency: 4.46,
-          feeInBaseCurrency: 4.46,
-          SymbolProfile: {
-            ...symbolProfileDummyData,
-            currency: 'USD',
-            dataSource: activity.dataSource,
-            name: 'Bitcoin',
-            symbol: activity.symbol
-          },
-          unitPriceInAssetProfileCurrency: 44558.42
-        })
-      );
-
-      const portfolioCalculator = portfolioCalculatorFactory.createCalculator({
-        activities,
-        calculationType: PerformanceCalculationType.ROAI,
-        currency: exportResponse.user.settings.currency,
-        userId: userDummyData.id
-      });
-
-      await portfolioCalculator.computeSnapshot();
 
       const { chart } = await portfolioCalculator.getPerformance({
         end: parseDate('2022-01-14'),

apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-googl-buy.spec.ts

@@ -233,38 +233,6 @@ describe('PortfolioCalculator', () => {
       expect(investmentsByYear).toEqual([
         { date: '2023-01-01', investment: 82.329056 }
       ]);
-    });
-
-    it.only('with GOOGL buy - performance grouped by year', async () => {
-      jest.useFakeTimers().setSystemTime(parseDate('2023-07-10').getTime());
-
-      const activities: Activity[] = [
-        {
-          ...activityDummyData,
-          date: new Date('2023-01-03'),
-          feeInAssetProfileCurrency: 1,
-          feeInBaseCurrency: 0.9238,
-          quantity: 1,
-          SymbolProfile: {
-            ...symbolProfileDummyData,
-            currency: 'USD',
-            dataSource: 'YAHOO',
-            name: 'Alphabet Inc.',
-            symbol: 'GOOGL'
-          },
-          type: 'BUY',
-          unitPriceInAssetProfileCurrency: 89.12
-        }
-      ];
-
-      const portfolioCalculator = portfolioCalculatorFactory.createCalculator({
-        activities,
-        calculationType: PerformanceCalculationType.ROAI,
-        currency: 'CHF',
-        userId: userDummyData.id
-      });
-
-      await portfolioCalculator.computeSnapshot();
 
       const { chart } = await portfolioCalculator.getPerformance({
         end: parseDate('2023-07-10'),

apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-novn-buy-and-sell.spec.ts

@@ -264,37 +264,6 @@ describe('PortfolioCalculator', () => {
       expect(investmentsByYear).toEqual([
         { date: '2022-01-01', investment: 0 }
       ]);
-    });
-
-    it.only('with NOVN.SW buy and sell - performance grouped by year', async () => {
-      jest.useFakeTimers().setSystemTime(parseDate('2022-04-11').getTime());
-
-      const activities: Activity[] = exportResponse.activities.map(
-        (activity) => ({
-          ...activityDummyData,
-          ...activity,
-          date: parseDate(activity.date),
-          feeInAssetProfileCurrency: activity.fee,
-          feeInBaseCurrency: activity.fee,
-          SymbolProfile: {
-            ...symbolProfileDummyData,
-            currency: activity.currency,
-            dataSource: activity.dataSource,
-            name: 'Novartis AG',
-            symbol: activity.symbol
-          },
-          unitPriceInAssetProfileCurrency: activity.unitPrice
-        })
-      );
-
-      const portfolioCalculator = portfolioCalculatorFactory.createCalculator({
-        activities,
-        calculationType: PerformanceCalculationType.ROAI,
-        currency: exportResponse.user.settings.currency,
-        userId: userDummyData.id
-      });
-
-      await portfolioCalculator.computeSnapshot();
 
       const { chart } = await portfolioCalculator.getPerformance({
         end: parseDate('2022-04-11'),