Fix PR comments

apps/client/src/app/components/admin-market-data/admin-market-data.component.ts

@@ -206,9 +206,6 @@ export class GfAdminMarketDataComponent
     this.displayedColumns.push('comment');
     this.displayedColumns.push('actions');
 
-    if (this.route.snapshot.routeConfig.path === 'market-data/create') {
-      this.openCreateAssetProfileDialog();
-    } else {
     this.route.paramMap
       .pipe(takeUntil(this.unsubscribeSubject))
       .subscribe((paramMap) => {
@@ -216,13 +213,11 @@ export class GfAdminMarketDataComponent
         const symbol = paramMap.get('symbol');
 
         if (dataSource && symbol) {
-            this.openAssetProfileDialog({
+          this.openAssetProfileDialog({ dataSource, symbol });
-              dataSource,
+        } else if (this.route.snapshot.routeConfig.path.endsWith('/create')) {
-              symbol
+          this.openCreateAssetProfileDialog();
-            });
         }
       });
-    }
 
     this.userService.stateChanged
       .pipe(takeUntil(this.unsubscribeSubject))
@@ -234,7 +229,6 @@ export class GfAdminMarketDataComponent
             this.user.settings.locale
           );
         }
-      });
 
         this.filters$
           .pipe(distinctUntilChanged(), takeUntil(this.unsubscribeSubject))
@@ -243,6 +237,7 @@ export class GfAdminMarketDataComponent
 
             this.loadData();
           });
+      });
 
     addIcons({
       addOutline,
@@ -278,6 +273,13 @@ export class GfAdminMarketDataComponent
     this.selection = new SelectionModel(true);
   }
 
+  public getRouterLinkToAdminControlMarketData({
+    dataSource,
+    symbol
+  }: AssetProfileIdentifier) {
+    return [...this.routerLinkAdminControlMarketData, dataSource, symbol];
+  }
+
   public onChangePage(page: PageEvent) {
     this.loadData({
       pageIndex: page.pageIndex,
@@ -353,10 +355,6 @@ export class GfAdminMarketDataComponent
     });
   }
 
-  public getRouterLinkToAdminControlMarketData(dataSource, symbol) {
-    return [...this.routerLinkAdminControlMarketData, dataSource, symbol];
-  }
-
   public ngOnDestroy() {
     this.unsubscribeSubject.next();
     this.unsubscribeSubject.complete();

apps/client/src/app/components/admin-market-data/admin-market-data.html

@@ -256,10 +256,10 @@
                 <a
                   mat-menu-item
                   [routerLink]="
-                    getRouterLinkToAdminControlMarketData(
+                    getRouterLinkToAdminControlMarketData({
-                      element.dataSource,
+                      dataSource: element.dataSource,
-                      element.symbol
+                      symbol: element.symbol
-                    )
+                    })
                   "
                 >
                   <span class="align-items-center d-flex">

apps/client/src/app/components/holding-detail-dialog/holding-detail-dialog.component.ts

@@ -8,6 +8,7 @@ import { CreateOrderDto } from '@ghostfolio/common/dtos';
 import { DATE_FORMAT, downloadAsFile } from '@ghostfolio/common/helper';
 import {
   Activity,
+  AssetProfileIdentifier,
   DataProviderInfo,
   EnhancedSymbolProfile,
   Filter,
@@ -546,6 +547,13 @@ export class GfHoldingDetailDialogComponent implements OnDestroy, OnInit {
       });
   }
 
+  public getRouterLinkToAdminControlMarketData({
+    dataSource,
+    symbol
+  }: AssetProfileIdentifier) {
+    return [...this.routerLinkAdminControlMarketData, dataSource, symbol];
+  }
+
   public onCloneActivity(aActivity: Activity) {
     this.router.navigate(
       internalRoutes.portfolio.subRoutes.activities.routerLink,
@@ -618,14 +626,6 @@ export class GfHoldingDetailDialogComponent implements OnDestroy, OnInit {
     }
   }
 
-  public getRouterLinkToAdminControlMarketDataForDataSourceAndSymbol() {
-    return [
-      ...this.routerLinkAdminControlMarketData,
-      this.SymbolProfile?.dataSource,
-      this.SymbolProfile?.symbol
-    ];
-  }
-
   public onUpdateActivity(aActivity: Activity) {
     this.router.navigate(
       internalRoutes.portfolio.subRoutes.activities.routerLink,