Refactoring

apps/api/src/app/auth/oidc.strategy.ts

@@ -47,8 +47,8 @@ export class OidcStrategy extends PassportStrategy(Strategy, 'oidc') {
         context?.claims?.sub;
 
       const jwt = await this.authService.validateOAuthLogin({
-        provider: Provider.OIDC,
-        thirdPartyId
+        thirdPartyId,
+        provider: Provider.OIDC
       });
 
       if (!thirdPartyId) {
@@ -56,6 +56,7 @@ export class OidcStrategy extends PassportStrategy(Strategy, 'oidc') {
           `Missing subject identifier in OIDC response from ${issuer}`,
           'OidcStrategy'
         );
+
         throw new Error('Missing subject identifier in OIDC response');
       }
 

apps/api/src/services/configuration/configuration.service.ts

@@ -58,14 +58,14 @@ export class ConfigurationService {
       JWT_SECRET_KEY: str(),
       MAX_ACTIVITIES_TO_IMPORT: num({ default: Number.MAX_SAFE_INTEGER }),
       MAX_CHART_ITEMS: num({ default: 365 }),
-      OIDC_AUTHORIZATION_URL: str(),
-      OIDC_CALLBACK_URL: str(),
-      OIDC_CLIENT_ID: str(),
-      OIDC_CLIENT_SECRET: str(),
-      OIDC_ISSUER: str(),
+      OIDC_AUTHORIZATION_URL: str({ default: '' }),
+      OIDC_CALLBACK_URL: str({ default: '' }),
+      OIDC_CLIENT_ID: str({ default: '' }),
+      OIDC_CLIENT_SECRET: str({ default: '' }),
+      OIDC_ISSUER: str({ default: '' }),
       OIDC_SCOPE: json({ default: ['openid'] }),
-      OIDC_TOKEN_URL: str(),
-      OIDC_USER_INFO_URL: str(),
+      OIDC_TOKEN_URL: str({ default: '' }),
+      OIDC_USER_INFO_URL: str({ default: '' }),
       PORT: port({ default: DEFAULT_PORT }),
       PROCESSOR_GATHER_ASSET_PROFILE_CONCURRENCY: num({
         default: DEFAULT_PROCESSOR_GATHER_ASSET_PROFILE_CONCURRENCY