refactor(client): address review comments for strict templates

apps/client/src/app/components/account-detail-dialog/account-detail-dialog.html

@@ -153,7 +153,6 @@
           [hasPermissionToCreateActivity]="data.hasPermissionToCreateActivity"
           [hasPermissionToDeleteActivity]="false"
           [hasPermissionToExportActivities]="!showValuesInPercentage()"
-          [hasPermissionToFilter]="false"
           [hasPermissionToOpenDetails]="false"
           [hasPermissionToUpdateActivity]="data.hasPermissionToUpdateActivity"
           [locale]="user?.settings?.locale"

apps/client/src/app/components/holding-detail-dialog/holding-detail-dialog.html

@@ -383,7 +383,6 @@
           [hasPermissionToExportActivities]="
             !data.impersonationId && !user?.settings?.isRestrictedView
           "
-          [hasPermissionToFilter]="false"
           [hasPermissionToOpenDetails]="false"
           [hasPermissionToUpdateActivity]="data.hasPermissionToUpdateActivity"
           [locale]="data.locale"

apps/client/src/app/components/markets/markets.component.ts

@@ -28,6 +28,7 @@ import {
   signal
 } from '@angular/core';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
+import { isNumber } from 'lodash-es';
 import { DeviceDetectorService } from 'ngx-device-detector';
 
 @Component({
@@ -158,18 +159,20 @@ export class GfMarketsComponent implements OnInit {
     this.fearAndGreedIndex =
       this.fearAndGreedIndexData[this.fearAndGreedIndexMode]?.marketPrice;
 
-    this.historicalDataItems = [
+    const historicalDataItems = (
-      ...(
+      this.fearAndGreedIndexData[this.fearAndGreedIndexMode]?.historicalData ??
-        this.fearAndGreedIndexData[this.fearAndGreedIndexMode]
+      []
-          ?.historicalData ?? []
+    ).filter((item): item is LineChartItem => {
-      ).map(({ date, value }) => ({
+      return isNumber(item.value);
-        date,
+    });
-        value: value ?? 0
+
-      })),
+    if (isNumber(this.fearAndGreedIndex)) {
-      {
+      historicalDataItems.push({
         date: resetHours(new Date()).toISOString(),
-        value: this.fearAndGreedIndex ?? 0
+        value: this.fearAndGreedIndex
+      });
     }
-    ];
+
+    this.historicalDataItems = historicalDataItems;
   }
 }

apps/client/tsconfig.json

@@ -14,7 +14,15 @@
     }
   ],
   "angularCompilerOptions": {
+    "extendedDiagnostics": {
+      "checks": {
+        // TODO: Remove once the fields are typed as optional
+        "nullishCoalescingNotNullable": "suppress",
+        "optionalChainNotNullable": "suppress"
+      }
+    },
     "strictInjectionParameters": true,
+    "strictInputAccessModifiers": true,
     "strictTemplates": true
   },
   "compilerOptions": {