Browse Source

Task/remove deprecated firstOrderDate from portfolio performance endpoint response (#7483)

* Remove deprecated firstOrderDate

* Update changelog
pull/7253/head^2
Thomas Kaul 1 week ago
committed by GitHub
parent
commit
5e9ac0169e
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 1
      CHANGELOG.md
  2. 2
      apps/api/src/app/portfolio/portfolio.service.ts
  3. 6
      libs/common/src/lib/interfaces/responses/portfolio-performance-response.interface.ts

1
CHANGELOG.md

@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Harmonized the data format of the export functionality - Harmonized the data format of the export functionality
- Removed the deprecated `firstOrderDate` attribute from the `GET api/v2/portfolio/performance` endpoint response
- Improved the language localization for German (`de`) - Improved the language localization for German (`de`)
- Upgraded `prisma` from version `7.8.0` to `7.9.1` - Upgraded `prisma` from version `7.8.0` to `7.9.1`

2
apps/api/src/app/portfolio/portfolio.service.ts

@ -1035,7 +1035,6 @@ export class PortfolioService {
return { return {
chart: [], chart: [],
dateOfFirstActivity: undefined, dateOfFirstActivity: undefined,
firstOrderDate: undefined,
hasErrors: false, hasErrors: false,
performance: { performance: {
currentNetWorth: 0, currentNetWorth: 0,
@ -1093,7 +1092,6 @@ export class PortfolioService {
errors, errors,
hasErrors, hasErrors,
dateOfFirstActivity: parseDate(historicalData[0]?.date), dateOfFirstActivity: parseDate(historicalData[0]?.date),
firstOrderDate: parseDate(historicalData[0]?.date),
performance: { performance: {
netPerformance, netPerformance,
netPerformanceWithCurrencyEffect, netPerformanceWithCurrencyEffect,

6
libs/common/src/lib/interfaces/responses/portfolio-performance-response.interface.ts

@ -5,11 +5,5 @@ import { ResponseError } from './errors.interface';
export interface PortfolioPerformanceResponse extends ResponseError { export interface PortfolioPerformanceResponse extends ResponseError {
chart?: HistoricalDataItem[]; chart?: HistoricalDataItem[];
dateOfFirstActivity: Date; dateOfFirstActivity: Date;
/**
* @deprecated Use `dateOfFirstActivity` instead
*/
firstOrderDate: Date;
performance: PortfolioPerformance; performance: PortfolioPerformance;
} }

Loading…
Cancel
Save