Browse Source
Task/remove deprecated firstOrderDate from portfolio performance endpoint response (#7483)
* Remove deprecated firstOrderDate
* Update changelog
pull/7253/head^2
Thomas Kaul
1 week ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with
1 additions and
8 deletions
-
CHANGELOG.md
-
apps/api/src/app/portfolio/portfolio.service.ts
-
libs/common/src/lib/interfaces/responses/portfolio-performance-response.interface.ts
|
|
|
@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
### Changed |
|
|
|
|
|
|
|
- Harmonized the data format of the export functionality |
|
|
|
- Removed the deprecated `firstOrderDate` attribute from the `GET api/v2/portfolio/performance` endpoint response |
|
|
|
- Improved the language localization for German (`de`) |
|
|
|
- Upgraded `prisma` from version `7.8.0` to `7.9.1` |
|
|
|
|
|
|
|
|
|
|
|
@ -1035,7 +1035,6 @@ export class PortfolioService { |
|
|
|
return { |
|
|
|
chart: [], |
|
|
|
dateOfFirstActivity: undefined, |
|
|
|
firstOrderDate: undefined, |
|
|
|
hasErrors: false, |
|
|
|
performance: { |
|
|
|
currentNetWorth: 0, |
|
|
|
@ -1093,7 +1092,6 @@ export class PortfolioService { |
|
|
|
errors, |
|
|
|
hasErrors, |
|
|
|
dateOfFirstActivity: parseDate(historicalData[0]?.date), |
|
|
|
firstOrderDate: parseDate(historicalData[0]?.date), |
|
|
|
performance: { |
|
|
|
netPerformance, |
|
|
|
netPerformanceWithCurrencyEffect, |
|
|
|
|
|
|
|
@ -5,11 +5,5 @@ import { ResponseError } from './errors.interface'; |
|
|
|
export interface PortfolioPerformanceResponse extends ResponseError { |
|
|
|
chart?: HistoricalDataItem[]; |
|
|
|
dateOfFirstActivity: Date; |
|
|
|
|
|
|
|
/** |
|
|
|
* @deprecated Use `dateOfFirstActivity` instead |
|
|
|
*/ |
|
|
|
firstOrderDate: Date; |
|
|
|
|
|
|
|
performance: PortfolioPerformance; |
|
|
|
} |
|
|
|
|