Browse Source
			
			
			Bugfix/fix dates in value component (#810)
			
				* Fix dates
* Update changelog
			
			
				pull/811/head
			
			
		 
		
			
				
					
						 Thomas Kaul
					
					4 years ago
						Thomas Kaul
					
					4 years ago
					
						
							committed by
							
								 GitHub
								GitHub
							
						 
					
				 
				
			 
		 
		
			
				
					
					No known key found for this signature in database
					
						
							GPG Key ID: 4AEE18F83AFDEB23
						
					
				
			
		
		
		
	
		
			
				 3 changed files with 
16 additions and 
9 deletions
			 
			
		 
		
			
				- 
					
					
					 
					CHANGELOG.md
				
- 
					
					
					 
					apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
				
- 
					
					
					 
					libs/ui/src/lib/value/value.component.ts
				
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. | 
			
		
	
		
			
				
					|  |  |  | The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | 
			
		
	
		
			
				
					|  |  |  | and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ## Unreleased | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ### Fixed | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | - Fixed an issue with dates in the value component | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ## 1.132.1 - 06.04.2022 | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ### Fixed | 
			
		
	
	
		
			
				
					|  |  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -111,6 +111,8 @@ | 
			
		
	
		
			
				
					|  |  |  |         <gf-value | 
			
		
	
		
			
				
					|  |  |  |           label="First Buy Date" | 
			
		
	
		
			
				
					|  |  |  |           size="medium" | 
			
		
	
		
			
				
					|  |  |  |           [isDate]="true" | 
			
		
	
		
			
				
					|  |  |  |           [locale]="data.locale" | 
			
		
	
		
			
				
					|  |  |  |           [value]="firstBuyDate" | 
			
		
	
		
			
				
					|  |  |  |         ></gf-value> | 
			
		
	
		
			
				
					|  |  |  |       </div> | 
			
		
	
	
		
			
				
					|  |  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -5,7 +5,6 @@ import { | 
			
		
	
		
			
				
					|  |  |  |   OnChanges | 
			
		
	
		
			
				
					|  |  |  | } from '@angular/core'; | 
			
		
	
		
			
				
					|  |  |  | import { getLocale } from '@ghostfolio/common/helper'; | 
			
		
	
		
			
				
					|  |  |  | import { isDate, parseISO } from 'date-fns'; | 
			
		
	
		
			
				
					|  |  |  | import { isNumber } from 'lodash'; | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | @Component({ | 
			
		
	
	
		
			
				
					|  |  | @ -19,6 +18,7 @@ export class ValueComponent implements OnChanges { | 
			
		
	
		
			
				
					|  |  |  |   @Input() currency = ''; | 
			
		
	
		
			
				
					|  |  |  |   @Input() isAbsolute = false; | 
			
		
	
		
			
				
					|  |  |  |   @Input() isCurrency = false; | 
			
		
	
		
			
				
					|  |  |  |   @Input() isDate = false; | 
			
		
	
		
			
				
					|  |  |  |   @Input() isPercent = false; | 
			
		
	
		
			
				
					|  |  |  |   @Input() label = ''; | 
			
		
	
		
			
				
					|  |  |  |   @Input() locale = getLocale(); | 
			
		
	
	
		
			
				
					|  |  | @ -100,17 +100,16 @@ export class ValueComponent implements OnChanges { | 
			
		
	
		
			
				
					|  |  |  |         this.isNumber = false; | 
			
		
	
		
			
				
					|  |  |  |         this.isString = true; | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  |         try { | 
			
		
	
		
			
				
					|  |  |  |           if (isDate(parseISO(this.value))) { | 
			
		
	
		
			
				
					|  |  |  |             this.formattedValue = new Date( | 
			
		
	
		
			
				
					|  |  |  |               <string>this.value | 
			
		
	
		
			
				
					|  |  |  |             ).toLocaleDateString(this.locale, { | 
			
		
	
		
			
				
					|  |  |  |         if (this.isDate) { | 
			
		
	
		
			
				
					|  |  |  |           this.formattedValue = new Date(<string>this.value).toLocaleDateString( | 
			
		
	
		
			
				
					|  |  |  |             this.locale, | 
			
		
	
		
			
				
					|  |  |  |             { | 
			
		
	
		
			
				
					|  |  |  |               day: '2-digit', | 
			
		
	
		
			
				
					|  |  |  |               month: '2-digit', | 
			
		
	
		
			
				
					|  |  |  |               year: 'numeric' | 
			
		
	
		
			
				
					|  |  |  |             }); | 
			
		
	
		
			
				
					|  |  |  |             } | 
			
		
	
		
			
				
					|  |  |  |         } catch { | 
			
		
	
		
			
				
					|  |  |  |           ); | 
			
		
	
		
			
				
					|  |  |  |         } else { | 
			
		
	
		
			
				
					|  |  |  |           this.formattedValue = this.value; | 
			
		
	
		
			
				
					|  |  |  |         } | 
			
		
	
		
			
				
					|  |  |  |       } | 
			
		
	
	
		
			
				
					|  |  | 
 |