Merge 597c07271d into b3d4297d83

apps/api/src/app/import/import-data.dto.ts

@@ -4,6 +4,7 @@ import { Type } from 'class-transformer';
 import { IsArray, IsOptional, ValidateNested } from 'class-validator';
 
 import { CreateTagDto } from '../endpoints/tags/create-tag.dto';
+import { CreatePlatformDto } from '../platform/create-platform.dto';
 import { CreateAccountWithBalancesDto } from './create-account-with-balances.dto';
 import { CreateAssetProfileWithMarketDataDto } from './create-asset-profile-with-market-data.dto';
 
@@ -25,6 +26,12 @@ export class ImportDataDto {
   @ValidateNested({ each: true })
   assetProfiles?: CreateAssetProfileWithMarketDataDto[];
 
+  @IsArray()
+  @IsOptional()
+  @Type(() => CreatePlatformDto)
+  @ValidateNested({ each: true })
+  platforms?: CreatePlatformDto[];
+
   @IsArray()
   @IsOptional()
   @Type(() => CreateTagDto)

apps/api/src/app/import/import.controller.ts

@@ -4,7 +4,7 @@ import { TransformDataSourceInRequestInterceptor } from '@ghostfolio/api/interce
 import { TransformDataSourceInResponseInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-response/transform-data-source-in-response.interceptor';
 import { ConfigurationService } from '@ghostfolio/api/services/configuration/configuration.service';
 import { ImportResponse } from '@ghostfolio/common/interfaces';
-import { hasPermission, permissions } from '@ghostfolio/common/permissions';
+import { permissions } from '@ghostfolio/common/permissions';
 import type { RequestWithUser } from '@ghostfolio/common/types';
 
 import {
@@ -47,15 +47,6 @@ export class ImportController {
   ): Promise<ImportResponse> {
     const isDryRun = isDryRunParam === 'true';
 
-    if (
-      !hasPermission(this.request.user.permissions, permissions.createAccount)
-    ) {
-      throw new HttpException(
-        getReasonPhrase(StatusCodes.FORBIDDEN),
-        StatusCodes.FORBIDDEN
-      );
-    }
-
     let maxActivitiesToImport = this.configurationService.get(
       'MAX_ACTIVITIES_TO_IMPORT'
     );
@@ -74,6 +65,7 @@ export class ImportController {
         accountsWithBalancesDto: importData.accounts ?? [],
         activitiesDto: importData.activities,
         assetProfilesWithMarketDataDto: importData.assetProfiles ?? [],
+        platformsDto: importData.platforms ?? [],
         tagsDto: importData.tags ?? [],
         user: this.request.user
       });

apps/api/src/app/import/import.service.ts

@@ -157,6 +157,7 @@ export class ImportService {
     assetProfilesWithMarketDataDto,
     isDryRun = false,
     maxActivitiesToImport,
+    platformsDto,
     tagsDto,
     user
   }: {
@@ -165,6 +166,7 @@ export class ImportService {
     assetProfilesWithMarketDataDto: ImportDataDto['assetProfiles'];
     isDryRun?: boolean;
     maxActivitiesToImport: number;
+    platformsDto: ImportDataDto['platforms'];
     tagsDto: ImportDataDto['tags'];
     user: UserWithSettings;
   }): Promise<Activity[]> {
@@ -299,6 +301,29 @@ export class ImportService {
       }
     }
 
+    if (platformsDto?.length) {
+      const canCreatePlatform = hasPermission(
+        user.permissions,
+        permissions.createPlatform
+      );
+
+      for (const platform of platformsDto) {
+        const existingPlatform = await this.platformService.getPlatform({
+          id: platform.id
+        });
+
+        if (!existingPlatform) {
+          continue;
+        }
+
+        if (!canCreatePlatform) {
+          throw new Error(
+            `Insufficient permissions to create platform ("${platform.name}")`
+          );
+        }
+      }
+    }
+
     if (tagsDto?.length) {
       const existingTagsOfUser = await this.tagService.getTagsForUser(user.id);
 

apps/api/src/app/platform/create-platform.dto.ts

@@ -1,6 +1,10 @@
-import { IsString, IsUrl } from 'class-validator';
+import { IsOptional, IsString, IsUrl } from 'class-validator';
 
 export class CreatePlatformDto {
+  @IsOptional()
+  @IsString()
+  id?: string;
+
   @IsString()
   name: string;