Browse Source

Improve comment validation

pull/8004/head
Thomas Kaul 2 weeks ago
parent
commit
669b4ec13d
  1. 25
      apps/api/src/app/endpoints/mcp/mcp.schemas.spec.ts

25
apps/api/src/app/endpoints/mcp/mcp.schemas.spec.ts

@ -1,4 +1,5 @@
import { import {
COMMENT_MAXIMUM_LENGTH,
DEFAULT_DATE_RANGE, DEFAULT_DATE_RANGE,
MCP_MAX_ACTIVITIES, MCP_MAX_ACTIVITIES,
SEARCH_QUERY_MAXIMUM_LENGTH, SEARCH_QUERY_MAXIMUM_LENGTH,
@ -91,6 +92,30 @@ describe('IMPORT_ACTIVITIES_PARAMETERS', () => {
return IMPORT_ACTIVITIES_PARAMETERS.safeParse({ activities }).success; return IMPORT_ACTIVITIES_PARAMETERS.safeParse({ activities }).success;
} }
it(`Accepts a comment of ${COMMENT_MAXIMUM_LENGTH} characters with spaces at the start and the end`, () => {
expect(
parse([
createActivity({ comment: ` ${'A'.repeat(COMMENT_MAXIMUM_LENGTH)} ` })
])
).toBe(true);
});
it(`Refuses a comment longer than ${COMMENT_MAXIMUM_LENGTH} characters`, () => {
expect(
parse([
createActivity({ comment: 'A'.repeat(COMMENT_MAXIMUM_LENGTH + 1) })
])
).toBe(false);
});
it('Removes spaces at the start and the end of a comment', () => {
expect(
IMPORT_ACTIVITIES_PARAMETERS.parse({
activities: [createActivity({ comment: ' note ' })]
}).activities[0].comment
).toBe('note');
});
it('Refuses a currency in lower case', () => { it('Refuses a currency in lower case', () => {
expect(parse([createActivity({ currency: 'usd' })])).toBe(false); expect(parse([createActivity({ currency: 'usd' })])).toBe(false);
}); });

Loading…
Cancel
Save