Browse Source

Task/hide currency in portfolio summary on mobile (#7952)

* Hide currency on mobile

* Update changelog
pull/7921/head^2
Thomas Kaul 1 day ago
committed by GitHub
parent
commit
67957f3c3e
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 1
      CHANGELOG.md
  2. 38
      apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html
  3. 4
      apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts

1
CHANGELOG.md

@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Simplified the portfolio summary by hiding the currency on mobile
- Improved the language localization for Catalan (`ca`) - Improved the language localization for Catalan (`ca`)
### Fixed ### Fixed

38
apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html

@ -48,7 +48,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.totalBuy" [value]="summary?.totalBuy"
/> />
</div> </div>
@ -62,7 +62,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.totalSell" [value]="summary?.totalSell"
/> />
</div> </div>
@ -79,7 +79,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.totalInvestmentValueWithCurrencyEffect" [value]="summary?.totalInvestmentValueWithCurrencyEffect"
/> />
</div> </div>
@ -93,7 +93,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.grossPerformanceWithCurrencyEffect" [value]="summary?.grossPerformanceWithCurrencyEffect"
/> />
</div> </div>
@ -110,7 +110,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.fees" [value]="summary?.fees"
/> />
</div> </div>
@ -127,7 +127,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.netPerformanceWithCurrencyEffect" [value]="summary?.netPerformanceWithCurrencyEffect"
/> />
</div> </div>
@ -171,7 +171,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.totalAssetsInBaseCurrency" [value]="summary?.totalAssetsInBaseCurrency"
/> />
</div> </div>
@ -217,7 +217,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="holdingsInBaseCurrency" [value]="holdingsInBaseCurrency"
/> />
</div> </div>
@ -233,7 +233,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="investmentsInBaseCurrency" [value]="investmentsInBaseCurrency"
/> />
</div> </div>
@ -248,7 +248,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.emergencyFund?.assets" [value]="summary?.emergencyFund?.assets"
/> />
</div> </div>
@ -295,7 +295,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.totalCashInBaseCurrency" [value]="summary?.totalCashInBaseCurrency"
/> />
</div> </div>
@ -311,7 +311,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.cash" [value]="summary?.cash"
/> />
</div> </div>
@ -326,7 +326,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.emergencyFund?.cash" [value]="summary?.emergencyFund?.cash"
/> />
</div> </div>
@ -356,7 +356,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.excludedAccountsAndActivities" [value]="summary?.excludedAccountsAndActivities"
/> />
</div> </div>
@ -379,7 +379,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.liabilitiesInBaseCurrency" [value]="summary?.liabilitiesInBaseCurrency"
/> />
</div> </div>
@ -396,7 +396,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.totalValueInBaseCurrency" [value]="summary?.totalValueInBaseCurrency"
/> />
</div> </div>
@ -469,7 +469,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.emergencyFund?.total" [value]="summary?.emergencyFund?.total"
/> />
</div> </div>
@ -483,7 +483,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.interestInBaseCurrency" [value]="summary?.interestInBaseCurrency"
/> />
</div> </div>
@ -497,7 +497,7 @@
[isLoading]="isLoading" [isLoading]="isLoading"
[locale]="locale" [locale]="locale"
[precision]="precision" [precision]="precision"
[unit]="baseCurrency" [unit]="displayedCurrency"
[value]="summary?.dividendInBaseCurrency" [value]="summary?.dividendInBaseCurrency"
/> />
</div> </div>

4
apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts

@ -79,6 +79,10 @@ export class GfPortfolioSummaryComponent implements OnChanges {
: 0; : 0;
} }
protected get displayedCurrency() {
return this.deviceType === 'mobile' ? undefined : this.baseCurrency;
}
protected get emergencyFundPercentage() { protected get emergencyFundPercentage() {
return this.summary?.totalValueInBaseCurrency return this.summary?.totalValueInBaseCurrency
? (this.summary.emergencyFund?.total || 0) / ? (this.summary.emergencyFund?.total || 0) /

Loading…
Cancel
Save