Merge branch 'main' into feature/upgrade-nx-to-version-21.5.1

CHANGELOG.md

@@ -14,14 +14,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Refactored the markets page to standalone
 - Refactored the fear and greed index component to standalone
 - Refactored the header component to standalone
+- Refactored the investment chart component to standalone
 - Refactored the rule component to standalone
 - Refactored the rules component to standalone
 - Refactored the subscription interstitial dialog component to standalone
+- Removed the `IonIcon` import from the landing page
 - Upgraded `angular` from version `20.1.3` to `20.2.4`
 - Upgraded `eslint` dependencies
 - Upgraded `Nx` from version `21.3.9` to `21.5.1`
 - Upgraded `storybook` from version `9.0.17` to `9.1.5`
 
+### Fixed
+
+- Fixed the holdings table on the public page
+
 ## 2.197.0 - 2025-09-07
 
 ### Added

apps/client/src/app/components/account-detail-dialog/account-detail-dialog.component.ts

@@ -2,7 +2,7 @@ import { CreateAccountBalanceDto } from '@ghostfolio/api/app/account-balance/cre
 import { Activity } from '@ghostfolio/api/app/order/interfaces/activities.interface';
 import { GfDialogFooterComponent } from '@ghostfolio/client/components/dialog-footer/dialog-footer.component';
 import { GfDialogHeaderComponent } from '@ghostfolio/client/components/dialog-header/dialog-header.component';
-import { GfInvestmentChartModule } from '@ghostfolio/client/components/investment-chart/investment-chart.module';
+import { GfInvestmentChartComponent } from '@ghostfolio/client/components/investment-chart/investment-chart.component';
 import { DataService } from '@ghostfolio/client/services/data.service';
 import { UserService } from '@ghostfolio/client/services/user/user.service';
 import { NUMERICAL_PRECISION_THRESHOLD_6_FIGURES } from '@ghostfolio/common/config';
@@ -64,7 +64,7 @@ import { AccountDetailDialogParams } from './interfaces/interfaces';
     GfDialogFooterComponent,
     GfDialogHeaderComponent,
     GfHoldingsTableComponent,
-    GfInvestmentChartModule,
+    GfInvestmentChartComponent,
     GfValueComponent,
     IonIcon,
     MatButtonModule,

apps/client/src/app/components/investment-chart/investment-chart.component.ts

@@ -16,6 +16,7 @@ import { LineChartItem } from '@ghostfolio/common/interfaces';
 import { InvestmentItem } from '@ghostfolio/common/interfaces/investment-item.interface';
 import { ColorScheme, GroupBy } from '@ghostfolio/common/types';
 
+import { CommonModule } from '@angular/common';
 import {
   ChangeDetectionStrategy,
   Component,
@@ -40,15 +41,16 @@ import {
 import 'chartjs-adapter-date-fns';
 import annotationPlugin from 'chartjs-plugin-annotation';
 import { isAfter } from 'date-fns';
+import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 
 @Component({
-  selector: 'gf-investment-chart',
   changeDetection: ChangeDetectionStrategy.OnPush,
-  templateUrl: './investment-chart.component.html',
+  imports: [CommonModule, NgxSkeletonLoaderModule],
+  selector: 'gf-investment-chart',
   styleUrls: ['./investment-chart.component.scss'],
-  standalone: false
+  templateUrl: './investment-chart.component.html'
 })
-export class InvestmentChartComponent implements OnChanges, OnDestroy {
+export class GfInvestmentChartComponent implements OnChanges, OnDestroy {
   @Input() benchmarkDataItems: InvestmentItem[] = [];
   @Input() benchmarkDataLabel = '';
   @Input() colorScheme: ColorScheme;

apps/client/src/app/components/investment-chart/investment-chart.module.ts

@@ -1,12 +0,0 @@
-import { CommonModule } from '@angular/common';
-import { NgModule } from '@angular/core';
-import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
-
-import { InvestmentChartComponent } from './investment-chart.component';
-
-@NgModule({
-  declarations: [InvestmentChartComponent],
-  exports: [InvestmentChartComponent],
-  imports: [CommonModule, NgxSkeletonLoaderModule]
-})
-export class GfInvestmentChartModule {}

apps/client/src/app/pages/landing/landing-page.component.ts

@@ -12,7 +12,6 @@ import { Component, OnDestroy, OnInit } from '@angular/core';
 import { MatButtonModule } from '@angular/material/button';
 import { MatCardModule } from '@angular/material/card';
 import { RouterModule } from '@angular/router';
-import { IonIcon } from '@ionic/angular/standalone';
 import { format } from 'date-fns';
 import { addIcons } from 'ionicons';
 import {
@@ -31,7 +30,6 @@ import { Subject } from 'rxjs';
     GfLogoComponent,
     GfValueComponent,
     GfWorldMapChartComponent,
-    IonIcon,
     MatButtonModule,
     MatCardModule,
     RouterModule

apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts

@@ -1,5 +1,5 @@
 import { GfBenchmarkComparatorComponent } from '@ghostfolio/client/components/benchmark-comparator/benchmark-comparator.component';
-import { GfInvestmentChartModule } from '@ghostfolio/client/components/investment-chart/investment-chart.module';
+import { GfInvestmentChartComponent } from '@ghostfolio/client/components/investment-chart/investment-chart.component';
 import { DataService } from '@ghostfolio/client/services/data.service';
 import { ImpersonationStorageService } from '@ghostfolio/client/services/impersonation-storage.service';
 import { UserService } from '@ghostfolio/client/services/user/user.service';
@@ -47,7 +47,7 @@ import { takeUntil } from 'rxjs/operators';
 @Component({
   imports: [
     GfBenchmarkComparatorComponent,
-    GfInvestmentChartModule,
+    GfInvestmentChartComponent,
     GfPremiumIndicatorComponent,
     GfToggleComponent,
     GfValueComponent,

apps/client/src/app/pages/public/public-page.html

@@ -198,11 +198,11 @@
   <div class="row">
     <div class="col-lg">
       <gf-holdings-table
-        [data]="holdings"
         [deviceType]="deviceType"
         [hasPermissionToOpenDetails]="false"
         [hasPermissionToShowQuantities]="false"
         [hasPermissionToShowValues]="false"
+        [holdings]="holdings"
         [pageSize]="7"
       />
     </div>