Browse Source

Task/widen input types in portfolio summary component (#8010)

feat(client): widen input types in portfolio summary component
pull/8013/head
Kenrick Tandrian 6 days ago
committed by GitHub
parent
commit
6cba7744b5
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 26
      apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts

26
apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts

@ -39,15 +39,15 @@ import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
templateUrl: './portfolio-summary.component.html' templateUrl: './portfolio-summary.component.html'
}) })
export class GfPortfolioSummaryComponent implements OnChanges { export class GfPortfolioSummaryComponent implements OnChanges {
@Input() baseCurrency: string; @Input() public baseCurrency?: string;
@Input() deviceType: string; @Input() public deviceType: string;
@Input() hasImpersonationId: boolean; @Input() public hasImpersonationId: boolean;
@Input() hasPermissionToUpdateUserSettings: boolean; @Input() public hasPermissionToUpdateUserSettings: boolean;
@Input() isLoading: boolean; @Input() public isLoading: boolean;
@Input() language: string; @Input() public language?: string;
@Input() locale = getLocale(); @Input() public locale?: string = getLocale();
@Input() summary: PortfolioSummary; @Input() public summary?: PortfolioSummary;
@Input() user: User; @Input() public user?: User;
public emergencyFundChanged = output<number>(); public emergencyFundChanged = output<number>();
@ -99,11 +99,11 @@ export class GfPortfolioSummaryComponent implements OnChanges {
} }
protected get hasCashBreakdown() { protected get hasCashBreakdown() {
return !this.isLoading && this.summary?.emergencyFund?.cash > 0; return !this.isLoading && (this.summary?.emergencyFund?.cash ?? 0) > 0;
} }
protected get hasHoldingsBreakdown() { protected get hasHoldingsBreakdown() {
return !this.isLoading && this.summary?.emergencyFund?.assets > 0; return !this.isLoading && (this.summary?.emergencyFund?.assets ?? 0) > 0;
} }
protected get holdingsInBaseCurrency() { protected get holdingsInBaseCurrency() {
@ -133,7 +133,7 @@ export class GfPortfolioSummaryComponent implements OnChanges {
} }
return ( return (
this.holdingsInBaseCurrency - (this.summary.emergencyFund?.assets ?? 0) this.holdingsInBaseCurrency - (this.summary?.emergencyFund?.assets ?? 0)
); );
} }
@ -200,7 +200,7 @@ export class GfPortfolioSummaryComponent implements OnChanges {
this.emergencyFundChanged.emit(emergencyFund); this.emergencyFundChanged.emit(emergencyFund);
}, },
confirmLabel: $localize`Save`, confirmLabel: $localize`Save`,
defaultValue: this.summary.emergencyFund?.total?.toString() ?? '0', defaultValue: this.summary?.emergencyFund?.total?.toString() ?? '0',
title: $localize`Please set the amount of your emergency fund.`, title: $localize`Please set the amount of your emergency fund.`,
valueSuffix: this.baseCurrency valueSuffix: this.baseCurrency
}); });

Loading…
Cancel
Save