Refactoring

libs/common/src/lib/routes/routes.ts

@@ -59,17 +59,13 @@ export const internalRoutes: Record<string, IRoute> = {
     title: $localize`Accounts`
   },
   api: {
-    excludeFromAssistant: () => {
-      return true;
-    },
+    excludeFromAssistant: true,
     path: 'api',
     routerLink: ['/api'],
     title: 'Ghostfolio API'
   },
   auth: {
-    excludeFromAssistant: () => {
-      return true;
-    },
+    excludeFromAssistant: true,
     path: 'auth',
     routerLink: ['/auth'],
     title: $localize`Sign in`
@@ -102,9 +98,7 @@ export const internalRoutes: Record<string, IRoute> = {
     title: $localize`Overview`
   },
   i18n: {
-    excludeFromAssistant: () => {
-      return true;
-    },
+    excludeFromAssistant: true,
     path: 'i18n',
     routerLink: ['/i18n'],
     title: $localize`Internationalization`
@@ -142,17 +136,13 @@ export const internalRoutes: Record<string, IRoute> = {
     title: $localize`Portfolio`
   },
   webauthn: {
-    excludeFromAssistant: () => {
-      return true;
-    },
+    excludeFromAssistant: true,
     path: 'webauthn',
     routerLink: ['/webauthn'],
     title: $localize`Sign in`
   },
   zen: {
-    excludeFromAssistant: () => {
-      return true;
-    },
+    excludeFromAssistant: true,
     path: 'zen',
     routerLink: ['/zen'],
     subRoutes: {

libs/ui/src/lib/assistant/assistant.component.ts

@@ -41,6 +41,7 @@ import { MatSelectModule } from '@angular/material/select';
 import { RouterModule } from '@angular/router';
 import { Account, AssetClass, DataSource } from '@prisma/client';
 import { differenceInYears } from 'date-fns';
+import { isFunction } from 'lodash';
 import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 import { EMPTY, Observable, Subject, merge, of } from 'rxjs';
 import {
@@ -627,8 +628,8 @@ export class GfAssistantComponent implements OnChanges, OnDestroy, OnInit {
 
     const allRoutes = Object.values(internalRoutes)
       .filter(({ excludeFromAssistant }) => {
-        if (typeof excludeFromAssistant === 'function') {
-          return !excludeFromAssistant(this.user);
+        if (isFunction(excludeFromAssistant)) {
+          return excludeFromAssistant(this.user);
         }
 
         return !excludeFromAssistant;