Browse Source

fix: address all review comments - add blank lines, move constants, update changelog

pull/5656/head
adityagarud 3 months ago
parent
commit
791000a46e
  1. 6
      CHANGELOG.md
  2. 5
      libs/ui/src/lib/assistant/assistant.component.ts

6
CHANGELOG.md

@ -5,14 +5,14 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## 2.206.0 - 2025-01-27 ## Unreleased
### Added ### Added
- Auto-preselect first search result in assistant for improved keyboard navigation
### Changed ### Changed
- Auto-preselect first search result in assistant for improved keyboard navigation
- Localized the number formatting in the settings dialog to customize the rule thresholds of the _X-ray_ page - Localized the number formatting in the settings dialog to customize the rule thresholds of the _X-ray_ page
- Improved the usability of the _Cancel_ / _Close_ buttons in the create watchlist item dialog - Improved the usability of the _Cancel_ / _Close_ buttons in the create watchlist item dialog
- Refactored the `fireWealth` from `number` type to a structured object in the summary of the portfolio details endpoint - Refactored the `fireWealth` from `number` type to a structured object in the summary of the portfolio details endpoint

5
libs/ui/src/lib/assistant/assistant.component.ts

@ -169,12 +169,12 @@ export class GfAssistantComponent implements OnChanges, OnDestroy, OnInit {
}; };
public tags: Filter[] = []; public tags: Filter[] = [];
private readonly PRESELECTION_DELAY = 100;
private keyManager: FocusKeyManager<GfAssistantListItemComponent>; private keyManager: FocusKeyManager<GfAssistantListItemComponent>;
private preselectionTimeout: ReturnType<typeof setTimeout>; private preselectionTimeout: ReturnType<typeof setTimeout>;
private unsubscribeSubject = new Subject<void>(); private unsubscribeSubject = new Subject<void>();
private readonly PRESELECTION_DELAY = 100;
private filterTypes: Filter['type'][] = [ private filterTypes: Filter['type'][] = [
'ACCOUNT', 'ACCOUNT',
'ASSET_CLASS', 'ASSET_CLASS',
@ -349,6 +349,7 @@ export class GfAssistantComponent implements OnChanges, OnDestroy, OnInit {
next: (searchResults) => { next: (searchResults) => {
this.searchResults = searchResults; this.searchResults = searchResults;
this.preselectFirstItem(); this.preselectFirstItem();
this.changeDetectorRef.markForCheck(); this.changeDetectorRef.markForCheck();
}, },
error: (error) => { error: (error) => {

Loading…
Cancel
Save