Browse Source

Task/widen input types in dialog header tables and benchmark comparator

Widen input types in dialog header, tables, and benchmark comparator

Part of #7393
pull/8068/head
KenTandrian 1 week ago
parent
commit
7c11da4be2
  1. 4
      apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.ts
  2. 4
      libs/ui/src/lib/accounts-table/accounts-table.component.ts
  3. 2
      libs/ui/src/lib/dialog-header/dialog-header.component.ts
  4. 4
      libs/ui/src/lib/holdings-table/holdings-table.component.ts

4
apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.ts

@ -72,7 +72,9 @@ export class GfBenchmarkComparatorComponent implements OnChanges, OnDestroy {
public readonly benchmarks = input<Partial<SymbolProfile>[]>(); public readonly benchmarks = input<Partial<SymbolProfile>[]>();
public readonly colorScheme = input<ColorScheme>(); public readonly colorScheme = input<ColorScheme>();
public readonly isLoading = input<boolean>(); public readonly isLoading = input<boolean>();
public readonly locale = input(getLocale()); public readonly locale = input(getLocale(), {
transform: (value?: string) => value ?? getLocale()
});
public readonly performanceDataItems = input.required<LineChartItem[]>(); public readonly performanceDataItems = input.required<LineChartItem[]>();
public readonly user = input<User>(); public readonly user = input<User>();

4
libs/ui/src/lib/accounts-table/accounts-table.component.ts

@ -62,7 +62,9 @@ export class GfAccountsTableComponent {
public readonly hasPermissionToDeleteAccount = input<boolean>(); public readonly hasPermissionToDeleteAccount = input<boolean>();
public readonly hasPermissionToOpenDetails = input(true); public readonly hasPermissionToOpenDetails = input(true);
public readonly hasPermissionToUpdateAccount = input<boolean>(); public readonly hasPermissionToUpdateAccount = input<boolean>();
public readonly locale = input(getLocale()); public readonly locale = input(getLocale(), {
transform: (value?: string) => value ?? getLocale()
});
public readonly showActions = input<boolean>(); public readonly showActions = input<boolean>();
public readonly showActivitiesCount = input(true); public readonly showActivitiesCount = input(true);
public readonly showAllocationInPercentage = input<boolean>(); public readonly showAllocationInPercentage = input<boolean>();

2
libs/ui/src/lib/dialog-header/dialog-header.component.ts

@ -22,7 +22,7 @@ import { close } from 'ionicons/icons';
export class GfDialogHeaderComponent { export class GfDialogHeaderComponent {
@Input() deviceType: string; @Input() deviceType: string;
@Input() position: 'center' | 'left' = 'left'; @Input() position: 'center' | 'left' = 'left';
@Input() title: string; @Input() title?: string | null;
@Output() closeButtonClicked = new EventEmitter<void>(); @Output() closeButtonClicked = new EventEmitter<void>();

4
libs/ui/src/lib/holdings-table/holdings-table.component.ts

@ -54,7 +54,9 @@ export class GfHoldingsTableComponent {
public readonly hasPermissionToShowQuantities = input(true); public readonly hasPermissionToShowQuantities = input(true);
public readonly hasPermissionToShowValues = input(true); public readonly hasPermissionToShowValues = input(true);
public readonly holdings = input.required<PortfolioPosition[] | undefined>(); public readonly holdings = input.required<PortfolioPosition[] | undefined>();
public readonly locale = input(getLocale()); public readonly locale = input(getLocale(), {
transform: (value?: string) => value ?? getLocale()
});
public readonly mode = input<'default' | 'simple'>('default'); public readonly mode = input<'default' | 'simple'>('default');
public readonly pageSize = model(Number.MAX_SAFE_INTEGER); public readonly pageSize = model(Number.MAX_SAFE_INTEGER);

Loading…
Cancel
Save