Browse Source

Bugfix/add missing guards in getSettings() of static portfolio analysis rules (#5368)

* Add missing guards
pull/5369/head
Thomas Kaul 5 days ago
committed by GitHub
parent
commit
7d1300bea1
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 2
      apps/api/src/models/rules/account-cluster-risk/current-investment.ts
  2. 2
      apps/api/src/models/rules/account-cluster-risk/single-account.ts
  3. 2
      apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts
  4. 2
      apps/api/src/models/rules/currency-cluster-risk/current-investment.ts
  5. 2
      apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts
  6. 2
      apps/api/src/models/rules/fees/fee-ratio-initial-investment.ts
  7. 2
      apps/api/src/models/rules/liquidity/buying-power.ts

2
apps/api/src/models/rules/account-cluster-risk/current-investment.ts

@ -124,7 +124,7 @@ export class AccountClusterRiskCurrentInvestment extends Rule<Settings> {
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings {
return { return {
baseCurrency, baseCurrency,
isActive: xRayRules?.[this.getKey()].isActive ?? true, isActive: xRayRules?.[this.getKey()]?.isActive ?? true,
thresholdMax: xRayRules?.[this.getKey()]?.thresholdMax ?? 0.5 thresholdMax: xRayRules?.[this.getKey()]?.thresholdMax ?? 0.5
}; };
} }

2
apps/api/src/models/rules/account-cluster-risk/single-account.ts

@ -74,7 +74,7 @@ export class AccountClusterRiskSingleAccount extends Rule<RuleSettings> {
public getSettings({ xRayRules }: UserSettings): RuleSettings { public getSettings({ xRayRules }: UserSettings): RuleSettings {
return { return {
isActive: xRayRules?.[this.getKey()].isActive ?? true isActive: xRayRules?.[this.getKey()]?.isActive ?? true
}; };
} }
} }

2
apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts

@ -100,7 +100,7 @@ export class CurrencyClusterRiskBaseCurrencyCurrentInvestment extends Rule<Setti
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings {
return { return {
baseCurrency, baseCurrency,
isActive: xRayRules?.[this.getKey()].isActive ?? true isActive: xRayRules?.[this.getKey()]?.isActive ?? true
}; };
} }
} }

2
apps/api/src/models/rules/currency-cluster-risk/current-investment.ts

@ -101,7 +101,7 @@ export class CurrencyClusterRiskCurrentInvestment extends Rule<Settings> {
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings {
return { return {
baseCurrency, baseCurrency,
isActive: xRayRules?.[this.getKey()].isActive ?? true, isActive: xRayRules?.[this.getKey()]?.isActive ?? true,
thresholdMax: xRayRules?.[this.getKey()]?.thresholdMax ?? 0.5 thresholdMax: xRayRules?.[this.getKey()]?.thresholdMax ?? 0.5
}; };
} }

2
apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts

@ -62,7 +62,7 @@ export class EmergencyFundSetup extends Rule<Settings> {
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings {
return { return {
baseCurrency, baseCurrency,
isActive: xRayRules?.[this.getKey()].isActive ?? true isActive: xRayRules?.[this.getKey()]?.isActive ?? true
}; };
} }
} }

2
apps/api/src/models/rules/fees/fee-ratio-initial-investment.ts

@ -85,7 +85,7 @@ export class FeeRatioInitialInvestment extends Rule<Settings> {
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings {
return { return {
baseCurrency, baseCurrency,
isActive: xRayRules?.[this.getKey()].isActive ?? true, isActive: xRayRules?.[this.getKey()]?.isActive ?? true,
thresholdMax: xRayRules?.[this.getKey()]?.thresholdMax ?? 0.01 thresholdMax: xRayRules?.[this.getKey()]?.thresholdMax ?? 0.01
}; };
} }

2
apps/api/src/models/rules/liquidity/buying-power.ts

@ -78,7 +78,7 @@ export class BuyingPower extends Rule<Settings> {
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings {
return { return {
baseCurrency, baseCurrency,
isActive: xRayRules?.[this.getKey()].isActive ?? true, isActive: xRayRules?.[this.getKey()]?.isActive ?? true,
thresholdMin: xRayRules?.[this.getKey()]?.thresholdMin ?? 0 thresholdMin: xRayRules?.[this.getKey()]?.thresholdMin ?? 0
}; };
} }

Loading…
Cancel
Save