Browse Source

Migrate GfXRayPageComponent to ChangeDetectionStrategy.OnPush with minimal changes: import ChangeDetectionStrategy and set changeDetection on the component decorator + Fix apps/client/tsconfig.editor.json: add typeRoots (match tsconfig.app.json) and remove explicit types that forced missing @types/jest / @types/node

pull/7238/head
Neel 2 months ago
parent
commit
7ee64cf1ac
  1. 8
      apps/client/src/app/pages/portfolio/x-ray/x-ray-page.component.ts
  2. 2
      apps/client/tsconfig.editor.json

8
apps/client/src/app/pages/portfolio/x-ray/x-ray-page.component.ts

@ -12,7 +12,12 @@ import { hasPermission, permissions } from '@ghostfolio/common/permissions';
import { GfPremiumIndicatorComponent } from '@ghostfolio/ui/premium-indicator';
import { DataService } from '@ghostfolio/ui/services';
import { ChangeDetectorRef, Component, DestroyRef } from '@angular/core';
import {
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
DestroyRef
} from '@angular/core';
import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
import { IonIcon } from '@ionic/angular/standalone';
import { addIcons } from 'ionicons';
@ -24,6 +29,7 @@ import {
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
@Component({
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [
GfPremiumIndicatorComponent,
GfRulesComponent,

2
apps/client/tsconfig.editor.json

@ -2,7 +2,7 @@
"extends": "./tsconfig.json",
"include": ["**/*.ts"],
"compilerOptions": {
"types": ["jest", "node"]
"typeRoots": ["../../node_modules/@types"]
},
"exclude": ["jest.config.ts"]
}

Loading…
Cancel
Save