Browse Source

Fix exception with missing marketPrice

pull/1586/head
Thomas 3 years ago
parent
commit
83e9a6a6c7
  1. 2
      apps/api/src/app/portfolio/portfolio-calculator.ts
  2. 2
      apps/api/src/app/portfolio/portfolio.service.ts

2
apps/api/src/app/portfolio/portfolio-calculator.ts

@ -422,6 +422,7 @@ export class PortfolioCalculator {
symbol: item.symbol symbol: item.symbol
}); });
if (item.quantity.gt(0)) {
hasAnySymbolMetricsErrors = hasAnySymbolMetricsErrors || hasErrors; hasAnySymbolMetricsErrors = hasAnySymbolMetricsErrors || hasErrors;
initialValues[item.symbol] = initialValue; initialValues[item.symbol] = initialValue;
@ -451,6 +452,7 @@ export class PortfolioCalculator {
errors.push({ dataSource: item.dataSource, symbol: item.symbol }); errors.push({ dataSource: item.dataSource, symbol: item.symbol });
} }
} }
}
const overall = this.calculateOverallPerformance(positions, initialValues); const overall = this.calculateOverallPerformance(positions, initialValues);

2
apps/api/src/app/portfolio/portfolio.service.ts

@ -1682,7 +1682,7 @@ export class PortfolioService {
for (const order of ordersByAccount) { for (const order of ordersByAccount) {
let currentValueOfSymbolInBaseCurrency = let currentValueOfSymbolInBaseCurrency =
order.quantity * order.quantity *
portfolioItemsNow[order.SymbolProfile.symbol].marketPrice; portfolioItemsNow[order.SymbolProfile.symbol]?.marketPrice ?? 0;
let originalValueOfSymbolInBaseCurrency = let originalValueOfSymbolInBaseCurrency =
this.exchangeRateDataService.toCurrency( this.exchangeRateDataService.toCurrency(
order.quantity * order.unitPrice, order.quantity * order.unitPrice,

Loading…
Cancel
Save