Browse Source
Task/handle delisted asset profiles in FMP service (#7442)
* Handle delisted asset profiles
* Update changelog
pull/7446/head
Thomas Kaul
3 days ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with
15 additions and
1 deletions
-
CHANGELOG.md
-
apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts
|
|
|
@ -14,12 +14,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
### Changed |
|
|
|
|
|
|
|
- Deprecated `firstOrderDate` in favor of `dateOfFirstActivity` in the `GET api/v2/portfolio/performance` endpoint |
|
|
|
- Improved the log output in the get asset profile functionality of the _Financial Modeling Prep_ service for delisted asset profiles |
|
|
|
- Refreshed the cryptocurrencies list |
|
|
|
- Upgraded `prettier` from version `3.8.4` to `3.9.6` |
|
|
|
|
|
|
|
### Fixed |
|
|
|
|
|
|
|
- Resolved an exception in the user service when getting a non-existent user |
|
|
|
- Fixed the missing currency in the get quotes functionality of the _Financial Modeling Prep_ service for cryptocurrencies without an asset profile |
|
|
|
|
|
|
|
## 3.34.0 - 2026-07-25 |
|
|
|
|
|
|
|
|
|
|
|
@ -111,6 +111,12 @@ export class FinancialModelingPrepService |
|
|
|
) |
|
|
|
.then((res) => res.json()); |
|
|
|
|
|
|
|
if (!quote) { |
|
|
|
throw new AssetProfileDelistedError( |
|
|
|
`No data found, ${symbol} (${this.getName()}) may be delisted` |
|
|
|
); |
|
|
|
} |
|
|
|
|
|
|
|
response.assetClass = AssetClass.LIQUIDITY; |
|
|
|
response.assetSubClass = AssetSubClass.CRYPTOCURRENCY; |
|
|
|
response.currency = symbol.substring( |
|
|
|
@ -259,8 +265,12 @@ export class FinancialModelingPrepService |
|
|
|
).toFixed(3)} seconds`;
|
|
|
|
} |
|
|
|
|
|
|
|
if (error instanceof AssetProfileDelistedError) { |
|
|
|
this.logger.warn(error.message); |
|
|
|
} else { |
|
|
|
this.logger.error(message); |
|
|
|
} |
|
|
|
} |
|
|
|
|
|
|
|
return response; |
|
|
|
} |
|
|
|
@ -478,6 +488,8 @@ export class FinancialModelingPrepService |
|
|
|
currencyBySymbolMap[symbol] = { |
|
|
|
currency: assetProfile.currency |
|
|
|
}; |
|
|
|
} else if (this.cryptocurrencyService.isCryptocurrency(symbol)) { |
|
|
|
currencyBySymbolMap[symbol] = { currency: DEFAULT_CURRENCY }; |
|
|
|
} |
|
|
|
}) |
|
|
|
); |
|
|
|
|