Merge remote-tracking branch 'origin/main' into task/migrate-tags-selector-component

CHANGELOG.md

@@ -5,15 +5,19 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## Unreleased
+## 2.212.0 - 2025-10-29
 
 ### Added
 
 - Added a close holding button to the holding detail dialog
+- Added the _Sponsors_ section to the about page
 - Extended the user detail dialog in the users section of the admin control panel
 
 ### Changed
 
+- Refactored the generation of the holdings table in the _Copy AI prompt to clipboard for analysis_ action on the analysis page (experimental)
+- Refactored the generation of the holdings table in the _Copy portfolio data to clipboard for AI prompt_ action on the analysis page (experimental)
+- Improved the usability of the user detail dialog in the users section of the admin control panel
 - Improved the language localization for German (`de`)
 
 ### Fixed

README.md

@@ -297,7 +297,18 @@ Ghostfolio is **100% free** and **open source**. We encourage and support an act
 
 Not sure what to work on? We have [some ideas](https://github.com/ghostfolio/ghostfolio/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22%20no%3Aassignee), even for [newcomers](https://github.com/ghostfolio/ghostfolio/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22%20no%3Aassignee). Please join the Ghostfolio [Slack](https://join.slack.com/t/ghostfolio/shared_invite/zt-vsaan64h-F_I0fEo5M0P88lP9ibCxFg) channel or post to [@ghostfolio\_](https://x.com/ghostfolio_) on _X_. We would love to hear from you.
 
-If you like to support this project, get [**Ghostfolio Premium**](https://ghostfol.io/en/pricing) or [**Buy me a coffee**](https://www.buymeacoffee.com/ghostfolio).
+If you like to support this project, become a [**Sponsor**](https://github.com/sponsors/ghostfolio), get [**Ghostfolio Premium**](https://ghostfol.io/en/pricing) or [**Buy me a coffee**](https://www.buymeacoffee.com/ghostfolio).
+
+## Sponsors
+
+<div align="center">
+  <p>
+    Browser testing via<br />
+    <a href="https://www.lambdatest.com?utm_medium=sponsor&utm_source=ghostfolio" target="_blank" title="LambdaTest - AI Powered Testing Tool">
+      <img alt="LambdaTest Logo" height="45" width="250" src="https://www.lambdatest.com/blue-logo.png" />
+    </a>
+  </p>
+</div>
 
 ## Analytics
 

apps/api/src/app/endpoints/ai/ai.service.ts

@@ -14,6 +14,27 @@ import type { ColumnDescriptor } from 'tablemark';
 
 @Injectable()
 export class AiService {
+  private static readonly HOLDINGS_TABLE_COLUMN_DEFINITIONS: ({
+    key:
+      | 'ALLOCATION_PERCENTAGE'
+      | 'ASSET_CLASS'
+      | 'ASSET_SUB_CLASS'
+      | 'CURRENCY'
+      | 'NAME'
+      | 'SYMBOL';
+  } & ColumnDescriptor)[] = [
+    { key: 'NAME', name: 'Name' },
+    { key: 'SYMBOL', name: 'Symbol' },
+    { key: 'CURRENCY', name: 'Currency' },
+    { key: 'ASSET_CLASS', name: 'Asset Class' },
+    { key: 'ASSET_SUB_CLASS', name: 'Asset Sub Class' },
+    {
+      align: 'right',
+      key: 'ALLOCATION_PERCENTAGE',
+      name: 'Allocation in Percentage'
+    }
+  ];
+
   public constructor(
     private readonly portfolioService: PortfolioService,
     private readonly propertyService: PropertyService
@@ -59,14 +80,10 @@ export class AiService {
       userId
     });
 
-    const holdingsTableColumns: ColumnDescriptor[] = [
+    const holdingsTableColumns: ColumnDescriptor[] =
-      { name: 'Name' },
+      AiService.HOLDINGS_TABLE_COLUMN_DEFINITIONS.map(({ align, name }) => {
-      { name: 'Symbol' },
+        return { name, align: align ?? 'left' };
-      { name: 'Currency' },
+      });
-      { name: 'Asset Class' },
-      { name: 'Asset Sub Class' },
-      { align: 'right', name: 'Allocation in Percentage' }
-    ];
 
     const holdingsTableRows = Object.values(holdings)
       .sort((a, b) => {
@@ -78,17 +95,45 @@ export class AiService {
           assetClass,
           assetSubClass,
           currency,
-          name,
+          name: label,
           symbol
         }) => {
-          return {
+          return AiService.HOLDINGS_TABLE_COLUMN_DEFINITIONS.reduce(
-            Name: name,
+            (row, { key, name }) => {
-            Symbol: symbol,
+              switch (key) {
-            Currency: currency,
+                case 'ALLOCATION_PERCENTAGE':
-            'Asset Class': assetClass ?? '',
+                  row[name] = `${(allocationInPercentage * 100).toFixed(3)}%`;
-            'Asset Sub Class': assetSubClass ?? '',
+                  break;
-            'Allocation in Percentage': `${(allocationInPercentage * 100).toFixed(3)}%`
+
-          };
+                case 'ASSET_CLASS':
+                  row[name] = assetClass ?? '';
+                  break;
+
+                case 'ASSET_SUB_CLASS':
+                  row[name] = assetSubClass ?? '';
+                  break;
+
+                case 'CURRENCY':
+                  row[name] = currency;
+                  break;
+
+                case 'NAME':
+                  row[name] = label;
+                  break;
+
+                case 'SYMBOL':
+                  row[name] = symbol;
+                  break;
+
+                default:
+                  row[name] = '';
+                  break;
+              }
+
+              return row;
+            },
+            {} as Record<string, string>
+          );
         }
       );
 

apps/client/src/app/app.component.ts

@@ -276,7 +276,10 @@ export class AppComponent implements OnDestroy, OnInit {
       .subscribe((user) => {
         this.user = user;
 
-        const dialogRef = this.dialog.open(GfHoldingDetailDialogComponent, {
+        const dialogRef = this.dialog.open<
+          GfHoldingDetailDialogComponent,
+          HoldingDetailDialogParams
+        >(GfHoldingDetailDialogComponent, {
           autoFocus: false,
           data: {
             dataSource,
@@ -302,7 +305,7 @@ export class AppComponent implements OnDestroy, OnInit {
               hasPermission(this.user?.permissions, permissions.updateOrder) &&
               !this.user?.settings?.isRestrictedView,
             locale: this.user?.settings?.locale
-          } as HoldingDetailDialogParams,
+          },
           height: this.deviceType === 'mobile' ? '98vh' : '80vh',
           width: this.deviceType === 'mobile' ? '100vw' : '50rem'
         });

apps/client/src/app/components/admin-market-data/admin-market-data.component.ts

@@ -430,7 +430,10 @@ export class GfAdminMarketDataComponent
       .subscribe((user) => {
         this.user = user;
 
-        const dialogRef = this.dialog.open(GfAssetProfileDialogComponent, {
+        const dialogRef = this.dialog.open<
+          GfAssetProfileDialogComponent,
+          AssetProfileDialogParams
+        >(GfAssetProfileDialogComponent, {
           autoFocus: false,
           data: {
             dataSource,
@@ -438,7 +441,7 @@ export class GfAdminMarketDataComponent
             colorScheme: this.user?.settings.colorScheme,
             deviceType: this.deviceType,
             locale: this.user?.settings?.locale
-          } as AssetProfileDialogParams,
+          },
           height: this.deviceType === 'mobile' ? '98vh' : '80vh',
           width: this.deviceType === 'mobile' ? '100vw' : '50rem'
         });
@@ -465,17 +468,17 @@ export class GfAdminMarketDataComponent
       .subscribe((user) => {
         this.user = user;
 
-        const dialogRef = this.dialog.open(
+        const dialogRef = this.dialog.open<
           GfCreateAssetProfileDialogComponent,
-          {
+          CreateAssetProfileDialogParams
-            autoFocus: false,
+        >(GfCreateAssetProfileDialogComponent, {
-            data: {
+          autoFocus: false,
-              deviceType: this.deviceType,
+          data: {
-              locale: this.user?.settings?.locale
+            deviceType: this.deviceType,
-            } as CreateAssetProfileDialogParams,
+            locale: this.user?.settings?.locale
-            width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+          },
-          }
+          width: this.deviceType === 'mobile' ? '100vw' : '50rem'
-        );
+        });
 
         dialogRef
           .afterClosed()

apps/client/src/app/components/admin-platform/admin-platform.component.ts

@@ -34,6 +34,7 @@ import { DeviceDetectorService } from 'ngx-device-detector';
 import { Subject, takeUntil } from 'rxjs';
 
 import { GfCreateOrUpdatePlatformDialogComponent } from './create-or-update-platform-dialog/create-or-update-platform-dialog.component';
+import { CreateOrUpdatePlatformDialogParams } from './create-or-update-platform-dialog/interfaces/interfaces';
 
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
@@ -153,19 +154,20 @@ export class GfAdminPlatformComponent implements OnInit, OnDestroy {
   }
 
   private openCreatePlatformDialog() {
-    const dialogRef = this.dialog.open(
+    const dialogRef = this.dialog.open<
       GfCreateOrUpdatePlatformDialogComponent,
-      {
+      CreateOrUpdatePlatformDialogParams
-        data: {
+    >(GfCreateOrUpdatePlatformDialogComponent, {
-          platform: {
+      data: {
-            name: null,
+        platform: {
-            url: null
+          id: null,
-          }
+          name: null,
-        },
+          url: null
-        height: this.deviceType === 'mobile' ? '98vh' : undefined,
+        }
-        width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+      },
-      }
+      height: this.deviceType === 'mobile' ? '98vh' : undefined,
-    );
+      width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+    });
 
     dialogRef
       .afterClosed()
@@ -191,21 +193,29 @@ export class GfAdminPlatformComponent implements OnInit, OnDestroy {
       });
   }
 
-  private openUpdatePlatformDialog({ id, name, url }) {
+  private openUpdatePlatformDialog({
-    const dialogRef = this.dialog.open(
+    id,
+    name,
+    url
+  }: {
+    id: string;
+    name: string;
+    url: string;
+  }) {
+    const dialogRef = this.dialog.open<
       GfCreateOrUpdatePlatformDialogComponent,
-      {
+      CreateOrUpdatePlatformDialogParams
-        data: {
+    >(GfCreateOrUpdatePlatformDialogComponent, {
-          platform: {
+      data: {
-            id,
+        platform: {
-            name,
+          id,
-            url
+          name,
-          }
+          url
-        },
+        }
-        height: this.deviceType === 'mobile' ? '98vh' : undefined,
+      },
-        width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+      height: this.deviceType === 'mobile' ? '98vh' : undefined,
-      }
+      width: this.deviceType === 'mobile' ? '100vw' : '50rem'
-    );
+    });
 
     dialogRef
       .afterClosed()

apps/client/src/app/components/admin-tag/admin-tag.component.ts

@@ -32,6 +32,7 @@ import { DeviceDetectorService } from 'ngx-device-detector';
 import { Subject, takeUntil } from 'rxjs';
 
 import { GfCreateOrUpdateTagDialogComponent } from './create-or-update-tag-dialog/create-or-update-tag-dialog.component';
+import { CreateOrUpdateTagDialogParams } from './create-or-update-tag-dialog/interfaces/interfaces';
 
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
@@ -149,9 +150,13 @@ export class GfAdminTagComponent implements OnInit, OnDestroy {
   }
 
   private openCreateTagDialog() {
-    const dialogRef = this.dialog.open(GfCreateOrUpdateTagDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfCreateOrUpdateTagDialogComponent,
+      CreateOrUpdateTagDialogParams
+    >(GfCreateOrUpdateTagDialogComponent, {
       data: {
         tag: {
+          id: null,
           name: null
         }
       },
@@ -183,8 +188,11 @@ export class GfAdminTagComponent implements OnInit, OnDestroy {
       });
   }
 
-  private openUpdateTagDialog({ id, name }) {
+  private openUpdateTagDialog({ id, name }: { id: string; name: string }) {
-    const dialogRef = this.dialog.open(GfCreateOrUpdateTagDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfCreateOrUpdateTagDialogComponent,
+      CreateOrUpdateTagDialogParams
+    >(GfCreateOrUpdateTagDialogComponent, {
       data: {
         tag: {
           id,

apps/client/src/app/components/admin-tag/create-or-update-tag-dialog/interfaces/interfaces.ts

@@ -1,5 +1,5 @@
 import { Tag } from '@prisma/client';
 
 export interface CreateOrUpdateTagDialogParams {
-  tag: Tag;
+  tag: Pick<Tag, 'id' | 'name'>;
 }

apps/client/src/app/components/admin-users/admin-users.component.ts

@@ -288,14 +288,17 @@ export class GfAdminUsersComponent implements OnDestroy, OnInit {
       return;
     }
 
-    const dialogRef = this.dialog.open(GfUserDetailDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfUserDetailDialogComponent,
+      UserDetailDialogParams
+    >(GfUserDetailDialogComponent, {
       autoFocus: false,
       data: {
         userData,
         deviceType: this.deviceType,
         hasPermissionForSubscription: this.hasPermissionForSubscription,
         locale: this.user?.settings?.locale
-      } as UserDetailDialogParams,
+      },
       height: this.deviceType === 'mobile' ? '98vh' : '60vh',
       width: this.deviceType === 'mobile' ? '100vw' : '50rem'
     });
@@ -304,7 +307,6 @@ export class GfAdminUsersComponent implements OnDestroy, OnInit {
       .afterClosed()
       .pipe(takeUntil(this.unsubscribeSubject))
       .subscribe(() => {
-        this.fetchUsers();
         this.router.navigate(['.'], { relativeTo: this.route });
       });
   }

apps/client/src/app/components/header/header.component.ts

@@ -1,4 +1,5 @@
 import { UpdateUserSettingDto } from '@ghostfolio/api/app/user/update-user-setting.dto';
+import { LoginWithAccessTokenDialogParams } from '@ghostfolio/client/components/login-with-access-token-dialog/interfaces/interfaces';
 import { GfLoginWithAccessTokenDialogComponent } from '@ghostfolio/client/components/login-with-access-token-dialog/login-with-access-token-dialog.component';
 import { LayoutService } from '@ghostfolio/client/core/layout.service';
 import { NotificationService } from '@ghostfolio/client/core/notification/notification.service';
@@ -271,7 +272,10 @@ export class GfHeaderComponent implements OnChanges {
   }
 
   public openLoginDialog() {
-    const dialogRef = this.dialog.open(GfLoginWithAccessTokenDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfLoginWithAccessTokenDialogComponent,
+      LoginWithAccessTokenDialogParams
+    >(GfLoginWithAccessTokenDialogComponent, {
       autoFocus: false,
       data: {
         accessToken: '',

apps/client/src/app/components/home-watchlist/home-watchlist.component.ts

@@ -149,17 +149,17 @@ export class GfHomeWatchlistComponent implements OnDestroy, OnInit {
       .subscribe((user) => {
         this.user = user;
 
-        const dialogRef = this.dialog.open(
+        const dialogRef = this.dialog.open<
           GfCreateWatchlistItemDialogComponent,
-          {
+          CreateWatchlistItemDialogParams
-            autoFocus: false,
+        >(GfCreateWatchlistItemDialogComponent, {
-            data: {
+          autoFocus: false,
-              deviceType: this.deviceType,
+          data: {
-              locale: this.user?.settings?.locale
+            deviceType: this.deviceType,
-            } as CreateWatchlistItemDialogParams,
+            locale: this.user?.settings?.locale
-            width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+          },
-          }
+          width: this.deviceType === 'mobile' ? '100vw' : '50rem'
-        );
+        });
 
         dialogRef
           .afterClosed()

apps/client/src/app/components/login-with-access-token-dialog/interfaces/interfaces.ts

@@ -0,0 +1,5 @@
+export interface LoginWithAccessTokenDialogParams {
+  accessToken: string;
+  hasPermissionToUseSocialLogin: boolean;
+  title: string;
+}

apps/client/src/app/components/login-with-access-token-dialog/login-with-access-token-dialog.component.ts

@@ -26,6 +26,8 @@ import { IonIcon } from '@ionic/angular/standalone';
 import { addIcons } from 'ionicons';
 import { eyeOffOutline, eyeOutline } from 'ionicons/icons';
 
+import { LoginWithAccessTokenDialogParams } from './interfaces/interfaces';
+
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
   imports: [
@@ -51,7 +53,7 @@ export class GfLoginWithAccessTokenDialogComponent {
   public isAccessTokenHidden = true;
 
   public constructor(
-    @Inject(MAT_DIALOG_DATA) public data: any,
+    @Inject(MAT_DIALOG_DATA) public data: LoginWithAccessTokenDialogParams,
     public dialogRef: MatDialogRef<GfLoginWithAccessTokenDialogComponent>,
     private internetIdentityService: InternetIdentityService,
     private router: Router,

apps/client/src/app/components/rule/rule.component.ts

@@ -79,13 +79,16 @@ export class GfRuleComponent implements OnInit {
   }
 
   public onCustomizeRule(rule: PortfolioReportRule) {
-    const dialogRef = this.dialog.open(GfRuleSettingsDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfRuleSettingsDialogComponent,
+      RuleSettingsDialogParams
+    >(GfRuleSettingsDialogComponent, {
       data: {
         rule,
         categoryName: this.categoryName,
         locale: this.locale,
         settings: this.settings
-      } as RuleSettingsDialogParams,
+      },
       width: this.deviceType === 'mobile' ? '100vw' : '50rem'
     });
 

apps/client/src/app/components/user-account-access/user-account-access.component.ts

@@ -31,6 +31,7 @@ import { EMPTY, Subject } from 'rxjs';
 import { catchError, takeUntil } from 'rxjs/operators';
 
 import { GfCreateOrUpdateAccessDialogComponent } from './create-or-update-access-dialog/create-or-update-access-dialog.component';
+import { CreateOrUpdateAccessDialogParams } from './create-or-update-access-dialog/interfaces/interfaces';
 
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
@@ -187,10 +188,15 @@ export class GfUserAccountAccessComponent implements OnDestroy, OnInit {
   }
 
   private openCreateAccessDialog() {
-    const dialogRef = this.dialog.open(GfCreateOrUpdateAccessDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfCreateOrUpdateAccessDialogComponent,
+      CreateOrUpdateAccessDialogParams
+    >(GfCreateOrUpdateAccessDialogComponent, {
       data: {
         access: {
           alias: '',
+          grantee: null,
+          id: null,
           permissions: ['READ_RESTRICTED'],
           type: 'PRIVATE'
         }
@@ -219,12 +225,15 @@ export class GfUserAccountAccessComponent implements OnDestroy, OnInit {
       return;
     }
 
-    const dialogRef = this.dialog.open(GfCreateOrUpdateAccessDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfCreateOrUpdateAccessDialogComponent,
+      CreateOrUpdateAccessDialogParams
+    >(GfCreateOrUpdateAccessDialogComponent, {
       data: {
         access: {
           alias: access.alias,
-          id: access.id,
           grantee: access.grantee === 'Public' ? null : access.grantee,
+          id: access.id,
           permissions: access.permissions,
           type: access.type
         }

apps/client/src/app/pages/about/overview/about-overview-page.html

@@ -175,7 +175,7 @@
     </div>
   </div>
 
-  <div class="row">
+  <div class="mb-5 row">
     <div
       class="col-md-6 col-xs-12 my-2"
       [ngClass]="{ 'offset-md-3': hasPermissionForSubscription === false }"
@@ -201,4 +201,26 @@
       </div>
     }
   </div>
+
+  <div class="row">
+    <div class="col-12">
+      <h2 class="h4 mb-3">Sponsors</h2>
+      <div class="text-center">
+        <small>Browser testing via</small>
+        <br />
+        <a
+          href="https://www.lambdatest.com?utm_medium=sponsor&utm_source=ghostfolio"
+          target="_blank"
+          title="LambdaTest - AI Powered Testing Tool"
+        >
+          <img
+            alt="LambdaTest Logo"
+            height="45"
+            src="https://www.lambdatest.com/blue-logo.png"
+            width="250"
+          />
+        </a>
+      </div>
+    </div>
+  </div>
 </div>

apps/client/src/app/pages/accounts/accounts-page.component.ts

@@ -23,6 +23,8 @@ import { EMPTY, Subject, Subscription } from 'rxjs';
 import { catchError, takeUntil } from 'rxjs/operators';
 
 import { GfCreateOrUpdateAccountDialogComponent } from './create-or-update-account-dialog/create-or-update-account-dialog.component';
+import { CreateOrUpdateAccountDialogParams } from './create-or-update-account-dialog/interfaces/interfaces';
+import { TransferBalanceDialogParams } from './transfer-balance/interfaces/interfaces';
 import { GfTransferBalanceDialogComponent } from './transfer-balance/transfer-balance-dialog.component';
 
 @Component({
@@ -179,7 +181,10 @@ export class GfAccountsPageComponent implements OnDestroy, OnInit {
     name,
     platformId
   }: AccountModel) {
-    const dialogRef = this.dialog.open(GfCreateOrUpdateAccountDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfCreateOrUpdateAccountDialogComponent,
+      CreateOrUpdateAccountDialogParams
+    >(GfCreateOrUpdateAccountDialogComponent, {
       data: {
         account: {
           balance,
@@ -227,7 +232,10 @@ export class GfAccountsPageComponent implements OnDestroy, OnInit {
   }
 
   private openAccountDetailDialog(aAccountId: string) {
-    const dialogRef = this.dialog.open(GfAccountDetailDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfAccountDetailDialogComponent,
+      AccountDetailDialogParams
+    >(GfAccountDetailDialogComponent, {
       autoFocus: false,
       data: {
         accountId: aAccountId,
@@ -237,7 +245,7 @@ export class GfAccountsPageComponent implements OnDestroy, OnInit {
           !this.hasImpersonationId &&
           hasPermission(this.user?.permissions, permissions.createOrder) &&
           !this.user?.settings?.isRestrictedView
-      } as AccountDetailDialogParams,
+      },
       height: this.deviceType === 'mobile' ? '98vh' : '80vh',
       width: this.deviceType === 'mobile' ? '100vw' : '50rem'
     });
@@ -253,12 +261,16 @@ export class GfAccountsPageComponent implements OnDestroy, OnInit {
   }
 
   private openCreateAccountDialog() {
-    const dialogRef = this.dialog.open(GfCreateOrUpdateAccountDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfCreateOrUpdateAccountDialogComponent,
+      CreateOrUpdateAccountDialogParams
+    >(GfCreateOrUpdateAccountDialogComponent, {
       data: {
         account: {
           balance: 0,
           comment: null,
           currency: this.user?.settings?.baseCurrency,
+          id: null,
           isExcluded: false,
           name: null,
           platformId: null
@@ -295,7 +307,10 @@ export class GfAccountsPageComponent implements OnDestroy, OnInit {
   }
 
   private openTransferBalanceDialog() {
-    const dialogRef = this.dialog.open(GfTransferBalanceDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfTransferBalanceDialogComponent,
+      TransferBalanceDialogParams
+    >(GfTransferBalanceDialogComponent, {
       data: {
         accounts: this.accounts
       },

apps/client/src/app/pages/accounts/create-or-update-account-dialog/interfaces/interfaces.ts

@@ -1,5 +1,5 @@
 import { Account } from '@prisma/client';
 
 export interface CreateOrUpdateAccountDialogParams {
-  account: Account;
+  account: Omit<Account, 'createdAt' | 'updatedAt' | 'userId'>;
 }

apps/client/src/app/pages/portfolio/activities/activities-page.component.ts

@@ -28,6 +28,7 @@ import { Subject, Subscription } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
 
 import { GfCreateOrUpdateActivityDialogComponent } from './create-or-update-activity-dialog/create-or-update-activity-dialog.component';
+import { CreateOrUpdateActivityDialogParams } from './create-or-update-activity-dialog/interfaces/interfaces';
 import { GfImportActivitiesDialogComponent } from './import-activities-dialog/import-activities-dialog.component';
 import { ImportActivitiesDialogParams } from './import-activities-dialog/interfaces/interfaces';
 
@@ -245,11 +246,14 @@ export class GfActivitiesPageComponent implements OnDestroy, OnInit {
   }
 
   public onImport() {
-    const dialogRef = this.dialog.open(GfImportActivitiesDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfImportActivitiesDialogComponent,
+      ImportActivitiesDialogParams
+    >(GfImportActivitiesDialogComponent, {
       data: {
         deviceType: this.deviceType,
         user: this.user
-      } as ImportActivitiesDialogParams,
+      },
       height: this.deviceType === 'mobile' ? '98vh' : undefined,
       width: this.deviceType === 'mobile' ? '100vw' : '50rem'
     });
@@ -268,12 +272,15 @@ export class GfActivitiesPageComponent implements OnDestroy, OnInit {
   }
 
   public onImportDividends() {
-    const dialogRef = this.dialog.open(GfImportActivitiesDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfImportActivitiesDialogComponent,
+      ImportActivitiesDialogParams
+    >(GfImportActivitiesDialogComponent, {
       data: {
         activityTypes: ['DIVIDEND'],
         deviceType: this.deviceType,
         user: this.user
-      } as ImportActivitiesDialogParams,
+      },
       height: this.deviceType === 'mobile' ? '98vh' : undefined,
       width: this.deviceType === 'mobile' ? '100vw' : '50rem'
     });
@@ -306,18 +313,18 @@ export class GfActivitiesPageComponent implements OnDestroy, OnInit {
   }
 
   public openUpdateActivityDialog(aActivity: Activity) {
-    const dialogRef = this.dialog.open(
+    const dialogRef = this.dialog.open<
       GfCreateOrUpdateActivityDialogComponent,
-      {
+      CreateOrUpdateActivityDialogParams
-        data: {
+    >(GfCreateOrUpdateActivityDialogComponent, {
-          activity: aActivity,
+      data: {
-          accounts: this.user?.accounts,
+        activity: aActivity,
-          user: this.user
+        accounts: this.user?.accounts,
-        },
+        user: this.user
-        height: this.deviceType === 'mobile' ? '98vh' : '80vh',
+      },
-        width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+      height: this.deviceType === 'mobile' ? '98vh' : '80vh',
-      }
+      width: this.deviceType === 'mobile' ? '100vw' : '50rem'
-    );
+    });
 
     dialogRef
       .afterClosed()
@@ -350,26 +357,26 @@ export class GfActivitiesPageComponent implements OnDestroy, OnInit {
       .subscribe((user) => {
         this.updateUser(user);
 
-        const dialogRef = this.dialog.open(
+        const dialogRef = this.dialog.open<
           GfCreateOrUpdateActivityDialogComponent,
-          {
+          CreateOrUpdateActivityDialogParams
-            data: {
+        >(GfCreateOrUpdateActivityDialogComponent, {
-              accounts: this.user?.accounts,
+          data: {
-              activity: {
+            accounts: this.user?.accounts,
-                ...aActivity,
+            activity: {
-                accountId: aActivity?.accountId,
+              ...aActivity,
-                date: new Date(),
+              accountId: aActivity?.accountId,
-                id: null,
+              date: new Date(),
-                fee: 0,
+              id: null,
-                type: aActivity?.type ?? 'BUY',
+              fee: 0,
-                unitPrice: null
+              type: aActivity?.type ?? 'BUY',
-              },
+              unitPrice: null
-              user: this.user
             },
-            height: this.deviceType === 'mobile' ? '98vh' : '80vh',
+            user: this.user
-            width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+          },
-          }
+          height: this.deviceType === 'mobile' ? '98vh' : '80vh',
-        );
+          width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+        });
 
         dialogRef
           .afterClosed()

apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/interfaces/interfaces.ts

@@ -4,7 +4,6 @@ import { User } from '@ghostfolio/common/interfaces';
 import { Account } from '@prisma/client';
 
 export interface CreateOrUpdateActivityDialogParams {
-  accountId: string;
   accounts: Account[];
   activity: Activity;
   user: User;

apps/client/src/app/pages/portfolio/activities/import-activities-dialog/interfaces/interfaces.ts

@@ -3,7 +3,7 @@ import { User } from '@ghostfolio/common/interfaces';
 import { Type } from '@prisma/client';
 
 export interface ImportActivitiesDialogParams {
-  activityTypes: Type[];
+  activityTypes?: Type[];
   deviceType: string;
   user: User;
 }

apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts

@@ -558,7 +558,10 @@ export class GfAllocationsPageComponent implements OnDestroy, OnInit {
   }
 
   private openAccountDetailDialog(aAccountId: string) {
-    const dialogRef = this.dialog.open(GfAccountDetailDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfAccountDetailDialogComponent,
+      AccountDetailDialogParams
+    >(GfAccountDetailDialogComponent, {
       autoFocus: false,
       data: {
         accountId: aAccountId,
@@ -568,7 +571,7 @@ export class GfAllocationsPageComponent implements OnDestroy, OnInit {
           !this.hasImpersonationId &&
           hasPermission(this.user?.permissions, permissions.createOrder) &&
           !this.user?.settings?.isRestrictedView
-      } as AccountDetailDialogParams,
+      },
       height: this.deviceType === 'mobile' ? '98vh' : '80vh',
       width: this.deviceType === 'mobile' ? '100vw' : '50rem'
     });

apps/client/src/app/pages/register/register-page.component.ts

@@ -84,18 +84,18 @@ export class GfRegisterPageComponent implements OnDestroy, OnInit {
   }
 
   public openShowAccessTokenDialog() {
-    const dialogRef = this.dialog.open(
+    const dialogRef = this.dialog.open<
       GfUserAccountRegistrationDialogComponent,
-      {
+      UserAccountRegistrationDialogParams
-        data: {
+    >(GfUserAccountRegistrationDialogComponent, {
-          deviceType: this.deviceType,
+      data: {
-          needsToAcceptTermsOfService: this.hasPermissionForSubscription
+        deviceType: this.deviceType,
-        } as UserAccountRegistrationDialogParams,
+        needsToAcceptTermsOfService: this.hasPermissionForSubscription
-        disableClose: true,
+      },
-        height: this.deviceType === 'mobile' ? '98vh' : undefined,
+      disableClose: true,
-        width: this.deviceType === 'mobile' ? '100vw' : '30rem'
+      height: this.deviceType === 'mobile' ? '98vh' : undefined,
-      }
+      width: this.deviceType === 'mobile' ? '100vw' : '30rem'
-    );
+    });
 
     dialogRef
       .afterClosed()

apps/client/src/app/pages/resources/glossary/resources-glossary.component.html

@@ -5,7 +5,7 @@
       <div>
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">Buy and Hold</h3>
+            <h2 class="h5 mb-1 mt-0">Buy and Hold</h2>
             <div class="mb-1">
               Buy and hold is a passive investment strategy where you buy assets
               and hold them for a long period regardless of fluctuations in the
@@ -22,7 +22,7 @@
         </div>
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">Deflation</h3>
+            <h2 class="h5 mb-1 mt-0">Deflation</h2>
             <div class="mb-1">
               Deflation is a decrease of the general price level for goods and
               services in an economy over a period of time.
@@ -38,7 +38,7 @@
         </div>
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">Dollar-Cost Averaging (DCA)</h3>
+            <h2 class="h5 mb-1 mt-0">Dollar-Cost Averaging (DCA)</h2>
             <div class="mb-1">
               Dollar-cost averaging is an investment strategy where you split
               the total amount to be invested across periodic purchases of a
@@ -56,7 +56,7 @@
         </div>
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">Financial Independence</h3>
+            <h2 class="h5 mb-1 mt-0">Financial Independence</h2>
             <div class="mb-1">
               Financial independence is the status of having enough income, for
               example with a passive income like dividends, to cover your living
@@ -73,7 +73,7 @@
         </div>
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">FIRE</h3>
+            <h2 class="h5 mb-1 mt-0">FIRE</h2>
             <div class="mb-1">
               FIRE is a movement that promotes saving and investing to achieve
               financial independence and early retirement.
@@ -85,7 +85,7 @@
         </div>
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">Inflation</h3>
+            <h2 class="h5 mb-1 mt-0">Inflation</h2>
             <div class="mb-1">
               Inflation is an increase of the general price level for goods and
               services in an economy over a period of time.
@@ -102,7 +102,7 @@
         @if (hasPermissionForSubscription) {
           <div class="mb-4 media">
             <div class="media-body">
-              <h3 class="h5 mt-0">Personal Finance Tools</h3>
+              <h2 class="h5 mb-1 mt-0">Personal Finance Tools</h2>
               <div class="mb-1">
                 Personal finance tools are software applications that help
                 manage your money, track expenses, set budgets, monitor
@@ -118,7 +118,7 @@
         }
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">Stagflation</h3>
+            <h2 class="h5 mb-1 mt-0">Stagflation</h2>
             <div class="mb-1">
               Stagflation describes a situation in which there is a stagnant
               economy with high unemployment and high inflation.
@@ -134,7 +134,7 @@
         </div>
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">Stealth Wealth</h3>
+            <h2 class="h5 mb-1 mt-0">Stealth Wealth</h2>
             <div class="mb-1">
               Stealth wealth is a lifestyle choice where you don’t openly show
               off your wealth, but instead live quietly to maintain privacy and

apps/client/src/app/pages/resources/guides/resources-guides.component.html

@@ -5,7 +5,7 @@
       <div class="mb-5">
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">Boringly Getting Rich</h3>
+            <h2 class="h5 mb-1 mt-0">Boringly Getting Rich</h2>
             <div class="mb-1">
               The <i>Boringly Getting Rich</i> guide supports you to get started
               with investing. It introduces a strategy utilizing a broadly
@@ -21,7 +21,7 @@
         </div>
         <div class="mb-4 media">
           <div class="media-body">
-            <h3 class="h5 mt-0">How do I get my finances in order?</h3>
+            <h2 class="h5 mb-1 mt-0">How do I get my finances in order?</h2>
             <div class="mb-1">
               Before you can think of long-term investing, you have to get your
               finances in order. Learn how you can reach your financial goals

apps/client/src/app/pages/resources/markets/resources-markets.component.html

@@ -3,7 +3,7 @@
   <div class="mb-5">
     <div class="mb-4 media">
       <div class="media-body">
-        <h3 class="h5 mt-0">Crypto Coins Heatmap</h3>
+        <h2 class="h5 mb-1 mt-0">Crypto Coins Heatmap</h2>
         <div class="mb-1">
           With the <i>Crypto Coins Heatmap</i> you can track the daily market
           movements of cryptocurrencies as a visual snapshot.
@@ -17,7 +17,7 @@
     </div>
     <div class="mb-4 media">
       <div class="media-body">
-        <h3 class="h5 mt-0">Fear & Greed Index</h3>
+        <h2 class="h5 mb-1 mt-0">Fear & Greed Index</h2>
         <div class="mb-1">
           The fear and greed index was developed by <i>CNNMoney</i> to measure
           the primary emotions (fear and greed) that influence how much
@@ -32,7 +32,7 @@
     </div>
     <div class="media">
       <div class="mb-4 media">
-        <h3 class="h5 mt-0">Inflation Chart</h3>
+        <h2 class="h5 mb-1 mt-0">Inflation Chart</h2>
         <div class="mb-1">
           <i>Inflation Chart</i> helps you find the intrinsic value of stock
           markets, stock prices, goods and services by adjusting them to the
@@ -48,7 +48,7 @@
     </div>
     <div class="media">
       <div class="media-body">
-        <h3 class="h5 mt-0">Stock Heatmap</h3>
+        <h2 class="h5 mb-1 mt-0">Stock Heatmap</h2>
         <div class="mb-1">
           With the <i>Stock Heatmap</i> you can track the daily market movements
           of stocks as a visual snapshot.

apps/client/src/app/pages/resources/overview/resources-overview.component.html

@@ -5,7 +5,7 @@
       <div class="overview-list">
         @for (item of overviewItems; track item) {
           <div class="mb-4">
-            <h3 class="h5 mt-0">{{ item.title }}</h3>
+            <h2 class="h5 mb-1 mt-0">{{ item.title }}</h2>
             <p class="mb-1">{{ item.description }}</p>
             <a [routerLink]="item.routerLink">Explore {{ item.title }} →</a>
           </div>

apps/client/src/app/services/user/user.service.ts

@@ -116,18 +116,18 @@ export class UserService extends ObservableStore<UserStoreState> {
             permissions.enableSubscriptionInterstitial
           )
         ) {
-          const dialogRef = this.dialog.open(
+          const dialogRef = this.dialog.open<
             GfSubscriptionInterstitialDialogComponent,
-            {
+            SubscriptionInterstitialDialogParams
-              autoFocus: false,
+          >(GfSubscriptionInterstitialDialogComponent, {
-              data: {
+            autoFocus: false,
-                user
+            data: {
-              } as SubscriptionInterstitialDialogParams,
+              user
-              disableClose: true,
+            },
-              height: this.deviceType === 'mobile' ? '98vh' : '80vh',
+            disableClose: true,
-              width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+            height: this.deviceType === 'mobile' ? '98vh' : '80vh',
-            }
+            width: this.deviceType === 'mobile' ? '100vw' : '50rem'
-          );
+          });
 
           dialogRef
             .afterClosed()

libs/ui/src/lib/benchmark/benchmark.component.ts

@@ -155,14 +155,17 @@ export class GfBenchmarkComponent implements OnChanges, OnDestroy {
     dataSource,
     symbol
   }: AssetProfileIdentifier) {
-    const dialogRef = this.dialog.open(GfBenchmarkDetailDialogComponent, {
+    const dialogRef = this.dialog.open<
+      GfBenchmarkDetailDialogComponent,
+      BenchmarkDetailDialogParams
+    >(GfBenchmarkDetailDialogComponent, {
       data: {
         dataSource,
         symbol,
         colorScheme: this.user?.settings?.colorScheme,
         deviceType: this.deviceType,
         locale: this.locale
-      } as BenchmarkDetailDialogParams,
+      },
       height: this.deviceType === 'mobile' ? '98vh' : undefined,
       width: this.deviceType === 'mobile' ? '100vw' : '50rem'
     });

libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor.component.ts

@@ -199,21 +199,21 @@ export class GfHistoricalMarketDataEditorComponent
   }) {
     const marketPrice = this.marketDataByMonth[yearMonth]?.[day]?.marketPrice;
 
-    const dialogRef = this.dialog.open(
+    const dialogRef = this.dialog.open<
       GfHistoricalMarketDataEditorDialogComponent,
-      {
+      HistoricalMarketDataEditorDialogParams
-        data: {
+    >(GfHistoricalMarketDataEditorDialogComponent, {
-          marketPrice,
+      data: {
-          currency: this.currency,
+        marketPrice,
-          dataSource: this.dataSource,
+        currency: this.currency,
-          dateString: `${yearMonth}-${day}`,
+        dataSource: this.dataSource,
-          symbol: this.symbol,
+        dateString: `${yearMonth}-${day}`,
-          user: this.user
+        symbol: this.symbol,
-        } as HistoricalMarketDataEditorDialogParams,
+        user: this.user
-        height: this.deviceType === 'mobile' ? '98vh' : '80vh',
+      },
-        width: this.deviceType === 'mobile' ? '100vw' : '50rem'
+      height: this.deviceType === 'mobile' ? '98vh' : '80vh',
-      }
+      width: this.deviceType === 'mobile' ? '100vw' : '50rem'
-    );
+    });
 
     dialogRef
       .afterClosed()

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "ghostfolio",
-  "version": "2.211.0",
+  "version": "2.212.0",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "ghostfolio",
-      "version": "2.211.0",
+      "version": "2.212.0",
       "hasInstallScript": true,
       "license": "AGPL-3.0",
       "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ghostfolio",
-  "version": "2.211.0",
+  "version": "2.212.0",
   "homepage": "https://ghostfol.io",
   "license": "AGPL-3.0",
   "repository": "https://github.com/ghostfolio/ghostfolio",