Browse Source

Task/set change detection strategy to OnPush in FIRE page (#7252)

* Set change detection strategy to OnPush

* Update changelog
pull/7256/head^2
Archit Goyal 1 week ago
committed by GitHub
parent
commit
898fc76965
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 6
      CHANGELOG.md
  2. 7
      apps/client/src/app/pages/portfolio/fire/fire-page.component.ts

6
CHANGELOG.md

@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## Unreleased
### Changed
- Set the change detection strategy to `OnPush` in the _FIRE_ page
## 3.21.0 - 2026-07-05 ## 3.21.0 - 2026-07-05
### Added ### Added

7
apps/client/src/app/pages/portfolio/fire/fire-page.component.ts

@ -14,6 +14,7 @@ import { GfValueComponent } from '@ghostfolio/ui/value';
import { CommonModule } from '@angular/common'; import { CommonModule } from '@angular/common';
import { import {
ChangeDetectionStrategy,
ChangeDetectorRef, ChangeDetectorRef,
Component, Component,
computed, computed,
@ -29,6 +30,7 @@ import { DeviceDetectorService } from 'ngx-device-detector';
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [ imports: [
CommonModule, CommonModule,
FormsModule, FormsModule,
@ -89,6 +91,7 @@ export class GfFirePageComponent implements OnInit {
: 0 : 0
} }
}; };
if (this.user.subscription?.type === SubscriptionType.Basic) { if (this.user.subscription?.type === SubscriptionType.Basic) {
this.fireWealth = { this.fireWealth = {
today: { today: {
@ -107,6 +110,8 @@ export class GfFirePageComponent implements OnInit {
.pipe(takeUntilDestroyed(this.destroyRef)) .pipe(takeUntilDestroyed(this.destroyRef))
.subscribe((impersonationId) => { .subscribe((impersonationId) => {
this.hasImpersonationId = !!impersonationId; this.hasImpersonationId = !!impersonationId;
this.changeDetectorRef.markForCheck();
}); });
this.safeWithdrawalRateControl.valueChanges this.safeWithdrawalRateControl.valueChanges
@ -135,9 +140,9 @@ export class GfFirePageComponent implements OnInit {
); );
this.calculateWithdrawalRates(); this.calculateWithdrawalRates();
}
this.changeDetectorRef.markForCheck(); this.changeDetectorRef.markForCheck();
}
}); });
} }

Loading…
Cancel
Save