Browse Source

refactor: address PR review feedback

- Remove mb-3 class from landing page
- Remove all -webkit- prefixed CSS properties
- Use Bootstrap w-100 class instead of width: 100%
- Use Bootstrap overflow-hidden class instead of overflow: hidden
- Replace rgba(var(--palette-background-background-dark), 1) with var(--dark-background)
- Replace rgba(var(--palette-background-background), 1) with var(--light-background)
pull/5671/head
URAYUSHJAIN 4 weeks ago
parent
commit
8b0ee43402
  1. 2
      apps/client/src/app/pages/landing/landing-page.html
  2. 8
      libs/ui/src/lib/logo-carousel/logo-carousel.component.html
  3. 24
      libs/ui/src/lib/logo-carousel/logo-carousel.component.scss

2
apps/client/src/app/pages/landing/landing-page.html

@ -111,7 +111,7 @@
} }
<div class="row mb-5"> <div class="row mb-5">
<div class="col-12 text-center text-muted mb-3"> <div class="col-12 text-center text-muted">
<small i18n>As seen in</small> <small i18n>As seen in</small>
</div> </div>
<div class="col-12"> <div class="col-12">

8
libs/ui/src/lib/logo-carousel/logo-carousel.component.html

@ -1,9 +1,7 @@
<div class="logo-carousel-container"> <div class="logo-carousel-container w-100 overflow-hidden">
<div class="d-flex logo-carousel-track"> <div class="logo-carousel-track">
@for (logo of duplicatedLogos; track $index) { @for (logo of duplicatedLogos; track $index) {
<div <div class="logo-carousel-item">
class="logo-carousel-item d-flex align-items-center justify-content-center"
>
<a <a
class="d-block logo" class="d-block logo"
target="_blank" target="_blank"

24
libs/ui/src/lib/logo-carousel/logo-carousel.component.scss

@ -5,8 +5,6 @@
position: relative; position: relative;
.logo-carousel-container { .logo-carousel-container {
width: 100%;
overflow: hidden;
position: relative; position: relative;
// Fade gradient mask for smooth edges // Fade gradient mask for smooth edges
@ -25,7 +23,7 @@
left: 0; left: 0;
background: linear-gradient( background: linear-gradient(
to right, to right,
rgba(var(--palette-background-background), 1) 0%, var(--light-background) 0%,
rgba(var(--palette-background-background), 0) 100% rgba(var(--palette-background-background), 0) 100%
); );
} }
@ -34,7 +32,7 @@
right: 0; right: 0;
background: linear-gradient( background: linear-gradient(
to left, to left,
rgba(var(--palette-background-background), 1) 0%, var(--light-background) 0%,
rgba(var(--palette-background-background), 0) 100% rgba(var(--palette-background-background), 0) 100%
); );
} }
@ -96,17 +94,13 @@
&.mask { &.mask {
background-color: rgba(var(--dark-secondary-text)); background-color: rgba(var(--dark-secondary-text));
-webkit-mask-position: center;
mask-position: center; mask-position: center;
-webkit-mask-repeat: no-repeat;
mask-repeat: no-repeat; mask-repeat: no-repeat;
-webkit-mask-size: contain;
mask-size: contain; mask-size: contain;
} }
// Logo-specific styles (copied from landing-page.scss) // Logo-specific styles (copied from landing-page.scss)
&.logo-alternative-to { &.logo-alternative-to {
-webkit-mask-image: url('/assets/images/logo-alternative-to.svg');
mask-image: url('/assets/images/logo-alternative-to.svg'); mask-image: url('/assets/images/logo-alternative-to.svg');
} }
@ -119,22 +113,18 @@
} }
&.logo-dev-community { &.logo-dev-community {
-webkit-mask-image: url('/assets/images/logo-dev-community.svg');
mask-image: url('/assets/images/logo-dev-community.svg'); mask-image: url('/assets/images/logo-dev-community.svg');
} }
&.logo-hacker-news { &.logo-hacker-news {
-webkit-mask-image: url('/assets/images/logo-hacker-news.svg');
mask-image: url('/assets/images/logo-hacker-news.svg'); mask-image: url('/assets/images/logo-hacker-news.svg');
} }
&.logo-openalternative { &.logo-openalternative {
-webkit-mask-image: url('/assets/images/logo-openalternative.svg');
mask-image: url('/assets/images/logo-openalternative.svg'); mask-image: url('/assets/images/logo-openalternative.svg');
} }
&.logo-privacy-tools { &.logo-privacy-tools {
-webkit-mask-image: url('/assets/images/logo-privacy-tools.svg');
mask-image: url('/assets/images/logo-privacy-tools.svg'); mask-image: url('/assets/images/logo-privacy-tools.svg');
} }
@ -147,35 +137,29 @@
} }
&.logo-reddit { &.logo-reddit {
-webkit-mask-image: url('/assets/images/logo-reddit.svg');
mask-image: url('/assets/images/logo-reddit.svg'); mask-image: url('/assets/images/logo-reddit.svg');
max-height: 1rem; max-height: 1rem;
} }
&.logo-sackgeld { &.logo-sackgeld {
-webkit-mask-image: url('/assets/images/logo-sackgeld.png');
mask-image: url('/assets/images/logo-sackgeld.png'); mask-image: url('/assets/images/logo-sackgeld.png');
} }
&.logo-selfh-st { &.logo-selfh-st {
-webkit-mask-image: url('/assets/images/logo-selfh-st.svg');
mask-image: url('/assets/images/logo-selfh-st.svg'); mask-image: url('/assets/images/logo-selfh-st.svg');
max-height: 1.25rem; max-height: 1.25rem;
} }
&.logo-sourceforge { &.logo-sourceforge {
-webkit-mask-image: url('/assets/images/logo-sourceforge.svg');
mask-image: url('/assets/images/logo-sourceforge.svg'); mask-image: url('/assets/images/logo-sourceforge.svg');
} }
&.logo-umbrel { &.logo-umbrel {
-webkit-mask-image: url('/assets/images/logo-umbrel.svg');
mask-image: url('/assets/images/logo-umbrel.svg'); mask-image: url('/assets/images/logo-umbrel.svg');
max-height: 1.5rem; max-height: 1.5rem;
} }
&.logo-unraid { &.logo-unraid {
-webkit-mask-image: url('/assets/images/logo-unraid.svg');
mask-image: url('/assets/images/logo-unraid.svg'); mask-image: url('/assets/images/logo-unraid.svg');
} }
@ -198,7 +182,7 @@
&::before { &::before {
background: linear-gradient( background: linear-gradient(
to right, to right,
rgba(var(--palette-background-background-dark), 1) 0%, var(--dark-background) 0%,
rgba(var(--palette-background-background-dark), 0) 100% rgba(var(--palette-background-background-dark), 0) 100%
); );
} }
@ -206,7 +190,7 @@
&::after { &::after {
background: linear-gradient( background: linear-gradient(
to left, to left,
rgba(var(--palette-background-background-dark), 1) 0%, var(--dark-background) 0%,
rgba(var(--palette-background-background-dark), 0) 100% rgba(var(--palette-background-background-dark), 0) 100%
); );
} }

Loading…
Cancel
Save