Browse Source
			
			
			Feature/improve usability of create or edit transaction dialog (#661)
			
				* Move the fee to the bottom
* Update changelog
			
			
				pull/662/head
			
			
		 
		
			
				
					
						
						Thomas Kaul
					
					4 years ago
					
						
							committed by
							
								
								GitHub
							
						 
					
				 
				
			 
		 
		
			
				
					
					No known key found for this signature in database
					
						
							GPG Key ID: 4AEE18F83AFDEB23
						
					
				
			
		
		
		
	
		
			
				 2 changed files with 
15 additions and 
12 deletions
			 
			
		 
		
			
				- 
					
					
					 
					CHANGELOG.md
				
 
			
				- 
					
					
					 
					apps/client/src/app/pages/portfolio/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.html
				
 
			
		
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
		
			
				
					| 
						
						
							
								
							
						
						
					 | 
					@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					
 | 
					 | 
					 | 
					
 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					### Changed | 
					 | 
					 | 
					### Changed | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					
 | 
					 | 
					 | 
					
 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					- Improved the usability of the form in the create or edit transaction dialog | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					- Improved the consistent use of `symbol` in combination with `dataSource` | 
					 | 
					 | 
					- Improved the consistent use of `symbol` in combination with `dataSource` | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					- Removed the primary data source from the client | 
					 | 
					 | 
					- Removed the primary data source from the client | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					
 | 
					 | 
					 | 
					
 | 
				
			
			
		
	
	
		
		
			
				
					| 
						
							
								
							
						
						
						
					 | 
					
  | 
				
			
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
		
			
				
					| 
						
						
							
								
							
						
						
					 | 
					@ -107,18 +107,6 @@ | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					        <mat-datepicker #date disabled="false"></mat-datepicker> | 
					 | 
					 | 
					        <mat-datepicker #date disabled="false"></mat-datepicker> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					      </mat-form-field> | 
					 | 
					 | 
					      </mat-form-field> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					    </div> | 
					 | 
					 | 
					    </div> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					    <div> | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					      <mat-form-field appearance="outline" class="w-100"> | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					        <mat-label i18n>Fee</mat-label> | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					        <input | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					          matInput | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					          name="fee" | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					          required | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					          type="number" | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					          [(ngModel)]="data.transaction.fee" | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					        /> | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					      </mat-form-field> | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					    </div> | 
					 | 
					 | 
					 | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					    <div> | 
					 | 
					 | 
					    <div> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					      <mat-form-field appearance="outline" class="w-100"> | 
					 | 
					 | 
					      <mat-form-field appearance="outline" class="w-100"> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					        <mat-label i18n>Quantity</mat-label> | 
					 | 
					 | 
					        <mat-label i18n>Quantity</mat-label> | 
				
			
			
		
	
	
		
		
			
				
					| 
						
						
						
							
								
							
						
					 | 
					@ -141,6 +129,7 @@ | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					          type="number" | 
					 | 
					 | 
					          type="number" | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					          [(ngModel)]="data.transaction.unitPrice" | 
					 | 
					 | 
					          [(ngModel)]="data.transaction.unitPrice" | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					        /> | 
					 | 
					 | 
					        /> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					        <span class="ml-2" matSuffix>{{ data.transaction.currency }}</span> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					        <button | 
					 | 
					 | 
					        <button | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					          *ngIf="currentMarketPrice && (data.transaction.type === 'BUY' || data.transaction.type === 'SELL')" | 
					 | 
					 | 
					          *ngIf="currentMarketPrice && (data.transaction.type === 'BUY' || data.transaction.type === 'SELL')" | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					          mat-icon-button | 
					 | 
					 | 
					          mat-icon-button | 
				
			
			
		
	
	
		
		
			
				
					| 
						
						
						
							
								
							
						
					 | 
					@ -152,6 +141,19 @@ | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					        </button> | 
					 | 
					 | 
					        </button> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					      </mat-form-field> | 
					 | 
					 | 
					      </mat-form-field> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					    </div> | 
					 | 
					 | 
					    </div> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					    <div> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					      <mat-form-field appearance="outline" class="w-100"> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					        <mat-label i18n>Fee</mat-label> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					        <input | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					          matInput | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					          name="fee" | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					          required | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					          type="number" | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					          [(ngModel)]="data.transaction.fee" | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					        /> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					        <span class="ml-2" matSuffix>{{ data.transaction.currency }}</span> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					      </mat-form-field> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					 | 
					 | 
					 | 
					    </div> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					  </div> | 
					 | 
					 | 
					  </div> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					  <div class="d-flex" mat-dialog-actions> | 
					 | 
					 | 
					  <div class="d-flex" mat-dialog-actions> | 
				
			
			
		
	
		
		
			
				
					 | 
					 | 
					    <gf-value | 
					 | 
					 | 
					    <gf-value | 
				
			
			
		
	
	
		
		
			
				
					| 
						
							
								
							
						
						
						
					 | 
					
  |