Browse Source
Task/remove deprecated committed funds from summary of portfolio details (#6442)
* Remove deprecated committedFunds
* Update changelog
main
Thomas Kaul
10 hours ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with
1 additions and
10 deletions
-
CHANGELOG.md
-
apps/api/src/app/portfolio/portfolio.controller.ts
-
apps/api/src/app/portfolio/portfolio.service.ts
-
apps/api/src/helper/object.helper.spec.ts
-
libs/common/src/lib/interfaces/portfolio-summary.interface.ts
|
|
|
@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
|
|
|
|
### Changed |
|
|
|
|
|
|
|
- Removed the deprecated `committedFunds` from the summary of the portfolio details endpoint |
|
|
|
- Upgraded `Nx` from version `22.4.5` to `22.5.3` |
|
|
|
|
|
|
|
## 2.245.0 - 2026-03-01 |
|
|
|
|
|
|
|
@ -187,7 +187,6 @@ export class PortfolioController { |
|
|
|
|
|
|
|
portfolioSummary = nullifyValuesInObject(summary, [ |
|
|
|
'cash', |
|
|
|
'committedFunds', |
|
|
|
'currentNetWorth', |
|
|
|
'currentValueInBaseCurrency', |
|
|
|
'dividendInBaseCurrency', |
|
|
|
|
|
|
|
@ -1914,8 +1914,6 @@ export class PortfolioService { |
|
|
|
.plus(emergencyFundHoldingsValueInBaseCurrency) |
|
|
|
.toNumber(); |
|
|
|
|
|
|
|
const committedFunds = new Big(totalBuy).minus(totalSell); |
|
|
|
|
|
|
|
const totalOfExcludedActivities = this.getSumOfActivityType({ |
|
|
|
userCurrency, |
|
|
|
activities: excludedActivities, |
|
|
|
@ -1979,7 +1977,6 @@ export class PortfolioService { |
|
|
|
activityCount: activities.filter(({ type }) => { |
|
|
|
return ['BUY', 'SELL'].includes(type); |
|
|
|
}).length, |
|
|
|
committedFunds: committedFunds.toNumber(), |
|
|
|
currentValueInBaseCurrency: currentValueInBaseCurrency.toNumber(), |
|
|
|
dividendInBaseCurrency: dividendInBaseCurrency.toNumber(), |
|
|
|
emergencyFund: { |
|
|
|
|
|
|
|
@ -1540,7 +1540,6 @@ describe('redactAttributes', () => { |
|
|
|
netPerformanceWithCurrencyEffect: null, |
|
|
|
totalBuy: null, |
|
|
|
totalSell: null, |
|
|
|
committedFunds: null, |
|
|
|
currentValueInBaseCurrency: null, |
|
|
|
dividendInBaseCurrency: null, |
|
|
|
emergencyFund: null, |
|
|
|
@ -3017,7 +3016,6 @@ describe('redactAttributes', () => { |
|
|
|
netPerformanceWithCurrencyEffect: null, |
|
|
|
totalBuy: null, |
|
|
|
totalSell: null, |
|
|
|
committedFunds: null, |
|
|
|
currentValueInBaseCurrency: null, |
|
|
|
dividendInBaseCurrency: null, |
|
|
|
emergencyFund: null, |
|
|
|
|
|
|
|
@ -6,10 +6,6 @@ export interface PortfolioSummary extends PortfolioPerformance { |
|
|
|
annualizedPerformancePercent: number; |
|
|
|
annualizedPerformancePercentWithCurrencyEffect: number; |
|
|
|
cash: number; |
|
|
|
|
|
|
|
/** @deprecated use totalInvestmentValueWithCurrencyEffect instead */ |
|
|
|
committedFunds: number; |
|
|
|
|
|
|
|
dateOfFirstActivity: Date; |
|
|
|
dividendInBaseCurrency: number; |
|
|
|
emergencyFund: { |
|
|
|
|