Browse Source

Deprecate order endpoints in favor of activities endpoints

pull/6446/head
Thomas Kaul 1 month ago
parent
commit
921dc06477
  1. 8
      apps/api/src/app/activities/activities.service.ts
  2. 2
      apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-cash.spec.ts
  3. 8
      apps/api/src/app/portfolio/portfolio.service.ts
  4. 2
      apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.processor.ts

8
apps/api/src/app/activities/activities.service.ts

@ -745,17 +745,17 @@ export class ActivitiesService {
}
/**
* Retrieves all orders required for the portfolio calculator, including both standard asset orders
* and optional synthetic orders representing cash activities.
* Retrieves all activities required for the portfolio calculator, including both standard asset activities
* and optional synthetic activities representing cash activities.
*/
@LogPerformance
public async getOrdersForPortfolioCalculator({
public async getActivitiesForPortfolioCalculator({
filters,
userCurrency,
userId,
withCash = false
}: {
/** Optional filters to apply to the orders. */
/** Optional filters to apply to the activities. */
filters?: Filter[];
/** The base currency of the user. */
userCurrency: string;

2
apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-cash.spec.ts

@ -189,7 +189,7 @@ describe('PortfolioCalculator', () => {
});
const { activities } =
await activitiesService.getOrdersForPortfolioCalculator({
await activitiesService.getActivitiesForPortfolioCalculator({
userCurrency: 'CHF',
userId: userDummyData.id,
withCash: true

8
apps/api/src/app/portfolio/portfolio.service.ts

@ -406,7 +406,7 @@ export class PortfolioService {
const { endDate, startDate } = getIntervalFromDateRange(dateRange);
const { activities } =
await this.activitiesService.getOrdersForPortfolioCalculator({
await this.activitiesService.getActivitiesForPortfolioCalculator({
filters,
userCurrency,
userId
@ -490,7 +490,7 @@ export class PortfolioService {
);
const { activities } =
await this.activitiesService.getOrdersForPortfolioCalculator({
await this.activitiesService.getActivitiesForPortfolioCalculator({
filters,
userCurrency,
userId
@ -779,7 +779,7 @@ export class PortfolioService {
const userCurrency = this.getUserCurrency(user);
const { activities } =
await this.activitiesService.getOrdersForPortfolioCalculator({
await this.activitiesService.getActivitiesForPortfolioCalculator({
userCurrency,
userId
});
@ -1009,7 +1009,7 @@ export class PortfolioService {
userId,
userCurrency
}),
this.activitiesService.getOrdersForPortfolioCalculator({
this.activitiesService.getActivitiesForPortfolioCalculator({
filters,
userCurrency,
userId

2
apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.processor.ts

@ -47,7 +47,7 @@ export class PortfolioSnapshotProcessor {
);
const { activities } =
await this.activitiesService.getOrdersForPortfolioCalculator({
await this.activitiesService.getActivitiesForPortfolioCalculator({
filters: job.data.filters,
userCurrency: job.data.userCurrency,
userId: job.data.userId,

Loading…
Cancel
Save