topaLE
/
ghostfolio
mirror of https://github.com/ghostfolio/ghostfolio
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Refactor cd to changeDetectorRef

pull/118/head
Thomas 5 years ago
parent
0d6fe4a232
commit
9f69de0f49
16 changed files with 48 additions and 48 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      apps/client/src/app/app.component.ts
  2. 4
      apps/client/src/app/components/performance-chart-dialog/performance-chart-dialog.component.ts
  3. 4
      apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.component.ts
  4. 4
      apps/client/src/app/pages/about/about-page.component.ts
  5. 8
      apps/client/src/app/pages/account/account-page.component.ts
  6. 6
      apps/client/src/app/pages/accounts/accounts-page.component.ts
  7. 4
      apps/client/src/app/pages/admin/admin-page.component.ts
  8. 8
      apps/client/src/app/pages/analysis/analysis-page.component.ts
  9. 16
      apps/client/src/app/pages/home/home-page.component.ts
  10. 4
      apps/client/src/app/pages/login/login-page.component.ts
  11. 4
      apps/client/src/app/pages/login/show-access-token-dialog/show-access-token-dialog.component.ts
  12. 4
      apps/client/src/app/pages/pricing/pricing-page.component.ts
  13. 4
      apps/client/src/app/pages/report/report-page.component.ts
  14. 6
      apps/client/src/app/pages/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.component.ts
  15. 6
      apps/client/src/app/pages/transactions/transactions-page.component.ts
  16. 10
      apps/client/src/app/pages/zen/zen-page.component.ts

4
apps/client/src/app/app.component.ts
View File

@ -37,7 +37,7 @@ export class AppComponent implements OnDestroy, OnInit {
private unsubscribeSubject = new Subject<void>(); private unsubscribeSubject = new Subject<void>();
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
private deviceService: DeviceDetectorService, private deviceService: DeviceDetectorService,
private materialCssVarsService: MaterialCssVarsService, private materialCssVarsService: MaterialCssVarsService,
@ -80,7 +80,7 @@ export class AppComponent implements OnDestroy, OnInit {
this.user = null; this.user = null;
} }
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
} }

4
apps/client/src/app/components/performance-chart-dialog/performance-chart-dialog.component.ts
View File

@ -28,7 +28,7 @@ export class PerformanceChartDialog {
public title: string; public title: string;
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
public dialogRef: MatDialogRef<PerformanceChartDialog>, public dialogRef: MatDialogRef<PerformanceChartDialog>,
@Inject(MAT_DIALOG_DATA) public data: PositionDetailDialogParams @Inject(MAT_DIALOG_DATA) public data: PositionDetailDialogParams
@ -75,7 +75,7 @@ export class PerformanceChartDialog {
} }
}); });
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
this.title = `Performance vs. ${this.benchmarkLabel}`; this.title = `Performance vs. ${this.benchmarkLabel}`;

4
apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.component.ts
View File

@ -34,7 +34,7 @@ export class PositionDetailDialog {
public transactionCount: number; public transactionCount: number;
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
public dialogRef: MatDialogRef<PositionDetailDialog>, public dialogRef: MatDialogRef<PositionDetailDialog>,
@Inject(MAT_DIALOG_DATA) public data: PositionDetailDialogParams @Inject(MAT_DIALOG_DATA) public data: PositionDetailDialogParams
@ -127,7 +127,7 @@ export class PositionDetailDialog {
this.benchmarkDataItems[0].value = this.averagePrice; this.benchmarkDataItems[0].value = this.averagePrice;
} }
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
); );
} }

4
apps/client/src/app/pages/about/about-page.component.ts
View File

@ -25,7 +25,7 @@ export class AboutPageComponent implements OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private userService: UserService private userService: UserService
) {} ) {}
@ -39,7 +39,7 @@ export class AboutPageComponent implements OnInit {
if (state?.user) { if (state?.user) {
this.user = state.user; this.user = state.user;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
}); });
} }

8
apps/client/src/app/pages/account/account-page.component.ts
View File

@ -28,7 +28,7 @@ export class AccountPageComponent implements OnDestroy, OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
private userService: UserService private userService: UserService
) { ) {
@ -55,7 +55,7 @@ export class AccountPageComponent implements OnDestroy, OnInit {
permissions.updateUserSettings permissions.updateUserSettings
); );
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
}); });
} }
@ -85,7 +85,7 @@ export class AccountPageComponent implements OnDestroy, OnInit {
.subscribe((user) => { .subscribe((user) => {
this.user = user; this.user = user;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
}); });
} }
@ -102,7 +102,7 @@ export class AccountPageComponent implements OnDestroy, OnInit {
.subscribe((response) => { .subscribe((response) => {
this.accesses = response; this.accesses = response;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
} }
} }

6
apps/client/src/app/pages/accounts/accounts-page.component.ts
View File

@ -35,7 +35,7 @@ export class AccountsPageComponent implements OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
private deviceService: DeviceDetectorService, private deviceService: DeviceDetectorService,
private dialog: MatDialog, private dialog: MatDialog,
@ -90,7 +90,7 @@ export class AccountsPageComponent implements OnInit {
permissions.deleteAccount permissions.deleteAccount
); );
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
}); });
@ -105,7 +105,7 @@ export class AccountsPageComponent implements OnInit {
this.router.navigate([], { queryParams: { createDialog: true } }); this.router.navigate([], { queryParams: { createDialog: true } });
} }
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
} }

4
apps/client/src/app/pages/admin/admin-page.component.ts
View File

@ -32,7 +32,7 @@ export class AdminPageComponent implements OnInit {
public constructor( public constructor(
private adminService: AdminService, private adminService: AdminService,
private cacheService: CacheService, private cacheService: CacheService,
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
private userService: UserService private userService: UserService
) {} ) {}
@ -139,7 +139,7 @@ export class AdminPageComponent implements OnInit {
this.transactionCount = transactionCount; this.transactionCount = transactionCount;
this.userCount = userCount; this.userCount = userCount;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
); );
} }

8
apps/client/src/app/pages/analysis/analysis-page.component.ts
View File

@ -40,7 +40,7 @@ export class AnalysisPageComponent implements OnDestroy, OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
private deviceService: DeviceDetectorService, private deviceService: DeviceDetectorService,
private impersonationStorageService: ImpersonationStorageService, private impersonationStorageService: ImpersonationStorageService,
@ -66,7 +66,7 @@ export class AnalysisPageComponent implements OnDestroy, OnInit {
.subscribe((response) => { .subscribe((response) => {
this.portfolioItems = response; this.portfolioItems = response;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
this.dataService this.dataService
@ -76,7 +76,7 @@ export class AnalysisPageComponent implements OnDestroy, OnInit {
this.portfolioPositions = response; this.portfolioPositions = response;
this.initializeAnalysisData(this.portfolioPositions, this.period); this.initializeAnalysisData(this.portfolioPositions, this.period);
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
this.userService.stateChanged this.userService.stateChanged
@ -85,7 +85,7 @@ export class AnalysisPageComponent implements OnDestroy, OnInit {
if (state?.user) { if (state?.user) {
this.user = state.user; this.user = state.user;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
}); });
} }

16
apps/client/src/app/pages/home/home-page.component.ts
View File

@ -58,7 +58,7 @@ export class HomePageComponent implements OnDestroy, OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
private deviceService: DeviceDetectorService, private deviceService: DeviceDetectorService,
private dialog: MatDialog, private dialog: MatDialog,
@ -94,7 +94,7 @@ export class HomePageComponent implements OnDestroy, OnInit {
.subscribe(({ marketPrice }) => { .subscribe(({ marketPrice }) => {
this.fearAndGreedIndex = marketPrice; this.fearAndGreedIndex = marketPrice;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
} }
@ -103,7 +103,7 @@ export class HomePageComponent implements OnDestroy, OnInit {
permissions.readForeignPortfolio permissions.readForeignPortfolio
); );
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
}); });
} }
@ -169,7 +169,7 @@ export class HomePageComponent implements OnDestroy, OnInit {
}; };
}); });
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
this.dataService this.dataService
@ -178,14 +178,14 @@ export class HomePageComponent implements OnDestroy, OnInit {
this.performance = response; this.performance = response;
this.isLoadingPerformance = false; this.isLoadingPerformance = false;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
this.dataService.fetchPortfolioOverview().subscribe((response) => { this.dataService.fetchPortfolioOverview().subscribe((response) => {
this.overview = response; this.overview = response;
this.isLoadingOverview = false; this.isLoadingOverview = false;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
this.dataService this.dataService
@ -195,9 +195,9 @@ export class HomePageComponent implements OnDestroy, OnInit {
this.hasPositions = this.hasPositions =
this.positions && Object.keys(this.positions).length > 0; this.positions && Object.keys(this.positions).length > 0;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
} }

4
apps/client/src/app/pages/login/login-page.component.ts
View File

@ -26,7 +26,7 @@ export class LoginPageComponent implements OnDestroy, OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
private dialog: MatDialog, private dialog: MatDialog,
private router: Router, private router: Router,
@ -42,7 +42,7 @@ export class LoginPageComponent implements OnDestroy, OnInit {
this.initializeLineChart(); this.initializeLineChart();
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
} }

4
apps/client/src/app/pages/login/show-access-token-dialog/show-access-token-dialog.component.ts
View File

@ -16,7 +16,7 @@ export class ShowAccessTokenDialog {
public isAgreeButtonDisabled = true; public isAgreeButtonDisabled = true;
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
@Inject(MAT_DIALOG_DATA) public data: any @Inject(MAT_DIALOG_DATA) public data: any
) {} ) {}
@ -26,7 +26,7 @@ export class ShowAccessTokenDialog {
setTimeout(() => { setTimeout(() => {
this.isAgreeButtonDisabled = false; this.isAgreeButtonDisabled = false;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}, 1500); }, 1500);
} }
} }

4
apps/client/src/app/pages/pricing/pricing-page.component.ts
View File

@ -21,7 +21,7 @@ export class PricingPageComponent implements OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private userService: UserService private userService: UserService
) {} ) {}
@ -35,7 +35,7 @@ export class PricingPageComponent implements OnInit {
if (state?.user) { if (state?.user) {
this.user = state.user; this.user = state.user;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
}); });
} }

4
apps/client/src/app/pages/report/report-page.component.ts
View File

@ -20,7 +20,7 @@ export class ReportPageComponent implements OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService private dataService: DataService
) {} ) {}
@ -38,7 +38,7 @@ export class ReportPageComponent implements OnInit {
portfolioReport.rules['currencyClusterRisk'] || null; portfolioReport.rules['currencyClusterRisk'] || null;
this.feeRules = portfolioReport.rules['fees'] || null; this.feeRules = portfolioReport.rules['fees'] || null;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
} }

6
apps/client/src/app/pages/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.component.ts
View File

@ -42,7 +42,7 @@ export class CreateOrUpdateTransactionDialog {
private unsubscribeSubject = new Subject<void>(); private unsubscribeSubject = new Subject<void>();
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
public dialogRef: MatDialogRef<CreateOrUpdateTransactionDialog>, public dialogRef: MatDialogRef<CreateOrUpdateTransactionDialog>,
@Inject(MAT_DIALOG_DATA) public data: CreateOrUpdateTransactionDialogParams @Inject(MAT_DIALOG_DATA) public data: CreateOrUpdateTransactionDialogParams
@ -73,7 +73,7 @@ export class CreateOrUpdateTransactionDialog {
.pipe(takeUntil(this.unsubscribeSubject)) .pipe(takeUntil(this.unsubscribeSubject))
.subscribe(({ marketPrice }) => { .subscribe(({ marketPrice }) => {
this.currentMarketPrice = marketPrice; this.currentMarketPrice = marketPrice;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
} }
} }
@ -100,7 +100,7 @@ export class CreateOrUpdateTransactionDialog {
this.isLoading = false; this.isLoading = false;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
} }

6
apps/client/src/app/pages/transactions/transactions-page.component.ts
View File

@ -35,7 +35,7 @@ export class TransactionsPageComponent implements OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
private deviceService: DeviceDetectorService, private deviceService: DeviceDetectorService,
private dialog: MatDialog, private dialog: MatDialog,
@ -90,7 +90,7 @@ export class TransactionsPageComponent implements OnInit {
permissions.deleteOrder permissions.deleteOrder
); );
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
}); });
@ -105,7 +105,7 @@ export class TransactionsPageComponent implements OnInit {
this.router.navigate([], { queryParams: { createDialog: true } }); this.router.navigate([], { queryParams: { createDialog: true } });
} }
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
} }

10
apps/client/src/app/pages/zen/zen-page.component.ts
View File

@ -31,7 +31,7 @@ export class ZenPageComponent implements OnDestroy, OnInit {
* @constructor * @constructor
*/ */
public constructor( public constructor(
private cd: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private dataService: DataService, private dataService: DataService,
private deviceService: DeviceDetectorService, private deviceService: DeviceDetectorService,
private impersonationStorageService: ImpersonationStorageService, private impersonationStorageService: ImpersonationStorageService,
@ -48,7 +48,7 @@ export class ZenPageComponent implements OnDestroy, OnInit {
permissions.readForeignPortfolio permissions.readForeignPortfolio
); );
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
}); });
} }
@ -86,7 +86,7 @@ export class ZenPageComponent implements OnDestroy, OnInit {
}; };
}); });
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
this.dataService this.dataService
@ -95,9 +95,9 @@ export class ZenPageComponent implements OnDestroy, OnInit {
this.performance = response; this.performance = response;
this.isLoadingPerformance = false; this.isLoadingPerformance = false;
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
this.cd.markForCheck(); this.changeDetectorRef.markForCheck();
} }
} }

Write Preview
Loading…
Cancel
Save