Browse Source

chore: add security check to see if the accounts belong to user

pull/2455/head
Dhoni77 2 years ago
parent
commit
a3de7b670b
  1. 17
      apps/api/src/app/account/account.controller.ts

17
apps/api/src/app/account/account.controller.ts

@ -170,12 +170,27 @@ export class AccountController {
); );
} }
const currentAccountIds = (
await this.accountService.getAccounts(this.request.user.id)
).map((account) => account.id);
if (
![accountIdFrom, accountIdTo].every((id) =>
currentAccountIds.includes(id)
)
) {
throw new HttpException(
getReasonPhrase(StatusCodes.NOT_FOUND),
StatusCodes.NOT_FOUND
);
}
const today = resetHours(new Date()); const today = resetHours(new Date());
const userCurrency = this.request.user.Settings.settings.baseCurrency; const userCurrency = this.request.user.Settings.settings.baseCurrency;
await this.accountService.updateAccountBalance({ await this.accountService.updateAccountBalance({
accountId: accountIdFrom, accountId: accountIdFrom,
amount: balance, amount: -balance,
currency: userCurrency, currency: userCurrency,
date: today, date: today,
userId: this.request.user.id userId: this.request.user.id

Loading…
Cancel
Save