Remove performances from snapshot

apps/api/src/app/portfolio/calculator/portfolio-calculator.ts

@@ -159,16 +159,8 @@ export abstract class PortfolioCalculator {
     if (!transactionPoints.length) {
       return {
         currentValueInBaseCurrency: new Big(0),
-        grossPerformance: new Big(0),
-        grossPerformancePercentage: new Big(0),
-        grossPerformancePercentageWithCurrencyEffect: new Big(0),
-        grossPerformanceWithCurrencyEffect: new Big(0),
         hasErrors: false,
         historicalData: [],
-        netPerformance: new Big(0),
-        netPerformancePercentage: new Big(0),
-        netPerformancePercentageWithCurrencyEffect: new Big(0),
-        netPerformanceWithCurrencyEffect: new Big(0),
         positions: [],
         totalFeesWithCurrencyEffect: new Big(0),
         totalInterestWithCurrencyEffect: new Big(0),

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.ts

@@ -106,35 +106,13 @@ export class TWRPortfolioCalculator extends PortfolioCalculator {
 
     return {
       currentValueInBaseCurrency,
-      grossPerformance,
-      grossPerformanceWithCurrencyEffect,
       hasErrors,
-      netPerformance,
-      netPerformanceWithCurrencyEffect,
       positions,
       totalFeesWithCurrencyEffect,
       totalInterestWithCurrencyEffect,
       totalInvestment,
       totalInvestmentWithCurrencyEffect,
       historicalData: [],
-      netPerformancePercentage: totalTimeWeightedInvestment.eq(0)
-        ? new Big(0)
-        : netPerformance.div(totalTimeWeightedInvestment),
-      netPerformancePercentageWithCurrencyEffect:
-        totalTimeWeightedInvestmentWithCurrencyEffect.eq(0)
-          ? new Big(0)
-          : netPerformanceWithCurrencyEffect.div(
-              totalTimeWeightedInvestmentWithCurrencyEffect
-            ),
-      grossPerformancePercentage: totalTimeWeightedInvestment.eq(0)
-        ? new Big(0)
-        : grossPerformance.div(totalTimeWeightedInvestment),
-      grossPerformancePercentageWithCurrencyEffect:
-        totalTimeWeightedInvestmentWithCurrencyEffect.eq(0)
-          ? new Big(0)
-          : grossPerformanceWithCurrencyEffect.div(
-              totalTimeWeightedInvestmentWithCurrencyEffect
-            ),
       totalLiabilitiesWithCurrencyEffect: new Big(0),
       totalValuablesWithCurrencyEffect: new Big(0)
     };

apps/api/src/app/portfolio/portfolio.service.ts

@@ -1588,18 +1588,27 @@ export class PortfolioService {
       }
     }
 
+    const { currentValueInBaseCurrency, totalInvestment } =
+      await portfolioCalculator.getSnapshot();
+
+    const { performance } = await this.getPerformance({
+      impersonationId,
+      userId
+    });
+
+    console.log(performance);
+
     const {
-      currentValueInBaseCurrency,
+      // TODO
-      grossPerformance,
+      // grossPerformance,
-      grossPerformancePercentage,
+      // grossPerformancePercentage,
-      grossPerformancePercentageWithCurrencyEffect,
+      // grossPerformancePercentageWithCurrencyEffect,
-      grossPerformanceWithCurrencyEffect,
+      // grossPerformanceWithCurrencyEffect,
       netPerformance,
       netPerformancePercentage,
       netPerformancePercentageWithCurrencyEffect,
-      netPerformanceWithCurrencyEffect,
+      netPerformanceWithCurrencyEffect
-      totalInvestment
+    } = performance;
-    } = await portfolioCalculator.getSnapshot();
 
     const dividendInBaseCurrency =
       await portfolioCalculator.getDividendInBaseCurrency();
@@ -1696,6 +1705,10 @@ export class PortfolioService {
       cash,
       excludedAccountsAndActivities,
       firstOrderDate,
+      netPerformance,
+      netPerformancePercentage,
+      netPerformancePercentageWithCurrencyEffect,
+      netPerformanceWithCurrencyEffect,
       totalBuy,
       totalSell,
       committedFunds: committedFunds.toNumber(),
@@ -1716,21 +1729,14 @@ export class PortfolioService {
       fireWealth: new Big(currentValueInBaseCurrency)
         .minus(emergencyFundPositionsValueInBaseCurrency)
         .toNumber(),
-      grossPerformance: grossPerformance.toNumber(),
+      // TODO
-      grossPerformancePercentage: grossPerformancePercentage.toNumber(),
+      grossPerformance: 0,
-      grossPerformancePercentageWithCurrencyEffect:
+      grossPerformancePercentage: 0,
-        grossPerformancePercentageWithCurrencyEffect.toNumber(),
+      grossPerformancePercentageWithCurrencyEffect: 0,
-      grossPerformanceWithCurrencyEffect:
+      grossPerformanceWithCurrencyEffect: 0,
-        grossPerformanceWithCurrencyEffect.toNumber(),
       interest: interest.toNumber(),
       items: valuables.toNumber(),
       liabilities: liabilities.toNumber(),
-      netPerformance: netPerformance.toNumber(),
-      netPerformancePercentage: netPerformancePercentage.toNumber(),
-      netPerformancePercentageWithCurrencyEffect:
-        netPerformancePercentageWithCurrencyEffect.toNumber(),
-      netPerformanceWithCurrencyEffect:
-        netPerformanceWithCurrencyEffect.toNumber(),
       ordersCount: activities.filter(({ type }) => {
         return ['BUY', 'SELL'].includes(type);
       }).length,

libs/common/src/lib/models/portfolio-snapshot.ts

@@ -15,50 +15,10 @@ export class PortfolioSnapshot {
 
   errors?: AssetProfileIdentifier[];
 
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  grossPerformance: Big;
-
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  grossPerformanceWithCurrencyEffect: Big;
-
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  grossPerformancePercentage: Big;
-
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  grossPerformancePercentageWithCurrencyEffect: Big;
-
   hasErrors: boolean;
 
   historicalData: HistoricalDataItem[];
 
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  netAnnualizedPerformance?: Big;
-
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  netAnnualizedPerformanceWithCurrencyEffect?: Big;
-
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  netPerformance: Big;
-
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  netPerformanceWithCurrencyEffect: Big;
-
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  netPerformancePercentage: Big;
-
-  @Transform(transformToBig, { toClassOnly: true })
-  @Type(() => Big)
-  netPerformancePercentageWithCurrencyEffect: Big;
-
   @Type(() => TimelinePosition)
   positions: TimelinePosition[];