Browse Source

Fix accounts page (#1908)

* Add guards

* Update changelog
pull/1911/head
Thomas Kaul 2 years ago
committed by GitHub
parent
commit
a5f0f48ddb
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      CHANGELOG.md
  2. 11
      apps/api/src/app/portfolio/portfolio.service.ts

4
CHANGELOG.md

@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Split the environment variable `DATA_SOURCE_PRIMARY` in `DATA_SOURCE_EXCHANGE_RATES` and `DATA_SOURCE_IMPORT` - Split the environment variable `DATA_SOURCE_PRIMARY` in `DATA_SOURCE_EXCHANGE_RATES` and `DATA_SOURCE_IMPORT`
### Fixed
- Fixed the exception on the accounts page
## 1.262.0 - 2023-04-29 ## 1.262.0 - 2023-04-29
### Added ### Added

11
apps/api/src/app/portfolio/portfolio.service.ts

@ -466,9 +466,10 @@ export class PortfolioService {
cashDetails.balanceInBaseCurrency cashDetails.balanceInBaseCurrency
); );
const isFilteredByAccount = filters.some((filter) => { const isFilteredByAccount =
return filter.type === 'ACCOUNT'; filters?.some((filter) => {
}); return filter.type === 'ACCOUNT';
}) ?? false;
let filteredValueInBaseCurrency = isFilteredByAccount let filteredValueInBaseCurrency = isFilteredByAccount
? totalValueInBaseCurrency ? totalValueInBaseCurrency
@ -571,11 +572,11 @@ export class PortfolioService {
}; };
} }
const isFilteredByCash = filters.some((filter) => { const isFilteredByCash = filters?.some((filter) => {
return filter.type === 'ASSET_CLASS' && filter.id === 'CASH'; return filter.type === 'ASSET_CLASS' && filter.id === 'CASH';
}); });
if (filters.length === 0 || isFilteredByCash || isFilteredByAccount) { if (filters?.length === 0 || isFilteredByAccount || isFilteredByCash) {
const cashPositions = await this.getCashPositions({ const cashPositions = await this.getCashPositions({
cashDetails, cashDetails,
userCurrency, userCurrency,

Loading…
Cancel
Save