Browse Source

Improve usability by collapsing breakdowns

pull/7536/head
Thomas Kaul 4 weeks ago
parent
commit
aa02a45962
  1. 8
      apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html
  2. 4
      apps/client/src/app/components/portfolio-summary/portfolio-summary.component.scss
  3. 4
      apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts

8
apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html

@ -170,7 +170,9 @@
(click)="onToggleHoldings()" (click)="onToggleHoldings()"
> >
@if (hasHoldingsBreakdown) { @if (hasHoldingsBreakdown) {
<span class="caret-container"> <span
class="align-items-center caret-container d-inline-flex justify-content-center ml-n3"
>
<ion-icon <ion-icon
class="caret text-muted" class="caret text-muted"
name="caret-forward-outline" name="caret-forward-outline"
@ -242,7 +244,9 @@
(click)="onToggleCash()" (click)="onToggleCash()"
> >
@if (hasCashBreakdown) { @if (hasCashBreakdown) {
<span class="caret-container"> <span
class="align-items-center caret-container d-inline-flex justify-content-center ml-n3"
>
<ion-icon <ion-icon
class="caret text-muted" class="caret text-muted"
name="caret-forward-outline" name="caret-forward-outline"

4
apps/client/src/app/components/portfolio-summary/portfolio-summary.component.scss

@ -2,10 +2,6 @@
display: block; display: block;
.caret-container { .caret-container {
align-items: center;
display: inline-flex;
justify-content: center;
margin-left: -1rem;
width: 1rem; width: 1rem;
.caret { .caret {

4
apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts

@ -85,11 +85,11 @@ export class GfPortfolioSummaryComponent implements OnChanges {
} }
protected get hasCashBreakdown() { protected get hasCashBreakdown() {
return this.isLoading || this.summary?.emergencyFund?.cash > 0; return !this.isLoading && this.summary?.emergencyFund?.cash > 0;
} }
protected get hasHoldingsBreakdown() { protected get hasHoldingsBreakdown() {
return this.isLoading || this.summary?.emergencyFund?.assets > 0; return !this.isLoading && this.summary?.emergencyFund?.assets > 0;
} }
protected get holdingsInBaseCurrency() { protected get holdingsInBaseCurrency() {

Loading…
Cancel
Save