Browse Source

Refactoring

pull/2159/head
Thomas 2 years ago
parent
commit
b2755ccddd
  1. 2
      apps/api/src/app/portfolio/portfolio.controller.ts
  2. 11
      apps/api/src/app/portfolio/portfolio.service.ts
  3. 28
      apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html
  4. 2
      apps/client/src/app/pages/portfolio/fire/fire-page.component.ts
  5. 9
      libs/common/src/lib/interfaces/portfolio-summary.interface.ts

2
apps/api/src/app/portfolio/portfolio.controller.ts

@ -161,10 +161,12 @@ export class PortfolioController {
'emergencyFund', 'emergencyFund',
'excludedAccountsAndActivities', 'excludedAccountsAndActivities',
'fees', 'fees',
'fireWealth',
'items', 'items',
'liabilities', 'liabilities',
'netWorth', 'netWorth',
'totalBuy', 'totalBuy',
'totalInvestment',
'totalSell' 'totalSell'
]); ]);
} }

11
apps/api/src/app/portfolio/portfolio.service.ts

@ -1679,9 +1679,14 @@ export class PortfolioService {
totalBuy, totalBuy,
totalSell, totalSell,
committedFunds: committedFunds.toNumber(), committedFunds: committedFunds.toNumber(),
emergencyFund: emergencyFund.toNumber(), emergencyFund: {
emergencyFundinAssets: emergencyFundPositionsValueInBaseCurrency, assets: emergencyFundPositionsValueInBaseCurrency,
emergencyFundInCash: emergencyFund cash: emergencyFund
.minus(emergencyFundPositionsValueInBaseCurrency)
.toNumber(),
total: emergencyFund.toNumber()
},
fireWealth: new Big(performanceInformation.performance.currentValue)
.minus(emergencyFundPositionsValueInBaseCurrency) .minus(emergencyFundPositionsValueInBaseCurrency)
.toNumber(), .toNumber(),
ordersCount: activities.filter(({ type }) => { ordersCount: activities.filter(({ type }) => {

28
apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html

@ -163,7 +163,33 @@
[isCurrency]="true" [isCurrency]="true"
[locale]="locale" [locale]="locale"
[unit]="baseCurrency" [unit]="baseCurrency"
[value]="isLoading ? undefined : summary?.emergencyFund" [value]="isLoading ? undefined : summary?.emergencyFund?.total"
></gf-value>
</div>
</div>
<div class="flex-nowrap px-3 py-1 row">
<div class="flex-grow-1 ml-3 text-truncate" i18n>Cash</div>
<div class="flex-column flex-wrap justify-content-end">
<gf-value
class="justify-content-end"
position="end"
[isCurrency]="true"
[locale]="locale"
[unit]="baseCurrency"
[value]="isLoading ? undefined : summary?.emergencyFund?.cash"
></gf-value>
</div>
</div>
<div class="flex-nowrap px-3 py-1 row">
<div class="flex-grow-1 ml-3 text-truncate" i18n>Assets</div>
<div class="flex-column flex-wrap justify-content-end">
<gf-value
class="justify-content-end"
position="end"
[isCurrency]="true"
[locale]="locale"
[unit]="baseCurrency"
[value]="isLoading ? undefined : summary?.emergencyFund?.assets"
></gf-value> ></gf-value>
</div> </div>
</div> </div>

2
apps/client/src/app/pages/portfolio/fire/fire-page.component.ts

@ -51,7 +51,7 @@ export class FirePageComponent implements OnDestroy, OnInit {
return; return;
} }
this.fireWealth = new Big(summary.currentValue); this.fireWealth = new Big(summary.fireWealth);
this.withdrawalRatePerYear = this.fireWealth.mul(4).div(100); this.withdrawalRatePerYear = this.fireWealth.mul(4).div(100);
this.withdrawalRatePerMonth = this.withdrawalRatePerYear.div(12); this.withdrawalRatePerMonth = this.withdrawalRatePerYear.div(12);

9
libs/common/src/lib/interfaces/portfolio-summary.interface.ts

@ -5,11 +5,14 @@ export interface PortfolioSummary extends PortfolioPerformance {
cash: number; cash: number;
committedFunds: number; committedFunds: number;
dividend: number; dividend: number;
emergencyFund: number; emergencyFund: {
emergencyFundInCash: number; assets: number;
emergencyFundinAssets: number; cash: number;
total: number;
};
excludedAccountsAndActivities: number; excludedAccountsAndActivities: number;
fees: number; fees: number;
fireWealth: number;
firstOrderDate: Date; firstOrderDate: Date;
items: number; items: number;
liabilities: number; liabilities: number;

Loading…
Cancel
Save