Refactoring

apps/api/src/app/portfolio/portfolio-calculator.ts

@@ -776,70 +776,75 @@ export class PortfolioCalculator {
     let lastDate: string = null;
     let lastTransactionPoint: TransactionPoint = null;
 
-    for (const order of this.orders) {
+    for (const {
-      const currentDate = order.date;
+      fee,
-
+      date,
+      quantity,
+      SymbolProfile,
+      tags,
+      type,
+      unitPrice
+    } of this.orders) {
       let currentTransactionPointItem: TransactionPointSymbol;
-      const oldAccumulatedSymbol = symbols[order.SymbolProfile.symbol];
+      const oldAccumulatedSymbol = symbols[SymbolProfile.symbol];
 
-      const factor = getFactor(order.type);
+      const factor = getFactor(type);
 
       if (oldAccumulatedSymbol) {
         let investment = oldAccumulatedSymbol.investment;
 
-        const newQuantity = order.quantity
+        const newQuantity = quantity
           .mul(factor)
           .plus(oldAccumulatedSymbol.quantity);
 
-        if (order.type === 'BUY') {
+        if (type === 'BUY') {
           investment = oldAccumulatedSymbol.investment.plus(
-            order.quantity.mul(order.unitPrice)
+            quantity.mul(unitPrice)
           );
-        } else if (order.type === 'SELL') {
+        } else if (type === 'SELL') {
           investment = oldAccumulatedSymbol.investment.minus(
-            order.quantity.mul(oldAccumulatedSymbol.averagePrice)
+            quantity.mul(oldAccumulatedSymbol.averagePrice)
           );
         }
 
         currentTransactionPointItem = {
           investment,
+          tags,
           averagePrice: newQuantity.gt(0)
             ? investment.div(newQuantity)
             : new Big(0),
-          currency: order.SymbolProfile.currency,
+          currency: SymbolProfile.currency,
-          dataSource: order.SymbolProfile.dataSource,
+          dataSource: SymbolProfile.dataSource,
           dividend: new Big(0),
-          fee: order.fee.plus(oldAccumulatedSymbol.fee),
+          fee: fee.plus(oldAccumulatedSymbol.fee),
           firstBuyDate: oldAccumulatedSymbol.firstBuyDate,
           quantity: newQuantity,
-          symbol: order.SymbolProfile.symbol,
+          symbol: SymbolProfile.symbol,
-          tags: order.tags,
           transactionCount: oldAccumulatedSymbol.transactionCount + 1
         };
       } else {
         currentTransactionPointItem = {
-          averagePrice: order.unitPrice,
+          fee,
-          currency: order.SymbolProfile.currency,
+          tags,
-          dataSource: order.SymbolProfile.dataSource,
+          averagePrice: unitPrice,
+          currency: SymbolProfile.currency,
+          dataSource: SymbolProfile.dataSource,
           dividend: new Big(0),
-          fee: order.fee,
+          firstBuyDate: date,
-          firstBuyDate: order.date,
+          investment: unitPrice.mul(quantity).mul(factor),
-          investment: order.unitPrice.mul(order.quantity).mul(factor),
+          quantity: quantity.mul(factor),
-          quantity: order.quantity.mul(factor),
+          symbol: SymbolProfile.symbol,
-          symbol: order.SymbolProfile.symbol,
-          tags: order.tags,
           transactionCount: 1
         };
       }
 
-      symbols[order.SymbolProfile.symbol] = currentTransactionPointItem;
+      symbols[SymbolProfile.symbol] = currentTransactionPointItem;
 
       const items = lastTransactionPoint?.items ?? [];
 
-      const newItems = items.filter(
+      const newItems = items.filter(({ symbol }) => {
-        (transactionPointItem) =>
+        return symbol !== SymbolProfile.symbol;
-          transactionPointItem.symbol !== order.SymbolProfile.symbol
+      });
-      );
 
       newItems.push(currentTransactionPointItem);
 
@@ -847,9 +852,9 @@ export class PortfolioCalculator {
         return a.symbol?.localeCompare(b.symbol);
       });
 
-      if (lastDate !== currentDate || lastTransactionPoint === null) {
+      if (lastDate !== date || lastTransactionPoint === null) {
         lastTransactionPoint = {
-          date: currentDate,
+          date,
           items: newItems
         };
 
@@ -858,7 +863,7 @@ export class PortfolioCalculator {
         lastTransactionPoint.items = newItems;
       }
 
-      lastDate = currentDate;
+      lastDate = date;
     }
   }