Refactoring

apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts

@@ -493,24 +493,30 @@ export class AllocationsPageComponent implements OnDestroy, OnInit {
           parents: Object.entries(this.portfolioDetails.holdings)
             .map(([symbol, holding]) => {
               if (holding.holdings.length > 0) {
-                const parentHolding = holding.holdings.find((parentHolding) => {
+                const currentParentHolding = holding.holdings.find(
+                  (parentHolding) => {
                     return parentHolding.name === name;
-                });
+                  }
-                return parentHolding
+                );
+
+                return currentParentHolding
                   ? {
                       allocationInPercentage:
-                        parentHolding.valueInBaseCurrency / value,
+                        currentParentHolding.valueInBaseCurrency / value,
                       name: holding.name,
                       position: holding,
                       symbol: prettifySymbol(symbol),
-                      valueInBaseCurrency: parentHolding.valueInBaseCurrency
+                      valueInBaseCurrency:
+                        currentParentHolding.valueInBaseCurrency
                     }
                   : null;
               }
 
               return null;
             })
-            .filter((item) => null !== item)
+            .filter((item) => {
+              return item !== null;
+            })
             .sort((a, b) => {
               return b.allocationInPercentage - a.allocationInPercentage;
             }),

libs/ui/src/lib/top-holdings/top-holdings.component.html

@@ -3,7 +3,6 @@
     class="gf-table holdings-table w-100"
     mat-table
     multiTemplateDataRows
-    style="table-layout: auto"
     [dataSource]="dataSource"
   >
     <colgroup>
@@ -116,8 +115,8 @@
               ></tr>
               <tr
                 *matFooterRowDef="displayedColumns"
+                class="hidden"
                 mat-footer-row
-                style="visibility: hidden"
               ></tr>
             </table>
           </div>

libs/ui/src/lib/top-holdings/top-holdings.component.scss

@@ -2,6 +2,8 @@
   display: block;
 
   .holdings-table {
+    table-layout: auto;
+
     tr {
       &:not(.expanded) + tr.holding-detail td {
         border-bottom: 0;