address pr comments

apps/api/src/app/user/update-user-setting.dto.ts

@@ -89,9 +89,6 @@ export class UpdateUserSettingDto {
   @IsOptional()
   locale?: string;
 
-  @IsOptional()
-  portfolioSettings?: PortfolioReportRule['settings'];
-
   @IsNumber()
   @IsOptional()
   projectedTotalAmount?: number;

apps/client/src/app/components/rule/rule-settings-dialog/rule-settings-dialog.html

@@ -31,11 +31,7 @@
 
 <div align="end" mat-dialog-actions>
   <button i18n mat-button (click)="dialogRef.close()">Close</button>
-  <button
-    color="primary"
-    mat-flat-button
-    (click)="dialogRef.close({ settings })"
-  >
+  <button color="primary" mat-flat-button (click)="dialogRef.close(settings)">
     <ng-container i18n>Save</ng-container>
   </button>
 </div>

apps/client/src/app/components/rule/rule.component.ts

@@ -55,18 +55,17 @@ export class RuleComponent implements OnInit {
     dialogRef
       .afterClosed()
       .pipe(takeUntil(this.unsubscribeSubject))
-      .subscribe(
-        ({ settings }: { settings: PortfolioReportRule['settings'] }) => {
+      .subscribe((settings: PortfolioReportRule['settings']) => {
         if (settings) {
           const updatedSettings: UpdateUserSettingDto = {
-              portfolioSettings: {
-                ...settings
+            xRayRules: {
+              [rule.key]: settings
             }
           };
+
           this.ruleUpdated.emit(updatedSettings);
         }
-        }
-      );
+      });
   }
 
   public onUpdateRule(rule: PortfolioReportRule) {

libs/common/src/lib/types/x-ray-rules-settings.type.ts

@@ -1,3 +1,5 @@
+import { PortfolioReportRule } from '../interfaces';
+
 export type XRayRulesSettings = {
   AccountClusterRiskCurrentInvestment?: RuleSettings;
   AccountClusterRiskSingleAccount?: RuleSettings;
@@ -7,6 +9,6 @@ export type XRayRulesSettings = {
   FeeRatioInitialInvestment?: RuleSettings;
 };
 
-interface RuleSettings {
+interface RuleSettings extends Pick<PortfolioReportRule, 'settings'> {
   isActive: boolean;
 }