feat(client): enforce immutability

apps/client/src/app/pages/accounts/transfer-balance/transfer-balance-dialog.component.ts

@@ -42,31 +42,26 @@ import {
   templateUrl: 'transfer-balance-dialog.html'
 })
 export class GfTransferBalanceDialogComponent {
-  protected accounts: Account[] = [];
+  protected readonly accounts: Account[] =
+    inject<TransferBalanceDialogParams>(MAT_DIALOG_DATA).accounts;
+
   protected currency: string;
-  protected transferBalanceForm: TransferBalanceForm;
 
-  private readonly data = inject<TransferBalanceDialogParams>(MAT_DIALOG_DATA);
+  protected readonly transferBalanceForm: TransferBalanceForm = new FormGroup(
+    {
+      balance: new FormControl<number | string | null>('', Validators.required),
+      fromAccount: new FormControl<string | null>('', Validators.required),
+      toAccount: new FormControl<string | null>('', Validators.required)
+    },
+    {
+      validators: this.compareAccounts
+    }
+  );
+
   private readonly dialogRef =
     inject<MatDialogRef<GfTransferBalanceDialogComponent>>(MatDialogRef);
 
   public ngOnInit() {
-    this.accounts = this.data.accounts;
-
-    this.transferBalanceForm = new FormGroup(
-      {
-        balance: new FormControl<number | string | null>(
-          '',
-          Validators.required
-        ),
-        fromAccount: new FormControl<string | null>('', Validators.required),
-        toAccount: new FormControl<string | null>('', Validators.required)
-      },
-      {
-        validators: this.compareAccounts
-      }
-    );
-
     this.transferBalanceForm.controls.fromAccount.valueChanges.subscribe(
       (id) => {
         const currency = this.accounts.find((account) => {