Browse Source

Bugfix/handling of values rounding to zero in twitter bot (#7210)

* Fix handling of values rounding to zero

* Update changelog
pull/7211/head
Thomas Kaul 2 weeks ago
committed by GitHub
parent
commit
c0b6a2f95a
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 4
      CHANGELOG.md
  2. 17
      apps/api/src/services/twitter-bot/twitter-bot.service.ts

4
CHANGELOG.md

@ -21,6 +21,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the language localization for Ukrainian (`uk`) - Improved the language localization for Ukrainian (`uk`)
- Upgraded `yahoo-finance2` from version `3.14.3` to `3.15.4` - Upgraded `yahoo-finance2` from version `3.14.3` to `3.15.4`
### Fixed
- Fixed the market condition of the benchmarks in the twitter bot service when values round to zero
## 3.19.1 - 2026-07-03 ## 3.19.1 - 2026-07-03
### Added ### Added

17
apps/api/src/services/twitter-bot/twitter-bot.service.ts

@ -12,6 +12,7 @@ import {
import { Injectable, Logger, OnModuleInit } from '@nestjs/common'; import { Injectable, Logger, OnModuleInit } from '@nestjs/common';
import { isWeekend } from 'date-fns'; import { isWeekend } from 'date-fns';
import { round } from 'lodash';
import { TwitterApi, TwitterApiReadWrite } from 'twitter-api-v2'; import { TwitterApi, TwitterApiReadWrite } from 'twitter-api-v2';
@Injectable() @Injectable()
@ -89,16 +90,16 @@ export class TwitterBotService implements OnModuleInit {
}); });
return benchmarks return benchmarks
.map(({ marketCondition, name, performances }) => { .map(({ name, performances }) => {
let changeFormAllTimeHigh = ( const performancePercent = round(
performances.allTimeHigh.performancePercent * 100 performances.allTimeHigh.performancePercent,
).toFixed(1); 3
);
if (Math.abs(parseFloat(changeFormAllTimeHigh)) === 0) { const marketCondition =
changeFormAllTimeHigh = '0.0'; this.benchmarkService.getMarketCondition(performancePercent);
}
return `${name} ${changeFormAllTimeHigh}%${ return `${name} ${(performancePercent * 100).toFixed(1)}%${
marketCondition !== 'NEUTRAL_MARKET' marketCondition !== 'NEUTRAL_MARKET'
? ' ' + resolveMarketCondition(marketCondition).emoji ? ' ' + resolveMarketCondition(marketCondition).emoji
: '' : ''

Loading…
Cancel
Save