Browse Source
Bugfix/handling of values rounding to zero in twitter bot (#7210)
* Fix handling of values rounding to zero
* Update changelog
pull/7211/head
Thomas Kaul
2 weeks ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with
13 additions and
8 deletions
-
CHANGELOG.md
-
apps/api/src/services/twitter-bot/twitter-bot.service.ts
|
|
|
@ -21,6 +21,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
- Improved the language localization for Ukrainian (`uk`) |
|
|
|
- Upgraded `yahoo-finance2` from version `3.14.3` to `3.15.4` |
|
|
|
|
|
|
|
### Fixed |
|
|
|
|
|
|
|
- Fixed the market condition of the benchmarks in the twitter bot service when values round to zero |
|
|
|
|
|
|
|
## 3.19.1 - 2026-07-03 |
|
|
|
|
|
|
|
### Added |
|
|
|
|
|
|
|
@ -12,6 +12,7 @@ import { |
|
|
|
|
|
|
|
import { Injectable, Logger, OnModuleInit } from '@nestjs/common'; |
|
|
|
import { isWeekend } from 'date-fns'; |
|
|
|
import { round } from 'lodash'; |
|
|
|
import { TwitterApi, TwitterApiReadWrite } from 'twitter-api-v2'; |
|
|
|
|
|
|
|
@Injectable() |
|
|
|
@ -89,16 +90,16 @@ export class TwitterBotService implements OnModuleInit { |
|
|
|
}); |
|
|
|
|
|
|
|
return benchmarks |
|
|
|
.map(({ marketCondition, name, performances }) => { |
|
|
|
let changeFormAllTimeHigh = ( |
|
|
|
performances.allTimeHigh.performancePercent * 100 |
|
|
|
).toFixed(1); |
|
|
|
.map(({ name, performances }) => { |
|
|
|
const performancePercent = round( |
|
|
|
performances.allTimeHigh.performancePercent, |
|
|
|
3 |
|
|
|
); |
|
|
|
|
|
|
|
if (Math.abs(parseFloat(changeFormAllTimeHigh)) === 0) { |
|
|
|
changeFormAllTimeHigh = '0.0'; |
|
|
|
} |
|
|
|
const marketCondition = |
|
|
|
this.benchmarkService.getMarketCondition(performancePercent); |
|
|
|
|
|
|
|
return `${name} ${changeFormAllTimeHigh}%${ |
|
|
|
return `${name} ${(performancePercent * 100).toFixed(1)}%${ |
|
|
|
marketCondition !== 'NEUTRAL_MARKET' |
|
|
|
? ' ' + resolveMarketCondition(marketCondition).emoji |
|
|
|
: '' |
|
|
|
|