Browse Source

Bugfix/loading state of accounts table on accounts page (#7787)

* Fix loading state of accounts table

* Update changelog
pull/7788/head^2
Thomas Kaul 1 week ago
committed by GitHub
parent
commit
c5139e9ab3
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 6
      CHANGELOG.md
  2. 2
      apps/client/src/app/pages/accounts/accounts-page.html
  3. 4
      libs/ui/src/lib/accounts-table/accounts-table.component.ts

6
CHANGELOG.md

@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## Unreleased
### Fixed
- Fixed the loading state of the accounts table on the accounts page
## 3.65.0 - 2026-08-31 ## 3.65.0 - 2026-08-31
### Added ### Added

2
apps/client/src/app/pages/accounts/accounts-page.html

@ -3,7 +3,7 @@
<div class="col"> <div class="col">
<h1 class="d-none d-sm-block h3 mb-4 text-center" i18n>Accounts</h1> <h1 class="d-none d-sm-block h3 mb-4 text-center" i18n>Accounts</h1>
<gf-accounts-table <gf-accounts-table
[accounts]="accounts ?? []" [accounts]="accounts"
[activitiesCount]="activitiesCount" [activitiesCount]="activitiesCount"
[baseCurrency]="user?.settings?.baseCurrency" [baseCurrency]="user?.settings?.baseCurrency"
[hasPermissionToDeleteAccount]="hasPermissionToDeleteAccount" [hasPermissionToDeleteAccount]="hasPermissionToDeleteAccount"

4
libs/ui/src/lib/accounts-table/accounts-table.component.ts

@ -56,7 +56,7 @@ import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
templateUrl: './accounts-table.component.html' templateUrl: './accounts-table.component.html'
}) })
export class GfAccountsTableComponent { export class GfAccountsTableComponent {
public readonly accounts = input.required<AccountWithValue[]>(); public readonly accounts = input.required<AccountWithValue[] | undefined>();
public readonly activitiesCount = input<number>(); public readonly activitiesCount = input<number>();
public readonly baseCurrency = input<string>(); public readonly baseCurrency = input<string>();
public readonly hasPermissionToDeleteAccount = input<boolean>(); public readonly hasPermissionToDeleteAccount = input<boolean>();
@ -159,7 +159,7 @@ export class GfAccountsTableComponent {
// Reactive data update // Reactive data update
effect(() => { effect(() => {
this.dataSource.data = this.accounts(); this.dataSource.data = this.accounts() ?? [];
}); });
// Reactive view connection // Reactive view connection

Loading…
Cancel
Save