Browse Source

fix(ui): widen input types in portfolio proportion chart component

pull/7954/head
KenTandrian 2 days ago
parent
commit
c794465d53
  1. 16
      libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts

16
libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts

@ -1,5 +1,5 @@
import { getTooltipOptions } from '@ghostfolio/common/chart-helper'; import { getTooltipOptions } from '@ghostfolio/common/chart-helper';
import { UNKNOWN_KEY } from '@ghostfolio/common/config'; import { DEFAULT_COLOR_SCHEME, UNKNOWN_KEY } from '@ghostfolio/common/config';
import { getLocale, getSum, getTextColor } from '@ghostfolio/common/helper'; import { getLocale, getSum, getTextColor } from '@ghostfolio/common/helper';
import { PortfolioPosition } from '@ghostfolio/common/interfaces'; import { PortfolioPosition } from '@ghostfolio/common/interfaces';
import { ColorScheme } from '@ghostfolio/common/types'; import { ColorScheme } from '@ghostfolio/common/types';
@ -60,8 +60,8 @@ const {
export class GfPortfolioProportionChartComponent export class GfPortfolioProportionChartComponent
implements AfterViewInit, OnChanges, OnDestroy implements AfterViewInit, OnChanges, OnDestroy
{ {
@Input() baseCurrency: string; @Input() baseCurrency?: string = '';
@Input() colorScheme: ColorScheme; @Input() colorScheme?: ColorScheme = DEFAULT_COLOR_SCHEME;
@Input() cursor: string; @Input() cursor: string;
@Input() data: { @Input() data: {
[symbol: string]: Pick<PortfolioPosition, 'type'> & { [symbol: string]: Pick<PortfolioPosition, 'type'> & {
@ -71,9 +71,9 @@ export class GfPortfolioProportionChartComponent
value: number; value: number;
}; };
} = {}; } = {};
@Input() isInPercentage = false; @Input() isInPercentage?: boolean = false;
@Input() keys: string[] = []; @Input() keys: string[] = [];
@Input() locale = getLocale(); @Input() locale?: string = getLocale();
@Input() maxItems?: number; @Input() maxItems?: number;
@Input() showLabels = false; @Input() showLabels = false;
@ -123,8 +123,8 @@ export class GfPortfolioProportionChartComponent
}; };
} = {}; } = {};
this.colorMap = { this.colorMap = {
[this.OTHER_KEY]: `rgba(${getTextColor(this.colorScheme)}, 0.24)`, [this.OTHER_KEY]: `rgba(${getTextColor(this.colorScheme ?? DEFAULT_COLOR_SCHEME)}, 0.24)`,
[UNKNOWN_KEY]: `rgba(${getTextColor(this.colorScheme)}, 0.12)` [UNKNOWN_KEY]: `rgba(${getTextColor(this.colorScheme ?? DEFAULT_COLOR_SCHEME)}, 0.12)`
}; };
if (this.keys.length > 0) { if (this.keys.length > 0) {
@ -444,7 +444,7 @@ export class GfPortfolioProportionChartComponent
): Partial<TooltipOptions<'doughnut'>> { ): Partial<TooltipOptions<'doughnut'>> {
return { return {
...getTooltipOptions({ ...getTooltipOptions({
colorScheme: this.colorScheme, colorScheme: this.colorScheme ?? DEFAULT_COLOR_SCHEME,
currency: this.baseCurrency, currency: this.baseCurrency,
locale: this.locale locale: this.locale
}), }),

Loading…
Cancel
Save