Browse Source
Task/remove unused OnDestroy hook in changelog page component (#6373)
* Remove unused OnDestroy hook
pull/6348/head
Thomas Kaul
6 days ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with
2 additions and
10 deletions
-
apps/client/src/app/pages/about/changelog/changelog-page.component.ts
|
|
@ -1,7 +1,6 @@ |
|
|
import { Component, OnDestroy } from '@angular/core'; |
|
|
import { Component } from '@angular/core'; |
|
|
import { MarkdownModule } from 'ngx-markdown'; |
|
|
import { MarkdownModule } from 'ngx-markdown'; |
|
|
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; |
|
|
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; |
|
|
import { Subject } from 'rxjs'; |
|
|
|
|
|
|
|
|
|
|
|
@Component({ |
|
|
@Component({ |
|
|
imports: [MarkdownModule, NgxSkeletonLoaderModule], |
|
|
imports: [MarkdownModule, NgxSkeletonLoaderModule], |
|
|
@ -9,17 +8,10 @@ import { Subject } from 'rxjs'; |
|
|
styleUrls: ['./changelog-page.scss'], |
|
|
styleUrls: ['./changelog-page.scss'], |
|
|
templateUrl: './changelog-page.html' |
|
|
templateUrl: './changelog-page.html' |
|
|
}) |
|
|
}) |
|
|
export class GfChangelogPageComponent implements OnDestroy { |
|
|
export class GfChangelogPageComponent { |
|
|
public isLoading = true; |
|
|
public isLoading = true; |
|
|
|
|
|
|
|
|
private unsubscribeSubject = new Subject<void>(); |
|
|
|
|
|
|
|
|
|
|
|
public onLoad() { |
|
|
public onLoad() { |
|
|
this.isLoading = false; |
|
|
this.isLoading = false; |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
public ngOnDestroy() { |
|
|
|
|
|
this.unsubscribeSubject.next(); |
|
|
|
|
|
this.unsubscribeSubject.complete(); |
|
|
|
|
|
} |
|
|
|
|
|
} |
|
|
} |
|
|
|