Browse Source

Improve symbol validation for assets with manual data source

pull/7467/head
Thomas Kaul 4 weeks ago
parent
commit
c8d7abb8fa
  1. 2
      apps/api/src/app/import/import.service.ts
  2. 11
      apps/api/src/services/data-provider/data-provider.service.ts

2
apps/api/src/app/import/import.service.ts

@ -494,7 +494,7 @@ export class ImportService {
if ( if (
assetProfile.dataSource === DataSource.MANUAL && assetProfile.dataSource === DataSource.MANUAL &&
Boolean(assetProfile.name) assetProfile.name
) { ) {
existingCustomAssetProfilesOfUser.push({ existingCustomAssetProfilesOfUser.push({
name: assetProfile.name, name: assetProfile.name,

11
apps/api/src/services/data-provider/data-provider.service.ts

@ -9,7 +9,6 @@ import { PropertyService } from '@ghostfolio/api/services/property/property.serv
import { import {
DEFAULT_CURRENCY, DEFAULT_CURRENCY,
DERIVED_CURRENCIES, DERIVED_CURRENCIES,
ghostfolioPrefix,
PROPERTY_API_KEY_GHOSTFOLIO, PROPERTY_API_KEY_GHOSTFOLIO,
PROPERTY_DATA_SOURCE_MAPPING PROPERTY_DATA_SOURCE_MAPPING
} from '@ghostfolio/common/config'; } from '@ghostfolio/common/config';
@ -22,7 +21,6 @@ import {
getStartOfUtcDate, getStartOfUtcDate,
isCurrency, isCurrency,
isDerivedCurrency, isDerivedCurrency,
isValidCustomAssetProfileSymbol,
isValidSearchQuery isValidSearchQuery
} from '@ghostfolio/common/helper'; } from '@ghostfolio/common/helper';
import { import {
@ -268,15 +266,6 @@ export class DataProviderService implements OnModuleInit {
}); });
if (!assetProfiles[assetProfileIdentifier]) { if (!assetProfiles[assetProfileIdentifier]) {
if (
dataSource === DataSource.MANUAL &&
!isValidCustomAssetProfileSymbol(symbol)
) {
throw new Error(
`${activityPath}.symbol ("${symbol}") must be a UUID or start with the prefix "${ghostfolioPrefix}_" for the data source ("${DataSource.MANUAL}")`
);
}
if ( if (
(dataSource === DataSource.MANUAL && type === 'BUY') || (dataSource === DataSource.MANUAL && type === 'BUY') ||
['FEE', 'INTEREST', 'LIABILITY'].includes(type) ['FEE', 'INTEREST', 'LIABILITY'].includes(type)

Loading…
Cancel
Save