resolve comments

apps/api/src/app/endpoints/benchmarks/benchmarks.controller.ts

@@ -5,7 +5,10 @@ import { TransformDataSourceInResponseInterceptor } from '@ghostfolio/api/interc
 import { ApiService } from '@ghostfolio/api/services/api/api.service';
 import { BenchmarkService } from '@ghostfolio/api/services/benchmark/benchmark.service';
 import { getIntervalFromDateRange } from '@ghostfolio/common/calculation-helper';
-import { HEADER_KEY_IMPERSONATION } from '@ghostfolio/common/config';
+import {
+  DEFAULT_DATE_RANGE,
+  HEADER_KEY_IMPERSONATION
+} from '@ghostfolio/common/config';
 import type {
   AssetProfileIdentifier,
   BenchmarkMarketDataDetailsResponse,
@@ -118,7 +121,7 @@ export class BenchmarksController {
     @Param('dataSource') dataSource: DataSource,
     @Param('startDateString') startDateString: string,
     @Param('symbol') symbol: string,
-    @Query('range') dateRange: DateRange = 'max',
+    @Query('range') dateRange: DateRange = DEFAULT_DATE_RANGE,
     @Query('accounts') filterByAccounts?: string,
     @Query('assetClasses') filterByAssetClasses?: string,
     @Query('dataSource') filterByDataSource?: string,

apps/api/src/app/portfolio/portfolio.controller.ts

@@ -14,6 +14,7 @@ import { ConfigurationService } from '@ghostfolio/api/services/configuration/con
 import { ImpersonationService } from '@ghostfolio/api/services/impersonation/impersonation.service';
 import { getIntervalFromDateRange } from '@ghostfolio/common/calculation-helper';
 import {
+  DEFAULT_DATE_RANGE,
   HEADER_KEY_IMPERSONATION,
   UNKNOWN_KEY
 } from '@ghostfolio/common/config';
@@ -82,7 +83,7 @@ export class PortfolioController {
     @Query('accounts') filterByAccounts?: string,
     @Query('assetClasses') filterByAssetClasses?: string,
     @Query('dataSource') filterByDataSource?: string,
-    @Query('range') dateRange: DateRange = 'max',
+    @Query('range') dateRange: DateRange = DEFAULT_DATE_RANGE,
     @Query('symbol') filterBySymbol?: string,
     @Query('tags') filterByTags?: string,
     @Query('withMarkets') withMarketsParam = 'false'
@@ -321,7 +322,7 @@ export class PortfolioController {
     @Query('assetClasses') filterByAssetClasses?: string,
     @Query('dataSource') filterByDataSource?: string,
     @Query('groupBy') groupBy?: GroupBy,
-    @Query('range') dateRange: DateRange = 'max',
+    @Query('range') dateRange: DateRange = DEFAULT_DATE_RANGE,
     @Query('symbol') filterBySymbol?: string,
     @Query('tags') filterByTags?: string
   ): Promise<PortfolioDividendsResponse> {
@@ -422,7 +423,7 @@ export class PortfolioController {
     @Query('dataSource') filterByDataSource?: string,
     @Query('holdingType') filterByHoldingType?: string,
     @Query('query') filterBySearchQuery?: string,
-    @Query('range') dateRange: DateRange = 'max',
+    @Query('range') dateRange: DateRange = DEFAULT_DATE_RANGE,
     @Query('symbol') filterBySymbol?: string,
     @Query('tags') filterByTags?: string
   ): Promise<PortfolioHoldingsResponse> {
@@ -455,7 +456,7 @@ export class PortfolioController {
     @Query('assetClasses') filterByAssetClasses?: string,
     @Query('dataSource') filterByDataSource?: string,
     @Query('groupBy') groupBy?: GroupBy,
-    @Query('range') dateRange: DateRange = 'max',
+    @Query('range') dateRange: DateRange = DEFAULT_DATE_RANGE,
     @Query('symbol') filterBySymbol?: string,
     @Query('tags') filterByTags?: string
   ): Promise<PortfolioInvestmentsResponse> {
@@ -527,7 +528,7 @@ export class PortfolioController {
     @Query('accounts') filterByAccounts?: string,
     @Query('assetClasses') filterByAssetClasses?: string,
     @Query('dataSource') filterByDataSource?: string,
-    @Query('range') dateRange: DateRange = 'max',
+    @Query('range') dateRange: DateRange = DEFAULT_DATE_RANGE,
     @Query('symbol') filterBySymbol?: string,
     @Query('tags') filterByTags?: string,
     @Query('withExcludedAccounts') withExcludedAccountsParam = 'false'

apps/api/src/app/portfolio/portfolio.service.ts

@@ -32,6 +32,7 @@ import {
 } from '@ghostfolio/common/calculation-helper';
 import {
   DEFAULT_CURRENCY,
+  DEFAULT_DATE_RANGE,
   TAG_ID_EMERGENCY_FUND,
   TAG_ID_EXCLUDE_FROM_ANALYSIS,
   UNKNOWN_KEY
@@ -470,7 +471,7 @@ export class PortfolioService {
   }
 
   public async getDetails({
-    dateRange = 'max',
+    dateRange = DEFAULT_DATE_RANGE,
     filters,
     impersonationId,
     userId,
@@ -1013,7 +1014,7 @@ export class PortfolioService {
   }
 
   public async getPerformance({
-    dateRange = 'max',
+    dateRange = DEFAULT_DATE_RANGE,
     filters,
     impersonationId,
     userId

apps/api/src/app/user/user.service.ts

@@ -26,6 +26,7 @@ import { PropertyService } from '@ghostfolio/api/services/property/property.serv
 import { TagService } from '@ghostfolio/api/services/tag/tag.service';
 import {
   DEFAULT_CURRENCY,
+  DEFAULT_DATE_RANGE,
   DEFAULT_LANGUAGE_CODE,
   PROPERTY_IS_READ_ONLY_MODE,
   PROPERTY_SYSTEM_MESSAGE,
@@ -281,7 +282,8 @@ export class UserService {
     (user.settings.settings as UserSettings).dateRange =
       (user.settings.settings as UserSettings).viewMode === 'ZEN'
         ? 'max'
-        : ((user.settings.settings as UserSettings)?.dateRange ?? 'max');
+        : ((user.settings.settings as UserSettings)?.dateRange ??
+          DEFAULT_DATE_RANGE);
 
     // Set default value for performance calculation type
     if (!(user.settings.settings as UserSettings)?.performanceCalculationType) {

apps/client/src/app/components/home-overview/home-overview.component.ts

@@ -59,7 +59,6 @@ export class GfHomeOverviewComponent implements OnInit {
   protected readonly routerLinkPortfolioActivities =
     internalRoutes.portfolio.subRoutes.activities.routerLink;
 
-  // Computed signals
   protected readonly deviceType = computed(
     () => this.deviceDetectorService.deviceInfo().deviceType
   );
@@ -70,6 +69,7 @@ export class GfHomeOverviewComponent implements OnInit {
 
   protected readonly showDetails = computed(() => {
     const user = this.user();
+
     return user
       ? !user.settings.isRestrictedView && user.settings.viewMode !== 'ZEN'
       : false;

libs/common/src/lib/config.ts

@@ -81,8 +81,8 @@ export const STATISTICS_GATHERING_QUEUE = 'STATISTICS_GATHERING_QUEUE';
 
 export const DEFAULT_COLOR_SCHEME: ColorScheme = 'LIGHT';
 export const DEFAULT_CURRENCY = 'USD';
-export const DEFAULT_DATE_RANGE: DateRange = 'max';
 export const DEFAULT_DATE_FORMAT_MONTH_YEAR = 'MMM yyyy';
+export const DEFAULT_DATE_RANGE: DateRange = 'max';
 export const DEFAULT_HOST = '0.0.0.0';
 export const DEFAULT_LANGUAGE_CODE = 'en';
 export const DEFAULT_PAGE_SIZE = 50;