Browse Source

fix(lib): remove unused unsubscribe subject as there is no observable subscription

pull/6306/head
Kenrick Tandrian 2 months ago
parent
commit
ccf491225a
  1. 11
      libs/ui/src/lib/holdings-table/holdings-table.component.ts

11
libs/ui/src/lib/holdings-table/holdings-table.component.ts

@ -11,7 +11,6 @@ import {
Component,
EventEmitter,
Input,
OnDestroy,
Output,
computed,
effect,
@ -25,7 +24,6 @@ import { MatSort, MatSortModule } from '@angular/material/sort';
import { MatTableDataSource, MatTableModule } from '@angular/material/table';
import { AssetSubClass } from '@prisma/client';
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
import { Subject } from 'rxjs';
import { GfEntityLogoComponent } from '../entity-logo/entity-logo.component';
import { GfValueComponent } from '../value/value.component';
@ -48,7 +46,7 @@ import { GfValueComponent } from '../value/value.component';
styleUrls: ['./holdings-table.component.scss'],
templateUrl: './holdings-table.component.html'
})
export class GfHoldingsTableComponent implements OnDestroy {
export class GfHoldingsTableComponent {
@Input() baseCurrency: string;
@Input() deviceType: string;
@Input() locale = getLocale();
@ -90,8 +88,6 @@ export class GfHoldingsTableComponent implements OnDestroy {
protected readonly isLoading = computed(() => !this.holdings());
private readonly unsubscribeSubject = new Subject<void>();
constructor() {
this.dataSource.sortingDataAccessor = getLowercase;
@ -120,9 +116,4 @@ export class GfHoldingsTableComponent implements OnDestroy {
this.dataSource.paginator = this.paginator();
});
}
public ngOnDestroy() {
this.unsubscribeSubject.next();
this.unsubscribeSubject.complete();
}
}

Loading…
Cancel
Save