Browse Source

refactor: re-introduce previously removed parameters, mark them as intentionally unused

Signed-off-by: Dominik Willner <th33xitus@gmail.com>
pull/3895/head
dw-0 11 months ago
parent
commit
d1aa34731b
  1. 2
      apps/api/src/app/account/create-account.dto.ts
  2. 2
      apps/api/src/app/account/update-account.dto.ts
  3. 8
      apps/api/src/app/auth/google.strategy.ts
  4. 4
      apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.ts
  5. 4
      apps/client/src/app/components/investment-chart/investment-chart.component.ts
  6. 2
      libs/common/src/lib/chart-helper.ts
  7. 4
      libs/ui/src/lib/line-chart/line-chart.component.ts

2
apps/api/src/app/account/create-account.dto.ts

@ -36,6 +36,6 @@ export class CreateAccountDto {
name: string; name: string;
@IsString() @IsString()
@ValidateIf((value) => value !== null) @ValidateIf((_object, value) => value !== null)
platformId: string | null; platformId: string | null;
} }

2
apps/api/src/app/account/update-account.dto.ts

@ -35,6 +35,6 @@ export class UpdateAccountDto {
name: string; name: string;
@IsString() @IsString()
@ValidateIf((value) => value !== null) @ValidateIf((_object, value) => value !== null)
platformId: string | null; platformId: string | null;
} }

8
apps/api/src/app/auth/google.strategy.ts

@ -25,7 +25,13 @@ export class GoogleStrategy extends PassportStrategy(Strategy, 'google') {
}); });
} }
public async validate(profile: Profile, done: Function) { public async validate(
_request: any,
_token: string,
_refreshToken: string,
profile: Profile,
done: Function
) {
try { try {
const jwt = await this.authService.validateOAuthLogin({ const jwt = await this.authService.validateOAuthLogin({
provider: Provider.GOOGLE, provider: Provider.GOOGLE,

4
apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.ts

@ -29,9 +29,9 @@ import { SymbolProfile } from '@prisma/client';
import { import {
Chart, Chart,
ChartData, ChartData,
LinearScale,
LineController, LineController,
LineElement, LineElement,
LinearScale,
PointElement, PointElement,
TimeScale, TimeScale,
Tooltip, Tooltip,
@ -75,7 +75,7 @@ export class BenchmarkComparatorComponent implements OnChanges, OnDestroy {
Tooltip Tooltip
); );
Tooltip.positioners['top'] = (position: TooltipPosition) => Tooltip.positioners['top'] = (_elements, position: TooltipPosition) =>
getTooltipPositionerMapTop(this.chart, position); getTooltipPositionerMapTop(this.chart, position);
} }

4
apps/client/src/app/components/investment-chart/investment-chart.component.ts

@ -29,9 +29,9 @@ import {
BarElement, BarElement,
Chart, Chart,
ChartData, ChartData,
LinearScale,
LineController, LineController,
LineElement, LineElement,
LinearScale,
PointElement, PointElement,
TimeScale, TimeScale,
Tooltip, Tooltip,
@ -80,7 +80,7 @@ export class InvestmentChartComponent implements OnChanges, OnDestroy {
Tooltip Tooltip
); );
Tooltip.positioners['top'] = (position: TooltipPosition) => Tooltip.positioners['top'] = (_elements, position: TooltipPosition) =>
getTooltipPositionerMapTop(this.chart, position); getTooltipPositionerMapTop(this.chart, position);
} }

2
libs/common/src/lib/chart-helper.ts

@ -103,7 +103,7 @@ export function getVerticalHoverLinePlugin(
colorScheme?: ColorScheme colorScheme?: ColorScheme
) { ) {
return { return {
afterDatasetsDraw: (chart, options) => { afterDatasetsDraw: (chart, _, options) => {
const active = chart.getActiveElements(); const active = chart.getActiveElements();
if (!active || active.length === 0) { if (!active || active.length === 0) {

4
libs/ui/src/lib/line-chart/line-chart.component.ts

@ -27,9 +27,9 @@ import {
import { import {
Chart, Chart,
Filler, Filler,
LinearScale,
LineController, LineController,
LineElement, LineElement,
LinearScale,
PointElement, PointElement,
TimeScale, TimeScale,
Tooltip, Tooltip,
@ -86,7 +86,7 @@ export class GfLineChartComponent
Tooltip Tooltip
); );
Tooltip.positioners['top'] = (position: TooltipPosition) => Tooltip.positioners['top'] = (_elements, position: TooltipPosition) =>
getTooltipPositionerMapTop(this.chart, position); getTooltipPositionerMapTop(this.chart, position);
} }

Loading…
Cancel
Save