Browse Source

Bugfix/various fixes (#407)

* Fix links

* Update column

* Fix impersonation mode

* Update changelog
pull/408/head
Thomas Kaul 3 years ago
committed by GitHub
parent
commit
d1eedf9726
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 7
      CHANGELOG.md
  2. 3
      apps/api/src/app/portfolio/portfolio.controller.ts
  3. 2
      apps/client/src/app/components/accounts-table/accounts-table.component.html
  4. 4
      apps/client/src/app/components/positions-table/positions-table.component.html
  5. 2
      apps/client/src/app/components/positions-table/positions-table.component.ts

7
CHANGELOG.md

@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## Unreleased
### Fixed
- Fixed the links of cryptocurrency assets in the positions table
- Fixed various values in the impersonation mode which have not been nullified
## 1.58.1 - 03.10.2021 ## 1.58.1 - 03.10.2021
### Fixed ### Fixed

3
apps/api/src/app/portfolio/portfolio.controller.ts

@ -175,8 +175,9 @@ export class PortfolioController {
portfolioPosition.grossPerformance = null; portfolioPosition.grossPerformance = null;
portfolioPosition.investment = portfolioPosition.investment =
portfolioPosition.investment / totalInvestment; portfolioPosition.investment / totalInvestment;
portfolioPosition.netPerformance = null;
portfolioPosition.quantity = null; portfolioPosition.quantity = null;
portfolioPosition.value = portfolioPosition.value / totalValue;
} }
for (const [name, { current, original }] of Object.entries(accounts)) { for (const [name, { current, original }] of Object.entries(accounts)) {

2
apps/client/src/app/components/accounts-table/accounts-table.component.html

@ -51,7 +51,7 @@
<ng-container matColumnDef="balance"> <ng-container matColumnDef="balance">
<th *matHeaderCellDef class="px-1 text-right" i18n mat-header-cell> <th *matHeaderCellDef class="px-1 text-right" i18n mat-header-cell>
Balance Cash Balance
</th> </th>
<td *matCellDef="let element" class="px-1 text-right" mat-cell> <td *matCellDef="let element" class="px-1 text-right" mat-cell>
<gf-value <gf-value

4
apps/client/src/app/components/positions-table/positions-table.component.html

@ -83,10 +83,10 @@
*matRowDef="let row; columns: displayedColumns" *matRowDef="let row; columns: displayedColumns"
mat-row mat-row
[ngClass]="{ [ngClass]="{
'cursor-pointer': !ignoreAssetClasses.includes(row.assetClass) 'cursor-pointer': !ignoreAssetSubClasses.includes(row.assetSubClass)
}" }"
(click)=" (click)="
!ignoreAssetClasses.includes(row.assetClass) && !ignoreAssetSubClasses.includes(row.assetSubClass) &&
onOpenPositionDialog({ symbol: row.symbol }) onOpenPositionDialog({ symbol: row.symbol })
" "
></tr> ></tr>

2
apps/client/src/app/components/positions-table/positions-table.component.ts

@ -42,7 +42,7 @@ export class PositionsTableComponent implements OnChanges, OnDestroy, OnInit {
public dataSource: MatTableDataSource<PortfolioPosition> = public dataSource: MatTableDataSource<PortfolioPosition> =
new MatTableDataSource(); new MatTableDataSource();
public displayedColumns = []; public displayedColumns = [];
public ignoreAssetClasses = [AssetClass.CASH.toString()]; public ignoreAssetSubClasses = [AssetClass.CASH.toString()];
public isLoading = true; public isLoading = true;
public pageSize = 7; public pageSize = 7;
public routeQueryParams: Subscription; public routeQueryParams: Subscription;

Loading…
Cancel
Save