Refactor reduce() with getSum() (#3121)

apps/api/src/app/portfolio/portfolio.service.ts

@@ -1575,28 +1575,25 @@ export class PortfolioService {
 
   private getFees({
     activities,
-    date = new Date(0),
     userCurrency
   }: {
     activities: OrderWithAccount[];
-    date?: Date;
     userCurrency: string;
   }) {
-    return activities
+    return getSum(
-      .filter((activity) => {
+      activities
-        // Filter out all activities before given date (drafts)
+        .filter(({ isDraft }) => {
-        return isBefore(date, new Date(activity.date));
+          return isDraft === false;
         })
         .map(({ fee, SymbolProfile }) => {
-        return this.exchangeRateDataService.toCurrency(
+          return new Big(
+            this.exchangeRateDataService.toCurrency(
               fee,
               SymbolProfile.currency,
               userCurrency
+            )
           );
         })
-      .reduce(
-        (previous, current) => new Big(previous).plus(current),
-        new Big(0)
     );
   }
 
@@ -1745,15 +1742,16 @@ export class PortfolioService {
       }
     }
 
-    const dividendInBaseCurrency = (
+    const dividendInBaseCurrency = getSum(
+      (
         await this.getDividends({
           activities: activities.filter(({ type }) => {
             return type === 'DIVIDEND';
           })
         })
-    ).reduce(
+      ).map(({ investment }) => {
-      (previous, current) => new Big(previous).plus(current.investment),
+        return new Big(investment);
-      new Big(0)
+      })
     );
 
     const emergencyFund = new Big(
@@ -1919,33 +1917,26 @@ export class PortfolioService {
   private getSumOfActivityType({
     activities,
     activityType,
-    date = new Date(0),
     userCurrency
   }: {
     activities: OrderWithAccount[];
     activityType: ActivityType;
-    date?: Date;
     userCurrency: string;
   }) {
-    return activities
+    return getSum(
-      .filter((activity) => {
+      activities
-        // Filter out all activities before given date (drafts) and
+        .filter(({ isDraft, type }) => {
-        // activity type
+          return isDraft === false && type === activityType;
-        return (
-          isBefore(date, new Date(activity.date)) &&
-          activity.type === activityType
-        );
         })
         .map(({ quantity, SymbolProfile, unitPrice }) => {
-        return this.exchangeRateDataService.toCurrency(
+          return new Big(
+            this.exchangeRateDataService.toCurrency(
               new Big(quantity).mul(unitPrice).toNumber(),
               SymbolProfile.currency,
               userCurrency
+            )
           );
         })
-      .reduce(
-        (previous, current) => new Big(previous).plus(current),
-        new Big(0)
     );
   }