Refactoring

apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts

@@ -449,13 +449,16 @@ export class ExchangeRateDataService {
               factors[format(date, DATE_FORMAT)] = factor;
             }
           } catch {
-            Logger.error(
+            let errorMessage = `No exchange rate has been found for ${currencyFrom}${currencyTo} at ${format(
-              `No exchange rate has been found for ${currencyFrom}${currencyTo} at ${format(
+              date,
-                date,
+              DATE_FORMAT
-                DATE_FORMAT
+            )}. Please complement market data for ${DEFAULT_CURRENCY}${currencyFrom}`;
-              )}. Please complement market data for ${DEFAULT_CURRENCY}${currencyFrom}${DEFAULT_CURRENCY === currencyTo ? '' : ` and ${DEFAULT_CURRENCY}${currencyTo}`}.`,
+
-              'ExchangeRateDataService'
+            if (DEFAULT_CURRENCY !== currencyTo) {
-            );
+              errorMessage = `${errorMessage} and ${DEFAULT_CURRENCY}${currencyTo}`;
+            }
+
+            Logger.error(`${errorMessage}.`, 'ExchangeRateDataService');
           }
         }
       }