Address review feedback

apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.ts

@@ -72,11 +72,13 @@ export class GfBenchmarkComparatorComponent implements OnChanges, OnDestroy {
   public readonly benchmarks = input<Partial<SymbolProfile>[]>();
   public readonly colorScheme = input<ColorScheme>();
   public readonly isLoading = input<boolean>();
+
   public readonly locale = input(getLocale(), {
     transform: (value?: string) => {
       return value ?? getLocale();
     }
   });
+
   public readonly performanceDataItems = input.required<LineChartItem[]>();
   public readonly user = input<User>();
 

libs/ui/src/lib/accounts-table/accounts-table.component.ts

@@ -62,11 +62,13 @@ export class GfAccountsTableComponent {
   public readonly hasPermissionToDeleteAccount = input<boolean>();
   public readonly hasPermissionToOpenDetails = input(true);
   public readonly hasPermissionToUpdateAccount = input<boolean>();
+
   public readonly locale = input(getLocale(), {
     transform: (value?: string) => {
       return value ?? getLocale();
     }
   });
+
   public readonly showActions = input<boolean>();
   public readonly showActivitiesCount = input(true);
   public readonly showAllocationInPercentage = input<boolean>();

libs/ui/src/lib/benchmark/benchmark-detail-dialog/benchmark-detail-dialog.html

@@ -1,7 +1,7 @@
 <gf-dialog-header
   position="center"
   [deviceType]="data.deviceType"
-  [title]="assetProfile?.name ?? assetProfile?.symbol ?? ''"
+  [title]="assetProfile?.name ?? assetProfile?.symbol"
   (closeButtonClicked)="onClose()"
 />
 

libs/ui/src/lib/dialog-header/dialog-header.component.ts

@@ -29,7 +29,7 @@ export class GfDialogHeaderComponent {
     addIcons({ close });
   }
 
-  public onClickCloseButton() {
+  protected onClickCloseButton() {
     this.closeButtonClicked.emit();
   }
 }

libs/ui/src/lib/holdings-table/holdings-table.component.ts

@@ -54,11 +54,13 @@ export class GfHoldingsTableComponent {
   public readonly hasPermissionToShowQuantities = input(true);
   public readonly hasPermissionToShowValues = input(true);
   public readonly holdings = input.required<PortfolioPosition[] | undefined>();
+
   public readonly locale = input(getLocale(), {
     transform: (value?: string) => {
       return value ?? getLocale();
     }
   });
+
   public readonly mode = input<'default' | 'simple'>('default');
   public readonly pageSize = model(Number.MAX_SAFE_INTEGER);