Feature/clean up all time high and low from performance endpoint (#551)

* Remove isAllTimeHigh / isAllTimeLow

* Update changelog

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Changed
+
+- Removed the redundant all time high and all time low from the performance endpoint
+
 ### Fixed
 
 - Fixed the symbol conversion from _Yahoo Finance_ including a hyphen

apps/api/src/app/portfolio/portfolio.service.ts

@@ -693,9 +693,7 @@ export class PortfolioService {
           currentGrossPerformancePercent: 0,
           currentNetPerformance: 0,
           currentNetPerformancePercent: 0,
-          currentValue: 0,
+          currentValue: 0
-          isAllTimeHigh: false,
-          isAllTimeLow: false
         }
       };
     }
@@ -728,9 +726,7 @@ export class PortfolioService {
         currentGrossPerformancePercent,
         currentNetPerformance,
         currentNetPerformancePercent,
-        currentValue,
+        currentValue
-        isAllTimeHigh: true,
-        isAllTimeLow: false
       }
     };
   }

libs/common/src/lib/interfaces/portfolio-performance.interface.ts

@@ -5,6 +5,4 @@ export interface PortfolioPerformance {
   currentNetPerformance: number;
   currentNetPerformancePercent: number;
   currentValue: number;
-  isAllTimeHigh: boolean;
-  isAllTimeLow: boolean;
 }