Refactor portfolio service

apps/api/src/app/portfolio/portfolio.service.ts

@@ -720,7 +720,16 @@ export class PortfolioService {
         dividendInBaseCurrency,
         fee,
         firstBuyDate,
+        grossPerformance,
+        grossPerformancePercentage,
+        grossPerformancePercentageWithCurrencyEffect,
+        grossPerformanceWithCurrencyEffect,
+        investmentWithCurrencyEffect,
         marketPrice,
+        netPerformance,
+        netPerformancePercentage,
+        netPerformancePercentageWithCurrencyEffectMap,
+        netPerformanceWithCurrencyEffectMap,
         quantity,
         tags,
         timeWeightedInvestment,
@@ -856,23 +865,21 @@ export class PortfolioService {
           SymbolProfile.currency,
           userCurrency
         ),
-        grossPerformance: holding.grossPerformance?.toNumber(),
+        grossPerformance: grossPerformance?.toNumber(),
-        grossPerformancePercent: holding.grossPerformancePercentage?.toNumber(),
+        grossPerformancePercent: grossPerformancePercentage?.toNumber(),
         grossPerformancePercentWithCurrencyEffect:
-          holding.grossPerformancePercentageWithCurrencyEffect?.toNumber(),
+          grossPerformancePercentageWithCurrencyEffect?.toNumber(),
         grossPerformanceWithCurrencyEffect:
-          holding.grossPerformanceWithCurrencyEffect?.toNumber(),
+          grossPerformanceWithCurrencyEffect?.toNumber(),
         historicalData: historicalDataArray,
         investmentInBaseCurrencyWithCurrencyEffect:
-          holding.investmentWithCurrencyEffect?.toNumber(),
+          investmentWithCurrencyEffect?.toNumber(),
-        netPerformance: holding.netPerformance?.toNumber(),
+        netPerformance: netPerformance?.toNumber(),
-        netPerformancePercent: holding.netPerformancePercentage?.toNumber(),
+        netPerformancePercent: netPerformancePercentage?.toNumber(),
         netPerformancePercentWithCurrencyEffect:
-          holding.netPerformancePercentageWithCurrencyEffectMap?.[
+          netPerformancePercentageWithCurrencyEffectMap?.['max']?.toNumber(),
-            'max'
-          ]?.toNumber(),
         netPerformanceWithCurrencyEffect:
-          holding.netPerformanceWithCurrencyEffectMap?.['max']?.toNumber(),
+          netPerformanceWithCurrencyEffectMap?.['max']?.toNumber(),
         performances: {
           allTimeHigh: {
             performancePercent,